Re: [1/4] xolehlp: fix calling convention

2013-04-30 Thread Nikolay Sivov

On 5/1/2013 01:43, Daniel Jeliński wrote:

Please fix spec file accordingly.




Google Summer of Code 2013, Tools - Implement new control panel applets

2013-04-30 Thread Brock York
Hey Everyone,
I've been wanting to get into Google Summer of Code and Wine development
for quite a while now.
I was looking on the wine ideas page : http://wiki.winehq.org/SummerOfCode

I'm interested in doing the first one: Tools - Implement new control panel
applets, but am wondering what I would actually be able to do.
I've done basic opengl applications before but using a library like SDL to
do the lowerlevel stuff.

What kind of opengl test would be preferred?
Something like a port of GLXgears to wine or something that just tests if
it can create a Opengl context and then exits saying success?
I don't know how to test whether opengl was compiled into wine either,
would that be very hard to do? I've never had write code to test if a
feature was enabled before.

Any suggestions on what kind of test I should try and implement would be
greatly appreciated so I can try and get a proposal in.
I know I'm leaving it pretty late but I only found out it was open a few
hours ago.

For a background of my knowledge I'm currently in my 3rd year of a computer
science degree at my University, I also did a year of programming at a
college.
I've been using linux for 6 years but haven't been able to get to grips
with programming for wine I always get confused or lost when trying to
learn how wine works when
trying to debug a game. I'm hoping doing something like this will be able
to get me started on wine with a mentors help to guide me.
Thanks.
Regards Brock York



Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)

2013-04-30 Thread Alexandre Julliard
Sam Edwards  writes:

> Content-wise, this is the same as try 2. However, there are two differences:
>
> 1. I merged the tests down into the same patch.
> 2. This won't crash anymore: see patch 1 in this series.

It still crashes:

Program received signal SIGSEGV, Segmentation fault.
0x7550f680 in get_glyph_outline (incoming_font=, 
glyph=, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, 
buf=0x538c4, lpmat=0x75535140) at ../../../wine/dlls/gdi32/freetype.c:6389
6389 ((unsigned int)src[hmul * x + 
rgb_interval * 2] <<  0) |
(gdb) bt
#0  0x7550f680 in get_glyph_outline (incoming_font=, 
glyph=, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, 
buf=0x538c4, lpmat=0x75535140) at ../../../wine/dlls/gdi32/freetype.c:6389
#1  0x7550fd1e in freetype_GetGlyphOutline (dev=0x40df0, 
glyph=, format=, lpgm=0x22c9f0, buflen=288, 
buf=0x538c4, lpmat=0x75535140) at ../../../wine/dlls/gdi32/freetype.c:7133
#2  0x754fcd84 in GetGlyphOutlineW (hdc=, uChar=103, 
fuFormat=17, lpgm=0x22c9f0, cbBuffer=288, lpBuffer=0x538c4, 
lpmat2=0x75535140) at ../../../wine/dlls/gdi32/font.c:2813
#3  0x754c97b5 in render_string (hdc=0x490031, dib=, 
font=0x43cb0, x=95, y=11, flags=12288, str=0x51b70, count=13, dx=0x53470, 
clipped_rects=0x22cbb0, bounds=0x22cba0) at 
../../../wine/dlls/gdi32/dibdrv/graphics.c:707

-- 
Alexandre Julliard
julli...@winehq.org




Re: [PATCH 4/4] d3dx9_36: Remove todo in tests as it works now with last d3dxof fixes.

2013-04-30 Thread Matteo Bruni
2013/4/29 Christian Costa :
>
> ---
>  dlls/d3dx9_36/tests/xfile.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c
> index 1238bcd..e514a5f 100644
> --- a/dlls/d3dx9_36/tests/xfile.c
> +++ b/dlls/d3dx9_36/tests/xfile.c
> @@ -77,7 +77,7 @@ static void test_templates(void)
>  ok(ret == D3DXFERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, 
> expected %#x\n", ret, D3DXFERR_BADFILEFLOATSIZE);
>
>  ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, 
> templates_parse_error, sizeof(templates_parse_error) - 1);
> -todo_wine ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned 
> %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR);
> +ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected 
> %#x\n", ret, D3DXFERR_PARSEERROR);
>
>  ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates, 
> sizeof(templates) - 1);
>  ok(ret == S_OK, "RegisterTemplates failed with %#x\n", ret);

Hi Christian,
good catch for that todo_wine. However, this should be merged with the
patch actually fixing the test (I guess it's patch 2).




Re: [2/2] include: Make KNONVOLATILE_CONTEXT_POINTERS match PSDK definition.

2013-04-30 Thread Alexandre Julliard
Dmitry Timoshkov  writes:

> Hi,
>
> This patch has status "Build failure", but it compiles without errors here
> with 32 and 64-builds. What kind of a failure is that?

gcc -c -I../../../wine/dlls/ntdll -I. -I../../../wine/include -I../../include  
-D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing 
-Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers 
-Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings 
-gdwarf-2 -gstrict-dwarf -Wpointer-arith -Wlogical-op -I/usr/include/freetype2  
  -g -O2  -o rtl.o ../../../wine/dlls/ntdll/rtl.c
In file included from ../../../wine/include/windef.h:252:0,
 from ../../../wine/dlls/ntdll/rtl.c:40:
../../../wine/include/winnt.h:1185:11: error: duplicate member ‘s’
make[1]: *** [rtl.o] Error 1

-- 
Alexandre Julliard
julli...@winehq.org




Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-30 Thread Sam Edwards


On 04/29/2013 08:20 AM, Alexandre Julliard wrote:

Well, there was no backtrace since winedbg crashes. Fortunately gdb
works:


Big thanks! I found the problem (it only happened with subpixel 
rendering, which I don't have enabled) and am resending the patches now. :)





Re: kernel32: Add some tests for PEB and loader locks.

2013-04-30 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25367

Your paranoid android.


=== TEST64_W7SP1 (32 bit loader) ===
loader.c:1952: Test failed: WaitForSingleObject failed: 102
loader.c:1954: Test failed: expected exit code 199, got 259
loader.c:1963: Test failed: WaitForSingleObject failed: 102
loader.c:1968: Test failed: expected 198, got 259
loader.c:1972: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0
loader.c:2018: Test failed: expected ERROR_ACCESS_DENIED, got 487
loader.c:2028: Test failed: VirtualFreeEx should fail
loader.c:2029: Test failed: expected ERROR_ACCESS_DENIED, got -559038737
loader.c:2032: Test failed: VirtualAllocEx should fail
loader.c:2033: Test failed: expected ERROR_ACCESS_DENIED, got -559038737
loader.c:2042: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0