Re: clusapi: [RESEND] Implements stub dll for clusapi
When I was creating the stub I looked around in several dll's and some of the them export DllMain. ./advpack/advpack.spec:@ stdcall -private DllMain(long long ptr) ./dciman32/dciman32.spec:@ stdcall -private DllEntryPoint(long long ptr) DllMain ./itss/itss.spec:@ stdcall -private DllMain(long long ptr) ./msimg32/msimg32.spec:@ stdcall -private DllInitialize(long long ptr) DllMain Then in what case do you need to export? Benjamin On 9/28/06, Robert Shearman <[EMAIL PROTECTED]> wrote: Benjamin Arai wrote: > +@ stdcall -private DllMain(long long ptr) > There's no need to export DllMain. -- Rob Shearman -- Benjamin Arai http://www.benjaminarai.com
Re: oleaut32 2/2: [RESEND] Conformance test for varformat:VarWeekdayName
I looked up the code pages for English and Russian. Obviously, I get "Monday" for English but for Russian the same day is "ïîíåäåëüíèê". I don't see how this can me made locale dependent. I would have to make a table for each of the locales to test them. LOCALE_INVARIANT flag is not implemented in Wine. Regardless, I don't think LOCALE_INVARIANT will work either because it only accounts for special composition of characters and not translation. The other tests in the On 9/27/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "Dan Kegel" <[EMAIL PROTECTED]> writes: > Alexandre wrote: >> How will this test work in non-English locales? > > How about if it calls SetThreadLocale(LOCALE_INVARIANT)? It's probably better to really make the test locale-dependent, so that the behavior gets tested in different locales. Of course you can also test both cases. -- Alexandre Julliard [EMAIL PROTECTED] -- Benjamin Arai http://www.benjaminarai.com
Re: oleaut32 1/2: Implements function variant:VarImp
Sounds good, but in that case shouldn't I also change the one for UINT to something like ~(UINT)0? Benjamin Alexandre Julliard wrote: > "Benjamin Arai" <[EMAIL PROTECTED]> writes: > >> +case VT_I1: if (V_I1(left) == -1) resvt = VT_NULL; break; >> +case VT_UI1:if (V_UI1(left) == 0xff) resvt = VT_NULL; break; >> +case VT_I2: if (V_I2(left) == -1) resvt = VT_NULL; break; >> +case VT_UI2:if (V_UI2(left) == 0x) resvt = VT_NULL; break; >> +case VT_INT:if (V_INT(left) == -1) resvt = VT_NULL; break; >> +case VT_UINT: if (V_UINT(left) == 0x) resvt = VT_NULL; >> break; >> +case VT_I4: if (V_I4(left) == -1) resvt = VT_NULL; break; >> +case VT_UI4:if (V_UI4(left) == 0x) resvt = VT_NULL; >> break; >> +case VT_I8: if (V_I8(left) == -1) resvt = VT_NULL; break; >> +case VT_UI8:if (V_UI8(left) == 0x) resvt = VT_NULL; >> break; > > Shouldn't the last one be something like ~(ULONGLONG)0 instead of > 0x? >
RE: oleaut32 2/3: Updates variant:VarAnd to pass all failures exposed from conformance test
Hi, You are right, I sent the first patch twice by accident. Please disregard the patches, I will resend it tomorrow. Sorry for the trouble. Benjamin Arai > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Dan Kegel > Sent: Monday, August 28, 2006 7:50 PM > To: wine-devel@winehq.org; [EMAIL PROTECTED] > Subject: Re: oleaut32 2/3: Updates variant:VarAnd to pass all > failures exposed from conformance test > > Did you attach the right patch? Seems like this is the same as #1. > > On 8/28/06, Benjamin Arai <[EMAIL PROTECTED]> wrote: > > Hi, > > > > ChangeLog: > > - Removes all todo_wine's in VarAnd conformance test > > - Fixes VarAnd to pass all tests in Windows XP SP2 and Wine > > > > --- > > dlls/oleaut32/tests/vartest.c | 78 -- > > dlls/oleaut32/variant.c | 327 > + > > 2 files changed, 269 insertions(+), 136 deletions(-) > > > > Copyright: Google > > License: LGPL > > -- > > Benjamin Arai > > http://www.benjaminarai.com > > > > > > > > > > > > > > > > > -- > Wine for Windows ISVs: http://kegel.com/wine/isv > >
vartest.c contains varformat.c tests
Hi,A bug was submitted (http://bugs.winehq.org/show_bug.cgi?id=5306) that vartest.c was getting too large and that it needs to be smaller. I don't think to much can be done about the size but I did notice that all the tests for varformat.c are being put into vartest.c as opposed to making a new test file test/varformat.c. Would there be any problems if I create a new test file for varformat.c and move the appropriate test from vartest.c to it? -- Benjamin Araihttp://www.benjaminarai.com
Question regarding VT_INT in oleaut32
Hi, I wrote a conformance test for oleaut32:VariantChangeType but I ran into a snag. The conformance test under windows does not allow the conversion from type VT_INT to VT_I8 but it does allow for VT_I4 to VT_I8. I made the necessary changes to VariantChangeType so that it conforms to windows but in doing so, it has broken several functions that use VariantChangeType to coerce from VT_INT to VT_I8 cause several conformance tests to fail as a result. Is it reasonable to fix the now failing functions in wine by converting VT_INT to VT_I4 before coercing in the broken functions? This will fix the conformance tests but I want to make sure that we can assume VT_INT is a 4 byte integer before proceeding. Any help is greatly appreciated. Benjamin Arai [EMAIL PROTECTED]
Parallels Virtualization Software does not work with Wine
Hi, Just a quick note to any body using VMware or the like for testing Wine, as of Parallels version 2.1 Wine would not run under any guest operating system that I tested (in all cases Wine caused a segmentation fault upon starting). I was using Parallels (Host: Windows XP, Guest: Centos OS 4.3, Ubuntu 6.06, and Fedora Core 5), none worked in Parallels and all worked running native. I am pretty sure this is not a Wine problem, I think it is a trapping issue on Parallels side. Benjamin Arai [EMAIL PROTECTED] http://www.benjaminarai.com
