Re: Wiki is down

2013-08-23 Thread Dimi Paun
Wiki back up, sorry about that!



On Fri, Aug 23, 2013 at 10:31 AM, Dimi Paun  wrote:

> Looking into it right now...
>
>
> On Fri, Aug 23, 2013 at 10:18 AM, Michael Stefaniuc 
> wrote:
>
>> On 08/23/2013 03:39 PM, Rosanne DiMesio wrote:
>> > I'm getting an "Unable to connect" message from Firefox and "Connection
>> closed by remote server" from Opera.
>> CC'ing Dimi as he might not read wine-devel so often.
>>
>> bye
>> michael
>>
>
>
>
> --
> Dimi Paun 
> Lattica, Inc.
>
>


-- 
Dimi Paun 
Lattica, Inc.



Re: Wiki is down

2013-08-23 Thread Dimi Paun
Looking into it right now...


On Fri, Aug 23, 2013 at 10:18 AM, Michael Stefaniuc wrote:

> On 08/23/2013 03:39 PM, Rosanne DiMesio wrote:
> > I'm getting an "Unable to connect" message from Firefox and "Connection
> closed by remote server" from Opera.
> CC'ing Dimi as he might not read wine-devel so often.
>
> bye
> michael
>



-- 
Dimi Paun 
Lattica, Inc.



Re: Fresh WineWiki Theme, Straight from the Farm

2013-04-06 Thread Dimi Paun
Hi Kyle,

Thanks for the update, and sorry for the late reply!

I've actually deployed your theme to production already:
http://wiki.winehq.org

My only change was this:

diff --git a/winewiki.conf b/winewiki.conf
index 4e79248..e3da9cc 100644
--- a/winewiki.conf
+++ b/winewiki.conf
@@ -8,7 +8,8 @@
 #RewriteLog "/var/log/httpd/rewrite.log"
 # map some static files to their respective locations
 RewriteRule ^/favicon.ico$ /var/www/wine/wiki/favicon.ico [last]
-RewriteRule ^/logo.png$ /var/www/wine/wiki/logo.png [last]
+RewriteRule ^/logo_glass.png$ /var/www/wine/wiki/logo_glass.png [last]
+RewriteRule ^/logo_text.png$ /var/www/wine/wiki/logo_text.png [last]
 # map /wiki static files to Moin htdocs
 RewriteRule ^/wiki/(.*)$ /usr/share/moin/htdocs/$1 [last]
 # map everything else to server script

Dimi.

On Sat, Mar 30, 2013 at 5:08 PM, Kyle Auble  wrote:

> So as usual, my estimate of how long it would take was way off, but
> I'm finally done adapting the WineHQ theme to Moinmoin.
>
> It's not perfect, but I feel it's ready to submit for switching over.
> I've tested it in Firefox, Chromium, Midori, and Opera (briefly in
> IE8 & IE9 too). I did do everything through Moinmoin's stand-alone
> server, but while I know there always seem to be ghosts in the
> machine, I'm guessing that Apache shouldn't interfere with layout
> issues.
>
> I mostly followed the WineHQ & current WineWiki theme for large
> things, just tweaking the CSS to make it fit what Moinmoin spits out.
> I did make more design choices of my own on the smaller stuff though.
> After wrestling with Moinmoin's theme system, I was surprised how
> many things are still hard-coded (at least as of v1.5).
>
> For example, Moinmoin wraps some things in divs without providing a
> CSS class for the div, just the child element. The fortune cookie on
> the RecentChanges page & the edit page are two cases of that. The
> dummy content in the search bar is another tricky one. It's set in
> the javascript for the search bar (don't remember where it was in the
> source tree) so I left that one alone.
>
> One other tricky issue was handling overflows & RTL support. They
> both seem to work ok in isolation, but go crazy when you mix them. I
> haven't checked RTL in IE, but if you force an RTL page to overflow
> in Webkit, it positions things based on what's actually in the window
> (so the sidebar winds up floating in the middle of the page). Firefox
> simply doesn't try to apply any of the overflow rules in RTL (which I
> guess is nice in a Hippocratic sense). Opera alone handled things
> exactly like I hoped.
>
> As for the tables, I think they should display ok now, although I
> don't know if everyone wants my exact values for paddings & such. The
> old theme had some table-based layout that may have had conflicting
> CSS rules, but I've div-vied everything up so the only table tags now
> should be when Moinmoin itself chooses them over a div and well...
> tables.
>
> I've pushed all of the changes to my Bitbucket repo at:
> https://bitbucket.org/kauble/wine-wiki-migration
> The "refined" branch is the one you want although I expect that once
> the code is hosted at WineHQ's git repo, it would become the new
> master branch. At that point, I can just reset my repo to point to
> the WineHQ one as the origin.
>
> - Kyle
>



-- 
Dimi Paun 
Lattica, Inc.



Re: Wiki is down

2013-03-27 Thread Dimi Paun
Thanks for the bug report, it should be fixed now.

Dimi.

On Wed, Mar 27, 2013 at 12:57 PM, Francois Gouget  wrote:

> On Mon, 25 Mar 2013, Dimi Paun wrote:
>
> > Should be up now, the RAID controller on the box died.
> > We'll be moving it to a better box soon, stay tuned.
>
> Do you know what's up with this message?
>
>   Status of sending notification mails:
>   [en] fracting: Connection to mailserver 'mail.lattica.com' failed:
> (101, 'Network is unreachable')
>
> Note that it was present before the RAID card trouble so it's not
> caused by your recent changes.
>
> See also bug 33231 - Wiki: Trouble sending notification emails
> http://bugs.winehq.org/show_bug.cgi?id=33231
>
> --
> Francois Gouget   http://fgouget.free.fr/
>   tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
>



-- 
Dimi Paun 
Lattica, Inc.



Re: Wiki is down

2013-03-25 Thread Dimi Paun
Should be up now, the RAID controller on the box died.
We'll be moving it to a better box soon, stay tuned.

Dimi.

On Mon, Mar 25, 2013 at 10:06 AM, Dimi Paun  wrote:

> Working on it guys, I'll keep you posted.
>
> Dimi.
>
> On Mon, Mar 25, 2013 at 7:18 AM, Francois Gouget  wrote:
>
>> On Sun, 24 Mar 2013, Rosanne DiMesio wrote:
>>
>> > I'm getting an "Internal Server Error" message when I try to access the
>> wiki.
>>
>> Cc-ing in case you missed this email (the Wiki is still down :-( ).
>>
>>
>> --
>> Francois Gouget   http://fgouget.free.fr/
>>      Dieu dit: "M-x Lumière". Et la lumière fut.
>
>
>
>
> --
> Dimi Paun 
> Lattica, Inc.
>
>


-- 
Dimi Paun 
Lattica, Inc.



Re: Wiki is down

2013-03-25 Thread Dimi Paun
Working on it guys, I'll keep you posted.

Dimi.

On Mon, Mar 25, 2013 at 7:18 AM, Francois Gouget  wrote:

> On Sun, 24 Mar 2013, Rosanne DiMesio wrote:
>
> > I'm getting an "Internal Server Error" message when I try to access the
> wiki.
>
> Cc-ing in case you missed this email (the Wiki is still down :-( ).
>
>
> --
> Francois Gouget   http://fgouget.free.fr/
>  Dieu dit: "M-x Lumière". Et la lumière fut.




-- 
Dimi Paun 
Lattica, Inc.



Re: wiki

2013-01-20 Thread Dimi Paun

On 13-01-20 11:52 AM, André Hentschel wrote:

Am 20.01.2013 17:21, schrieb Rico Schüller:

Hi,

is anyone able to get the wiki up again? Somehow the wiki 
(http://wiki.winehq.org/) is not reachable from here.

Cheers
Rico



Forwarding to Dimi, but i would not expect much on a sunday ;)


Our server is up, but it looks like the winehq DNS has a problem:

orion:Downloads dimi$ ping wiki.winehq.org
ping: cannot resolve wiki.winehq.org: Unknown host

orion:Downloads dimi$ ping winehq.org
PING winehq.org (209.46.25.134): 56 data bytes
92 bytes from 192.168.3.1: Redirect Host(New addr: 192.168.3.250)
Vr HL TOS  Len   ID Flg  off TTL Pro  cks  Src  Dst
 4  5  00 0054 7e22   0   3f  01 4e74 192.168.3.182 209.46.25.134

64 bytes from 209.46.25.134: icmp_seq=0 ttl=48 time=97.656 ms
64 bytes from 209.46.25.134: icmp_seq=1 ttl=48 time=71.616 ms
64 bytes from 209.46.25.134: icmp_seq=2 ttl=48 time=74.423 ms

--
Dimi Paun 
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-15 Thread Dimi Paun

Hi folks,

Thanks for all the help and hits -- much appreciated.

I ended up writing a few scripts myself that cleaned up
both the pages and users. It should do for now.

Please let me know if you see any problems with the
wiki, I hope I wasn't over-eager when cleaning up spam :)))

Cheers,
Dimi.

On 01/15/2013 11:10 AM, Kyle Auble wrote:

On Tue, Jan 15, 2013 at 1:06 PM, Dimi Paun wrote:

Thanks everyone for your help!
I'll take down the Pages spreadsheet.
Now, what about the users? Those are files (not directories) so we don't
face
the same low limit (32k), but it would be nice if we could, somehow, cleanup
those files as well.

If I'm remembering right, a full install of Moinmoin (not just running the
service portably in the unpacked tree) puts a moin command into /usr/bin.
The documentation for it isn't great yet, but you can find it at
http://master.moinmo.in/HelpOnMoinCommand.

Unfortunately, it doesn't have a mechanism for cleaning out users beyond
obvious duplicate accounts. One possibility that I was looking at is that
v1.5 of Moinmoin updates ".trail" files for all logged-in users, even if
the page trail display has been disabled.

The idea was to scan the user directory for all .trail files with a mod-time
older than a certain time period (I picked 1 year). If a user has logged in
to do anything more recently than then, it should show up in the mod-time of
the .trail file.

I wanted to test my scripts a little more, but this was one thing my
sweep-once script at https://bitbucket.org/kauble/moin-admin was designed
to do. Besides blanking-out and putting "file.new" instead of "file.tmp" in
line 96 of split-logs.pl, the logic seemed sound on small test batches. I
wanted to try it on a full copy of the Wine Wiki just to be safe though.

On Tue, Jan 15, 2013 at 4:40 AM, André Hentschel wrote:

This should also speed up that old wiki and maybe helps upgrading it (hopefully 
that'll happen soon :D).

I haven't touched a line of code in a couple of months (had a holiday job that
really knocked the wind from my sails at times), but after getting settled into
my classes over the next few days, I plan on working on moving the wiki to
v1.9 of Moinmoin again.

The one thing that would probably help a lot is if there was a regularly
updated tarball of the wiki content either at WineHQ or Lattica's FTP again. I
haven't messed with cron itself much, but my archive.cron script should pack
up the files correctly. The main complication is that the user dir probably
should be shared on a need-to-know basis because it contains weakly-hashed
password info.

Kyle



--
Dimi Paun
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

On 13-01-14 11:11 PM, Dmitry Timoshkov wrote:

Hi Dimi,

Dimi Paun  wrote:


I've cleanup the deleted pages, were down to about 740 pages,
mostly good stuff:

https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5

Please check it out, lemme know if any spam is still left standing.

At least the following pages don't exist (and seem to be deleted as spam):

AdamSpang
AntoineX56
BoyceUai
CharlesYJI
CyrilBann

I didn't check futher entries, may be your scrpt can do that?


Thanks -- some of these where skipped by the first pass of the script.
Ran it again, we're down to 729. However, eyeballing the result looks pretty
clean, so I'll say this is good enough for now, as far as pages are 
concerned.


Thanks everyone for your help!

I'll take down the Pages spreadsheet.

Now, what about the users? Those are files (not directories) so we don't 
face

the same low limit (32k), but it would be nice if we could, somehow, cleanup
those files as well.

--
Dimi Paun 
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

Hi guys,

I've cleanup the deleted pages, were down to about 740 pages,
mostly good stuff:

https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5

Please check it out, lemme know if any spam is still left standing.

Any ideas on how we can attack the spam users?

Dimi.

On 13-01-14 7:16 PM, André Hentschel wrote:

Am 14.01.2013 21:40, schrieb Andrew Eikum:

On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote:

OK, we might be onto something. I've wrote a script
to determine the deleted pages: 20162.

Should I just go ahead and nuke those?


Probably, yes.

One common way for spammers to abuse wikis is to intentionally get the
pages deleted, so that they live on permanently in the revision
history.

See this example from today:
It's rightfully deleted as spam:
   http://wiki.winehq.org/SheriOci
But the "Get Info" link leads you to the old revision, with the
linkspam intact:
   http://wiki.winehq.org/SheriOci?action=recall&rev=1

I don't know if there's a way to keep Moinmoin from preserving
revision history on deleted pages, but it might be sufficient to
simply disable that. I doubt there's much useful history on deleted
pages anyway.

seems done, and know what? The wiki seems to be more than 10 times faster. (i 
tried e.g. editing -> preview)
good choice!
Thanks Dimi for working on this!!!





--
Dimi Paun 
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun
Yes it is done. Ill update the spreadsheet bit later...

André Hentschel  wrote:

>Am 14.01.2013 21:40, schrieb Andrew Eikum:
>> On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote:
>>> OK, we might be onto something. I've wrote a script
>>> to determine the deleted pages: 20162.
>>>
>>> Should I just go ahead and nuke those?
>>>
>> 
>> Probably, yes.
>> 
>> One common way for spammers to abuse wikis is to intentionally get the
>> pages deleted, so that they live on permanently in the revision
>> history.
>> 
>> See this example from today:
>> It's rightfully deleted as spam:
>>   http://wiki.winehq.org/SheriOci
>> But the "Get Info" link leads you to the old revision, with the
>> linkspam intact:
>>   http://wiki.winehq.org/SheriOci?action=recall&rev=1
>> 
>> I don't know if there's a way to keep Moinmoin from preserving
>> revision history on deleted pages, but it might be sufficient to
>> simply disable that. I doubt there's much useful history on deleted
>> pages anyway.
>
>seems done, and know what? The wiki seems to be more than 10 times faster. (i 
>tried e.g. editing -> preview)
>good choice!
>Thanks Dimi for working on this!!!
>
>
>-- 
>
>Best Regards, André Hentschel



Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

OK, we might be onto something. I've wrote a script
to determine the deleted pages: 20162.

Should I just go ahead and nuke those?

Dimi.

On 01/14/2013 01:35 PM, Francois Gouget wrote:

On Mon, 14 Jan 2013, Dimi Paun wrote:


MoinMoin creates a dir for every page. I simply got the list
by listing these directories. (This is the problem -- there is a
limit of 2^15 subdirectories, and this is what we were hitting
a few days ago).

Does that answer the question?

It feels like your methodology is flawed.
Let's take the "Jaw crusher from joyal jc001j" page as an example.

As far as I can tell that page has already been deleted. MoinMoin knows
that. So you should not need us humans to waste time going through
2+ rows of the spreadsheet to tell you that the directory
corresponds to a deleted page.

So is your problem that you want to preserve non-spam deleted pages?

Can't a script go through these directories, notice that the page has
been deleted, that the delete comment contains the word 'spam' and then
delete the directory?





--
Dimi Paun
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

Hm, it doesn't seem to be so simple.
Each page maintains an edit-log file with all the changes.

grep-ing for -i spam in the edit-log yields less than 400 hits.

Maybe we should look for deleted pages?

Dimi.

On 01/14/2013 01:35 PM, Francois Gouget wrote:

On Mon, 14 Jan 2013, Dimi Paun wrote:


MoinMoin creates a dir for every page. I simply got the list
by listing these directories. (This is the problem -- there is a
limit of 2^15 subdirectories, and this is what we were hitting
a few days ago).

Does that answer the question?

It feels like your methodology is flawed.
Let's take the "Jaw crusher from joyal jc001j" page as an example.

As far as I can tell that page has already been deleted. MoinMoin knows
that. So you should not need us humans to waste time going through
2+ rows of the spreadsheet to tell you that the directory
corresponds to a deleted page.

So is your problem that you want to preserve non-spam deleted pages?

Can't a script go through these directories, notice that the page has
been deleted, that the delete comment contains the word 'spam' and then
delete the directory?





--
Dimi Paun
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

OK, that's a fair point. Lemme quickly go through that
and I'll report back.

Dimi.

On 01/14/2013 01:35 PM, Francois Gouget wrote:

On Mon, 14 Jan 2013, Dimi Paun wrote:


MoinMoin creates a dir for every page. I simply got the list
by listing these directories. (This is the problem -- there is a
limit of 2^15 subdirectories, and this is what we were hitting
a few days ago).

Does that answer the question?

It feels like your methodology is flawed.
Let's take the "Jaw crusher from joyal jc001j" page as an example.

As far as I can tell that page has already been deleted. MoinMoin knows
that. So you should not need us humans to waste time going through
2+ rows of the spreadsheet to tell you that the directory
corresponds to a deleted page.

So is your problem that you want to preserve non-spam deleted pages?

Can't a script go through these directories, notice that the page has
been deleted, that the delete comment contains the word 'spam' and then
delete the directory?





--
Dimi Paun
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

MoinMoin creates a dir for every page. I simply got the list
by listing these directories. (This is the problem -- there is a
limit of 2^15 subdirectories, and this is what we were hitting
a few days ago).

Does that answer the question?

Dimi.

On 01/14/2013 12:51 PM, Francois Gouget wrote:

On Mon, 14 Jan 2013, Dimi Paun wrote:
[...]

https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5

I'm not clear on how this is supposed to work.
For instance I see a ton of pages containing 'joyal' or 'crusher' in
their Page Name. For instance:

  Jaw crusher from joyal jc001j

However a quick search for 'crusher' shows '0 results out of about 21011
pages' (for both a Title and Full Text search). Either I'm searching
wrong or these pages have already been deleted. If the latter, then why
do we have to manually mark them as Spam again?





--
Dimi Paun
Lattica, Inc.





Re: Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

On 01/14/2013 11:43 AM, Erich E. Hoover wrote:

On Mon, Jan 14, 2013 at 9:38 AM, Dimi Paun  wrote:

...
Please let me know if we can do this any simpler or if there are
any problems.

Do you want us to move marked items up to the top of the spreadsheet
or will you do that for us?

I don't think we need to move marked items at the top of the
spreadsheet, that's a lot of work/churn.

What we can do instead is that we can move (from time to time)
marked items to a separate sheet if that helps (to have them out
of the way, and avoid having to scroll too much through the sheet).

Actually, all these ideas are OK with me -- feel free to suggest/do
anything that makes sense and makes it easier to sort through
all this stuff, all I really care is the data :)

--
Dimi Paun
Lattica, Inc.





Wine Wiki needs your help!

2013-01-14 Thread Dimi Paun

Folks,

As we all know, through the years spam has been an ongoing problem.
We dealt with it OK, as we valued the openness of our wiki. That's good.

However, all this churn has accumulated a lot of garbage on the system,
as orphaned pages and dummy users. These have accumulated to such
an extent that we are reaching system limits.

I need your help to clean them out. First, we have to separate the spam
from the real content. I've created a Google Spreadsheet for pages:

https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNEOUt0UkVGUko4elhkOHVoaWx2OWc#gid=5

and one for users:

https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idGdPYXJ0dlUxZGZfdURGQWdFc2picWc#gid=0

We need to mark spam as "Spam" and what's good  as "OK" in the
"Spam" column. I'll take that data and apply it to the wiki.

Please let me know if we can do this any simpler or if there are
any problems.

Thanks!

--
Dimi Paun
Lattica, Inc.





Re: Problem with editing FAQ and other pages at wiki

2013-01-11 Thread Dimi Paun

OK, please try now, lemme know if there's any problems.

Dimi.

On 01/11/2013 01:55 PM, André Hentschel wrote:

Am 10.01.2013 11:22, schrieb Romanoff Alexei:

Hello!

I've tried editing wine FAQ and several other wiki pages, but failed. When I click on 
"Preview" or "Save" buttons, I always see error message like

[Errno 31] Too many links: 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'

If you want to report a bug, please save this page and attach it to your bug 
report.

A problem occurred in a Python script. Here is the sequence of function calls 
leading up to the error, in the order they occurred.


I can confirm that.


[Errno 31] Too many links: 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'

   * args = (31, 'Too many links')
   * errno = 31
   * filename = 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'
   * strerror = 'Too many links'

I had a similar error, still 31, but a shorter backtrace. I tried to create a 
page, that's all.




--
Dimi Paun
Lattica, Inc.





Re: Problem with editing FAQ and other pages at wiki

2013-01-11 Thread Dimi Paun

OK, I'll look into in the next hour.

Dimi.

On 01/11/2013 01:55 PM, André Hentschel wrote:

Am 10.01.2013 11:22, schrieb Romanoff Alexei:

Hello!

I've tried editing wine FAQ and several other wiki pages, but failed. When I click on 
"Preview" or "Save" buttons, I always see error message like

[Errno 31] Too many links: 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'

If you want to report a bug, please save this page and attach it to your bug 
report.

A problem occurred in a Python script. Here is the sequence of function calls 
leading up to the error, in the order they occurred.


I can confirm that.


[Errno 31] Too many links: 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'

   * args = (31, 'Too many links')
   * errno = 31
   * filename = 
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'
   * strerror = 'Too many links'

I had a similar error, still 31, but a shorter backtrace. I tried to create a 
page, that's all.




--
Dimi Paun
Lattica, Inc.





Re: Wiki is down

2012-08-10 Thread Dimi Paun

Wiki back up, sorry for the glitch!

Y'all have a nice weekend :)

Dimi.

On 12-08-10 3:59 PM, Austin English wrote:

Mind taking a look? :)

Have a great weekend!




--
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-08-03 Thread Dimi Paun
On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote:
> How difficult would it be to use ReCaptcha?
> 
> http://www.google.com/recaptcha

Hm, don't know. We could hack our version to support recaptcha,
but I'm not familiar with the code base, and I don't have the
time right now. But I can take patches if someone is willing 
to do it.

-- 
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-07-30 Thread Dimi Paun
On Fri, 2010-07-30 at 08:58 +0200, Francois Gouget wrote:
> I have a theory: did the script move the remaining files to another 
> directory? 

Yes, it did.

-- 
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Thu, 2010-07-29 at 18:17 +0200, Michael Stefaniuc wrote:
> Yes, the LocalBadContent page got pretty long; I'm fairly sure it's
> the spam checking that takes so long.

I tried to empty it, and it does seem to help. However, it's not
the only cause of the problem, it's still not fast even with an
empty LocalBadContent.

-- 
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Wed, 2010-07-28 at 15:06 -0700, Dan Kegel wrote:
> > I'm looking into how we can clean this up.
> 
> Should we also add another hurdle (possibly even manual approval)
> to make it harder for spammers to get accounts?

Now that this issue is fixed, we can look again at the spam
problem. It was suggested that we use a 'TextChas' for non
logged in users:
http://moinmo.in/HelpOnSpam

But it seems it's not too easy to come up with decent questions.
Should we try it?

-- 
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Wed, 2010-07-28 at 22:35 +0100, David Gerard wrote:
> Ubuntu hit this one:
> 
> https://bugs.edge.launchpad.net/ubuntu/+source/moin/+bug/217191
> http://moinmo.in/MoinMoinBugs/AllPagesSavedToSingleDirectory

Thanks David for the links.

I've run the cleanup scripts, and we are now down to ~5K pages,
down from 32K. So there is still plenty of room to grow for the
time being. 

If we hit the limit again, please let me know and I'll clean it
up right away, now I know what I need to do :)

P.S. There is still something wrong with the Wiki, saving pages
takes a really long time with no reason whatsoever (no load on the
box, etc). I think we're hitting an inefficiency in Moin, as the
httpd process shoots up to 95% CPU usage for a few good seconds.
I've trimmed the edit-log and the event-log files, which were very
big, but that doesn't seem to help. Any other ideas?

-- 
Dimi Paun 
Lattica, Inc.





Re: wiki slightly broken still?

2010-07-28 Thread Dimi Paun
On Wed, 2010-07-28 at 13:05 -0700, Dan Kegel wrote:
> Creating new wiki pages seems broken today...

Yes, due to all the spam, we've hit the ext3 limit
of subdirectories (32k). More here:
http://www.rooftopsolutions.nl/blog/135

I'm looking into how we can clean this up.

-- 
Dimi Paun 
Lattica, Inc.





Re: Try2: Website: Remove GIMP Fun Project

2009-06-08 Thread Dimi Paun
On Mon, 2009-06-08 at 16:57 +0200, Paul Vriens wrote:
> 
> We have that same (or actually newer) page on the wiki:
> 
> http://wiki.winehq.org/Fun_Projects
> 
> Doesn't it make more sense to link this entire page to the wiki?

I think it does. But it would be great if someone can
spend a bit of time on the wiki page to colorize a bit
the entries based on their status (DONE, TODO, etc),
'cause the page as it is now is a bit hard to follow...

-- 
Dimi Paun 
Lattica, Inc.





Re: Website: Point the Development pages entirely to the Wiki.

2009-06-02 Thread Dimi Paun
On Tue, 2009-06-02 at 09:10 -0500, Jeremy Newman wrote:
> Scott Ritchie wrote:
> > Jeremy Newman wrote:
> >> I'm holding this patch hostage until the Wiki is updated with the
> new
> >> theme.
> > 
> > Aren't you the one who's updating the wiki to the theme?
> 
> No. I currently do not have access to the Wiki. That is hosted by
> elsewhere.

This is true, I'm hosting it. And while I said I'll look at upgrading
to the new theme, I just didn't have the time.

However, the code is freely available to everybody on SourceForge:
http://wine.cvs.sourceforge.net/viewvc/wine/wiki/

And I'm more than happy to accept patches.

-- 
Dimi Paun 
Lattica, Inc.





Re: Disabling File attachments on Wiki

2009-04-30 Thread Dimi Paun
On Thu, 2009-04-30 at 16:32 +0900, Dmitry Timoshkov wrote:
> Please consider disabling attachments once and for all. Thanks.

OK, I'll look at that this afternoon.

-- 
Dimi Paun 
Lattica, Inc.





Re: Romanian translation

2009-04-27 Thread Dimi Paun
On Tue, 2009-04-28 at 00:23 -0400, Michael Stefaniuc wrote:
> Salut!
> 
> Dimitriu Petru wrote:
> > Well words like Cancel or Save or Open or Close can be translated in three 
> > ways:
> > - the first is when you translate them using an imperative just like
> > you're commanding your computer to do that, like speaking to a person
> > face to face (Renunţă, Salvează, Deschide, Închide, etc which mean
> > (You) cancel, (You) save, (You) open, (You) close etc.)
> > - the second one is using a noun to define the action that will happen
> > when pressing the button or the control etc. (Renunţare, Salvare,
> > Deschidere, Închidere)
> > - the third one is using a verb that denotes that the computer is
> > proposing you to do something by pressing a button or a control etc.
> > (Renunţă/Renunţaţi, Salvează/Salvaţi, Deschide/Deschideţi,
> > Închide/Închideţi)
> > 
> > I prefer the second way because I don't like speaking to a computer
> > like you speak to your friend or younger brother and I also don't like
> > that the computer speaks to the user like a person. The computer is a
> > machine, it doesn't have a soul, people do have.
> But the first form seems to be the correct one. And that's what I used.
> See http://i18n.ro/Ghidul_traducatorului_de_software; I have seen other
> translation guides that have basically the same rules on how to "speak"
> to the computer (i have those bookmarked but I'm far away from my home
> computer).
> 
> The computer isn't a human being but that's irrelevant; there was
> nothing in the non-living world that required interaction with natural
> language. And it seems that natural language interaction in Romanian is
> better done by treating the computer like a person. The noun form really
> sounds awkward.

As a native Romanian speaker, I agree with Michael 100%. The 2nd and 3rd
forms sound awkward. But beyond our personal preferences, I think the
Romanian user is best served by a consistent translation across
systems. 

If we let our momentary preferences dictate the form for every
system that gets translated, folks will get confused, and few will
appreciate the noun vs. verb based nuances  :)

-- 
Dimi Paun 
Lattica, Inc.





Re: Disabling File attachments on Wiki

2009-03-13 Thread Dimi Paun

On Sat, 2009-03-14 at 00:59 +0800, Dmitry Timoshkov wrote:
> http://wiki.winehq.org/RecentChanges has all the details. Please
> consider at least removing the spammers' accounts listed there,

I have done that in the past, and I'll keep removing them.
A quick ping on IRC usually gets me going :)

> or give a way to do that for us poor people who regularly brushes
> spam out of the Wine wiki.

I have no problem with that if if can be done.
Can someone look it up what would it take to make
Moin do that?

-- 
Dimi Paun 
Lattica, Inc.






Re: Disabling File attachments on Wiki

2009-03-13 Thread Dimi Paun

On Sat, 2009-03-14 at 01:59 +1100, Ben Klein wrote:
> Of course, complicated captchas don't keep out manually created spam
> accounts, only bots.

And I'll like to see some data that shows that we have a
significant portion of the spammers are bots before we
even start thinking of captchas.

-- 
Dimi Paun 
Lattica, Inc.





Re: Disabling File attachments on Wiki

2009-03-11 Thread Dimi Paun

On Wed, 2009-03-11 at 08:02 -0600, Vitaliy Margolen wrote:
> Anyone? Also how about blocking this IP: 213.155.0.32 ?

Not sure how we can block that IP easily. If it has to do
with iptables, forget it.

-- 
Dimi Paun 
Lattica, Inc.





Re: Wiki challenge question on user account creation

2009-03-05 Thread Dimi Paun

On Thu, 2009-03-05 at 14:07 +0800, Dmitry Timoshkov wrote:
> Actually if there are a lot of user account creation every day in the
> Wine wiki then there is something wrong with it. There are not that
> much Wine developers and probably some active testers/appdb
> maintainers, who else could pretend to have a user account in the Wine
> wiki?

I don't think we have all that many. The wiki is up for a few years,
and we have <2700 accounts, I'd suspect most of them are valid accounts.

If spammers would create them automatically, we would have see 
a lot more I'd think.

> > Moreover it will add additional maintenance
> > burden on our part to keep the captchas operational.
> 
> Isn't that an one time effort?

Not sure -- if this is not integrated in the base version,
it will create problems every time we need to do an upgrade.
Moin is great, but they break things all the time between
versions, it's already a pain to do the upgrades...

-- 
Dimi Paun 
Lattica, Inc.





Re: Wiki challenge question on user account creation

2009-03-04 Thread Dimi Paun

On Wed, 2009-03-04 at 11:59 -0600, John Klehm wrote:
> I wouldn't really want per save captcha either, per account creation
> is what I was hoping would cut down the spam.  If the accounts are
> created manually not much we can do about it :(

I think that's the case. Which is why I think it's not worth doing,
as we would just make it harder on most real users, while not detracting
any of the spammers. Moreover it will add additional maintenance
burden on our part to keep the captchas operational.

> Maybe some kind of save moderation for new accounts? (which would
> probably be a lot of bother) :/

Yes, this would be horrible. I think it's easier on everybody
to just delete things after the fact, as it happens now.

-- 
Dimi Paun 
Lattica, Inc.





Re: Wiki challenge question on user account creation

2009-03-04 Thread Dimi Paun

On Tue, 2009-03-03 at 21:32 -0600, John Klehm wrote:
> Luckily it seems MoinMoin has a feature that provides exactly this:
> http://moinmo.in/TextCha
> 
> However on that page it only mentions a challenge question for commits
> which wasn't quite what I wanted so I took a look at the source for
> stable release 1.8.2

Yes, this can be a problem -- I'm afraid captchas  are a bit annoying,
and before we go ahead and implement them I'd like to find the opinion
of the real users of the wiki if they'd like something like this.

And if we don't implement captchas for saves (which I personally would
hate but maybe others would be OK with it), I'm not sure it would save
us all that much spam to begin with, as spammer do create accounts
manually and the captchas would not be a problem for them.

> http://hg.moinmo.in/moin/1.8/file/1f0db10c207f/MoinMoin/action/newaccount.py#l25
> 
> Seems they have the challenge question for user account creation in
> that version.
> 
> What's involved in upgrading? How can I get the current winehq wiki
> code/data?

First we would need to upgrade the Wiki. We are currently looking to
do that, so it shouldn't be a problem.

The code for the Wiki is on Wine's SourceForge CVS repository:
http://wine.cvs.sourceforge.net/viewvc/wine/wiki/

-- 
Dimi Paun 
Lattica, Inc.





Re: RFC: Proposed new web site design

2008-11-26 Thread Dimi Paun

On Wed, 2008-11-26 at 12:26 -0800, Matt Perry wrote:
> 
> The fonts don't resize correctly in IE6. Go to the view menu and
> choose Text Size -> Largest. Only the size of the bullets changes.
> This will exclude people from the site that have visual disabilities
> such as myself.

IIRC IE does not resize fonts if their size is specified in px.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun

On Thu, 2008-11-06 at 09:29 -0800, Dan Kegel wrote:
> 
> Would you settle for static alternating colors?
> I'm kind of anti hover highlight.

IIRC there was a recent study claiming that alternating 
row colors are not all that useful in practice, the on-hover
has the advantage of focusing your attention only on the 
row that you care about.

But if you have a problem with that, static colors
would be a step forward (and AFAIAC it would be fine).

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun

On Thu, 2008-11-06 at 08:32 -0800, Dan Kegel wrote:
> You should see your patch appear at
> http://kegel.com/wine/patchwatcher/results

Very nice! 

One suggestion that I have is changing the background color 
of the row on hover so you can easily match the result on the
RHS to the Subject, right now that is a bit difficult to
do visually on a wide-screen monitor.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Silencing a noisy fixme - feedback requested

2008-10-03 Thread Dimi Paun

On Fri, 2008-10-03 at 12:01 -0500, Austin English wrote:
> +if (apc_user) 
> +   if (warn) {
> +   FIXME("I/O completion on lock not implemented yet\n");
> +   warn = FALSE;
> +   }

It's a style thing, but I for one would much prefer
brackets around the outer if to prevent easy to make
mistakes with dandling ifs.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Silencing a noisy fixme - feedback requested

2008-10-03 Thread Dimi Paun

On Fri, 2008-10-03 at 11:46 -0500, Austin English wrote:
> +BOOLEAN warn = TRUE;

This has to be static, else it will always be TRUE.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Celebrating Wine 1.0

2008-06-17 Thread Dimi Paun

On Tue, 2008-06-17 at 09:55 -0500, Jeremy White wrote:
> Woohoo
> 
> Alexandre just posted the Wine 1.0 commit!  I eagerly did my git
> update and enjoyed running 'wine --version'.  Ooo.  I'm going to do it
> again...

Wow, this is the moment we've all been waiting for!

Congratulations everybody, this is way cool indeed.

And I must say, this would not have been possible
without Alexandre's amazing contribution. Kudos!

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: WIKI: Add forum link to wiki site

2008-05-17 Thread Dimi Paun

On Sat, 2008-05-17 at 10:26 +0200, Rico Schüller wrote:
> Hi,
> 
> this patch adds the Wine Forum link to the WineHQ Menu in the wiki.

Thanks!

Now I'm just on my way out to New York, I'll get back in 3 days,
I'll look at it when I get back.

[If I don't commit it in 3-4 days, please ping me again, in case
it felt through the cracks]

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Documentation is still in CVS?

2008-04-03 Thread Dimi Paun

On Thu, 2008-04-03 at 10:37 -0700, Lei Zhang wrote:
> Is there a reason why the Wine documentation is still in CVS, and not
> in GIT?

Yes. The docs are now maintained at SourceForge, and given the glacial
pace of updates, there is little reason to move them to git. Moreover,
git presents a much higher barrier to entry, and there's no reason to
raise it for (potentially non-technical) documentation contributors.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: wineboot: Add the Romanian translation.

2008-03-19 Thread Dimi Paun

On Wed, 2008-03-19 at 23:57 +0100, Michael Stefaniuc wrote:
> +LTEXT   "O îeșire sau oprire simulată este în curs dar
> acest proces nu răspunde.",

This should be "O ieșire" not "O îeșire", no?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: cygwin runs!

2008-03-18 Thread Dimi Paun
Dan Kegel wrote:
> Hey!  Cygwin actually installs and runs inside Wine!

This is way cool! Last time I've checked there were some
nasty problems, and I haven't seen the patches targeting
this problem.

So satisfying! :) 

Now, if we can get cygwin to run wine... 

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Request for comments on listview patch which was rejected.

2008-03-03 Thread Dimi Paun

On Tue, 2008-03-04 at 01:40 +0100, Peter Dons Tychsen wrote:
> It looks quite sober to me...

Looks good to me too...

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: comctl32: Fixed listview bug, when client sends bogus SETITEMSTATE request

2008-02-11 Thread Dimi Paun

On Tue, 2008-02-12 at 03:28 +0100, Peter Dons Tychsen wrote:
> Fixed listview bug, when client sends bogus SETITEMSTATE request,
> requesting all items to be focused.

Looks good, tnx!

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Wiki Down?

2008-01-30 Thread Dimi Paun

On Wed, 2008-01-30 at 13:28 -0800, Lei Zhang wrote:
> The wiki seems to be down again.

Yes, it was down for about 2h this evening because we
moved it back to the faster server. It should be back
with a vengeance now, please let me know if you notice
any problems... 

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Wiki Down?

2008-01-26 Thread Dimi Paun

On Fri, 2008-01-25 at 15:06 -0600, Austin English wrote:
> What happened to the wiki? AppDB/WineHQ/Bugzilla are all fine, but
> wiki.winehq.org seems to be down.

The wiki is up. In fact, it was always up, but there was a little
problem with the DNS yesterday (I think from 1-8PM EST) that affected
our environment. It's been fixed, sorry for the downtime.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Wiki account missing

2008-01-04 Thread Dimi Paun

On Fri, 2008-01-04 at 12:44 -0600, James Hawkins wrote:
> I'm using the same password I've always used, but it doesn't work anymore.

Well, that's odd. Can you please try to reset your password?
http://wiki.winehq.org/UserPreferences

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Wiki account missing

2008-01-04 Thread Dimi Paun

On Fri, 2008-01-04 at 12:30 -0600, James Hawkins wrote:
> My Wiki account has gone missing:
> 
> Unknown user name: "[EMAIL PROTECTED]". Please enter user name and
> password.

No, it's still there, I've double checked. Maybe you are not using
the right password?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: xdg_user_dirs patches

2007-11-30 Thread Dimi Paun

On Fri, 2007-11-30 at 18:45 +0100, Francois Gouget wrote:
> That's ok only because you don't care about the Windows desktop 
> shortcuts...

I guess the preferred solution would be to teach GNOME & KDE
about .lnk files.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: I am at the Ubuntu Developer Summit, do we need anything from other projects?

2007-10-30 Thread Dimi Paun
On Tue, 2007-10-30 at 15:54 -0700, [EMAIL PROTECTED] wrote:
> The other day an X.org developer asked me if Wine needed anything from 
> X.  Off the top of my head, all I could think to tell him was relative 
> mouse movements.
> 
> There are people from many free software projects here, including the 
> kernel and Samba.  Should I voice anything else?

http://wiki.winehq.org/FromOtherProjects

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Lots of 'make test' failures on Windows

2007-10-25 Thread Dimi Paun
On Thu, 2007-10-25 at 09:38 -0700, Juan Lang wrote:
> I suspect the biggest problem is keeping the winetest executable up to
> date on the systems.  If the test system can't compile the tests, it
> can't easily perform a regression test.  What's the biggest obstacle
> to that?

There's a lot of machinery needed on a box to rebuild wine, and
Windows boxes typically have no development tools whatsoever.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Dimi Paun
On Mon, 2007-10-15 at 11:18 -0500, Jeremy White wrote:
> Perhaps on Windows; I'm focused on Linux.  Is there
> a way to trigger that when doing a 'wine winetest.exe.so'?

Maybe "-c" (console mode, no GUI)

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Dimi Paun
On Mon, 2007-10-15 at 10:48 -0500, Jeremy White wrote:
> In my opinion, it needs the following:
> 
>   1.  A Wiki page!
> 
>   I could not find *any* documentation on this utility.
> 
>   For example, I'm still not entirely clear on how to
>   setup and/or register my build.id so that my results
>   are available on the web site.  (And the rather
>   non intuitive requirement to 'know' the unpublished
>   url http://test.winehq.org/data/  is harsh).

The plan was to have a home page at:
 http://test.winehq.org
that would contain the explanation, plus an
index for the tests (hopefully organized nicely).

That didn't happen...

>   2.  Headless operation
> 
>   From my experiments, there were a number of dialogs
>   I had to dismiss, and some worrying complaints in
>   unpacking msvcrtd and msvcrt tests.
> 
>   This second point is probably a bit less important
>   than the first.

There is a headless operation mode already, it detects
if you run it as a service, and skips appropriate tests.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Wiki looks much better

2007-10-14 Thread Dimi Paun
On Sun, 2007-10-14 at 13:21 -0700, Scott Ritchie wrote:
> If I may still whine for a bit, the FAQ page still looks a bit ugly
> due to the lack of paragraph breaks.  The "Wine/Cedega/Crossover"
> question, for instance, needs some empty lines between the paragraphs.

OK, how about now?
http://wiki.winehq.org/FAQ

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: CSS changes to the Wiki

2007-10-14 Thread Dimi Paun
On Sun, 2007-10-14 at 15:02 -0500, Mitchell Mebane wrote:
> Anyway, you've got it almost right.  It's still a bit cramped, but if
> you add a
> 
> .table-of-contents li {
> line-height: 20px;
> }
> 
> to screen.css it will look the same as the preview.

OK, it's in now, do people like it better?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Translating the Wiki

2007-10-13 Thread Dimi Paun
On Sat, 2007-10-13 at 19:02 +0200, Francois Gouget wrote:
> I have also added a FrenchDict page as described in the above help, in
> an attempt to have users who open the FAQ page sent to the 
> FoireAuxQuestions page if their locale is French. However this does
> not seem to work. Do you know what I got wrong?

I'm afraid not, I've never used the feature. I guess you can ask
the MoinMoin guys, they are usually responsive.

> Another issue I have is: after some time, how do I know which parts of
> the translation are up to date and which are not? The above page does 
> not touch on this issue.

I don't think they have anything builtin, but you can always ask.
At the very least, one can store the version of the translated page
in a comment at the top of the page, and keep track of differences
that way...

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Support GCOV for Wine 1.0?

2007-10-13 Thread Dimi Paun
On Sat, 2007-10-13 at 10:32 +0200, Francois Gouget wrote:
> 
> d) there's no way to translate it

http://moinmoin.wikiwikiweb.de/HelpOnLanguages

More is on the way I believe.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: CSS changes to the Wiki

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 16:56 -0700, Scott Ritchie wrote:
> 
> Sorry, in terms of help here I've got nothing but whining :(

I know, that's always fun... :/

Anyway, it's fixed now. Please check it out (you need to Refresh
to reload the new CSS). Let me know if there are any more problems.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: CSS changes to the Wiki

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 21:29 +0200, Kai Blin wrote:
> 
> John Klehm pointed me at a post from Mitchell Mebane (at 
> http://www.winehq.org/pipermail/wine-devel/2007-August/058622.html)
> 
> Someone care to give that a spin?

I've implemented the feature, but I don't think it helps.
Can someone test it out, and maybe suggest an alternate solution
if problem still persists?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 13:11 -0700, Dan Kegel wrote:
> Font sizes change randomly based on previous lines.  It's
> unpredictable.

True, but I'd argue that "total crap" is a bit harsh.
In any event, this has nothing to do with the Wiki.
It generates correct HTML (if anyone notices any problems,
I'd be happy to fix it, but I've seen none AFAICT).

The problem is with CSS + browsers. This is a nasty problem
that is hard to deal with, no matter where you store the
data. If people can help with the CSS problem, it would be
much appreciated.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 12:00 -0700, Scott Ritchie wrote:
> Make no mistake, what we have now is crap.  It's a shame we show it to
> users when it's so laden with display bugs.

I'm afraid I don't understand -- what is crap, and
where are the display bugs?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 10:47 -0700, Dan Kegel wrote:
> It'd be nice to have the best of both worlds,
> i.e. a wiki backed by git, and written
> in such a way that users who preferred to avoid
> online editing could use git to edit
> it locally, using an easy local preview tool,
> with strong formatting capabilities (like html)
> instead of the unhappy situation we have now,
> where formatting is an unreliable mystery.

Yes, I've been dreaming for a long time after such
a system. There is a wiki out there that uses git
as backend, I forget the name now. But they need
more maturing. As for formatting, you don't want
to be too crazy, HTML is powerful but also verbose,
a wiki needs terse syntax, and that often comes
at the expense of seldom used formatting power.
That being said, I agree that it could be done a
bit better than what we have now.

> The other good thing about our wiki is that it
> has very good uptime and performance
> (thanks Dimi).

Thank you Dan, I'm really glad to see people
use it, and they enjoy the experience. My hope
is that it will become even better going forward.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Support GCOV for Wine 1.0?

2007-10-12 Thread Dimi Paun
On Fri, 2007-10-12 at 10:01 -0700, Dan Kegel wrote:
> Yes, we should remove all web pages from the entire
> web and put them in a wiki.

I think he meant that at least a link should be
made from the Wiki :) 

This is developer's info, and I think most developers 
rather use the wiki than the other types of documentation.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Wiki: removed edit rights for unknown users

2007-10-11 Thread Dimi Paun
Folks,

We've got a lot of vandals lately on the wiki, and people
are doing quite a bit of cleanup for no good reason. So
I have removed the ability of people that are not logged
in to edit pages. In fact this has been in force for a
long time, but since we've upgraded to the new 1.5.x release 
of Moin, we reverted  to allow anybody to edit pages.

Please let me know if you encounter any problems or have
any concerns regarding this policy.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Ownerdraw listview font patch...

2007-05-30 Thread Dimi Paun

On Wed, May 30, 2007 08:47, Markus Gömmel wrote:
> Before sending this to wine.patches, I wanted to ask if anyone here can tell
> me if the above is ok or total bullshit.

Looks good to me. I wonder if we shouldn't set other things as
well, but this would require testing to figure out.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: How do I put a table of contents on one of our wiki pages?

2007-05-01 Thread Dimi Paun
On Mon, 2007-04-30 at 23:40 -0700, Scott Ritchie wrote:
> Does someone know?

Yes, use:
[[TableOfContents()]]

Take a look at GitWine for an example:
http://wiki.winehq.org/GitWine

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: FAQ moved to Wiki

2007-04-16 Thread Dimi Paun
On Mon, 2007-04-16 at 00:00 -0700, Scott Ritchie wrote:
> I brought this up on the list last month (I think), and no one
> objected so I just went ahead and did it (after being lazy for a
> month).  Anyway, we can talk about it now.  I'm gonna go ahead and
> edit the wiki page (and include the new questions) in the meantime.

Well, you maybe right. Let's see how well the new FAQ works on the
wiki, and then decide which one to keep.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: FAQ moved to Wiki

2007-04-15 Thread Dimi Paun
On Sun, 2007-04-15 at 15:52 -0700, Scott Ritchie wrote:
> I've pasted the content from the FAQ onto the wiki here:
> http://wiki.winehq.org/FAQ

I really don't think this is a good idea:
  * it's going to be less usable on the Wiki AFAIK
  * it's going to be fairly hard to edit since it is so big
  * it changes so seldom that it may as well stay on the main site
  * we'll lose the other formats (.txt and .pdf)

I think it needs more discussion before we do such a
transition. If people agree to remove it, I can remove
it from the docs/ package.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Winehq's wiki table problem

2007-04-08 Thread Dimi Paun
On Sun, 2007-04-08 at 11:06 -0600, Vitaliy Margolen wrote:
> Please whomever it is responsible for the WineHQ's wiki. 

That would be me.

> Can you provide more information so I can refile the bug:

Sure thing:

- MoinMoin Version: 1.5.7
- OS and Version: CentOS 4.4 + latest updates
- Python Version: 2.3.4
- Server Setup: apache 2.0.52, SELinux
- Server Details: nothing relevant

> Of course you are welcome to file the bug yourself since you will have
> all the information available to do so. I can not figure out how to fix
> all this nasty alignment problem on _all_ the pages with the tables.

I would really appreciate if you can do this, as I can't see how I
can look into this one right now. Thank you!

> Am I doing something wrong? Is that my browser broke? Does anyone else
> see the problem with the tables not aligned properly?

Yes, I remember seeing it last time you pointed at it. I think it's just
a MoinMoin layout bug.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: PATCH: comctl32 fix for message loops with LVS_OWNERDATA (virtual listviews)

2007-03-26 Thread Dimi Paun

On Mon, March 26, 2007 18:18, Tom Kistner wrote:
> This fixes FlashFXP 3.x, a "most wanted" application.
>
> Patch attached. See Bugzilla #5131 for details.

Can you please resubmit using 4-space indent as it
is used in the rest of that function?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Dimi Paun

On Fri, March 16, 2007 16:37, Felix Nawothnig wrote:
>> It seems to me that this is a bit of a problem:
>>
>> 3783 if (nSubItem == 0 || (cdmode & CDRF_NOTIFYITEMDRAW))
>> 3784 prepaint_setup(infoPtr, hdc, &nmlvcd);
>> 3785
>> 3786 /* in full row select, subitems, will just use main item's colors */
>> 3787 if (nSubItem && uView == LVS_REPORT && (infoPtr->dwLvExStyle & 
>> LVS_EX_FULLROWSELECT))
>> 3788 nmlvcd.clrTextBk = CLR_NONE;
>>
>> I guess the call to prepaint_setup should come _after_ the if
>> with FULLROWSELECT, no?
>
> Depends. Right now this code does nothing (and I was going to remove it
> anyway) - the only place where clrTextBk is read from is in
> prepaint_setup() - but prepaint_setup() is not called for subitems (and
> the CLR_NONE override is only done for subitems).

Well, but that's the point: now that prepaint_setup() is always called
(I agree with that change), this would do what we want if only we said
the CLR_NONE _before_ the call to prepaint_setup() where it's being
acted on.

Wouldn't that solve the problem?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Dimi Paun

On Fri, March 16, 2007 11:39, Felix Nawothnig wrote:
> This fixes a glitch (blue text background inside a red selected cell))
> in SuperGrid (http://flexo.popuserv.org/SuperGrid.exe) and appears to be
> what native does.
>
> There is no need to use OPAQUE anyway since we always draw the selection
> background seperatly.

But this ends up creating and deleting the brush for each of the cells
we draw... I'm not sure I understand why using OPAQUE here doesn't work.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Romanian Wine translation

2007-03-15 Thread Dimi Paun
On Thu, March 15, 2007 05:12, Michael Stefaniuc wrote:
> Hi,
>
> Mikołaj Zalewski wrote:
>>  I've seen you have started the Romanian translation of wine.  Could you
>> look on the page http://wiki.winehq.org/SublangNeutral and mark if
>> Romanian should use SUBLANG_NEUTRAL or sublang codes?
> I would have done that myself long ago but I do not know that. I'll use
> LANG_NEUTRAL as long as somebody more knowledgeable dosn't change it.

I'd say this is the correct thing to do. There are Moldavian, etc for
SUBLANG, but we should use the "standard" (Academy sanctioned) version,
which would qualify to NEUTRAL IMO.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Tue, March 13, 2007 00:41, James Hawkins wrote:
> The list on my site has the problem, but every list I've seen has the
> same problem.  Maybe it's browser dependent.  I use Firefox in Linux.
>
> http://wiki.winehq.org/JamesHawkins

It looks like MoinMoin is doing something strange here, this requires
some more digging. It would be good to file a bug with the MoinMoin
folks though...

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Tue, March 13, 2007 01:02, Dan Kegel wrote:
> Looks good, thanks.  (It's a *nearly* thankless task, isn't it? :-)

We're happy we can help ;) I also get really annoyed when things don't
work, and believe me, we'd like to provide 99.9% uptime, but it's
a lot harder than it looks :) We are (slowly) working towards it though 

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Tue, March 13, 2007 00:45, Vitaliy Margolen wrote:
> Also the problem with misaligned table cells still not fixed:
> http://wiki.winehq.org/KnownIssues

While the generated HTML is not perfect for the table, it should
render just find as AFACT. In fact, it does render OK in IE, but
not in Firefox.

Filing a bug with the MoinMoin folks would be good...

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Mon, March 12, 2007 23:58, James Hawkins wrote:
> While we're talking about it, there's a strange issue with bulleted
> lists that has popped up recently, though I don't know exactly when it
> started.  Some items have a larger font than other items in the list,
> which looks rather silly.  Any ideas on that one?

Yeah, I _think_ I've seen it, but a concrete example would help.
However, AFAICT MoinMoin uses a fairly clean CSS/HTML separation,
so we might just notice some browser problems.

Nonetheless, if you do find an example of it, I'd be glad to look into it.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Mon, March 12, 2007 22:06, Dimi Paun wrote:
> We had a problem on the server last night, and we had
> to restore from backup. I'm still working on restoring
> the Wine Wiki, hopefully I'll be able to restore it all.

OK,

Things should be back to where they were. Please take a look
and let me know if you see any problems.

Once again, sorry for any inconvenience this has caused.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)

2007-03-12 Thread Dimi Paun

On Mon, March 12, 2007 21:13, Dan Kegel wrote:
> This, and all my other recent wiki changes, seem to
> have vanished in a puff of greasy black smoke.
> What's up?

We had a problem on the server last night, and we had
to restore from backup. I'm still working on restoring
the Wine Wiki, hopefully I'll be able to restore it all.

> This isn't doing much for my trust in wikis...

The wiki is fine, it was a problem in a completly different
area. We do try to provide a high level of availability,
but you ran into a few freakish problems. We are working
hard to fix them, sorry for the incovenience.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: comctl32: Implement LVS_EX_DOUBLEBUFFER

2007-03-06 Thread Dimi Paun

On Tue, March 6, 2007 16:27, Felix Nawothnig wrote:
> Tested with utorrent - completly removes the flickering from #7344.
> In case you're wondering about the change in EraseBkgnd() - this is how
> native behaves, they recreate the double buffer on each refresh so we
> need to move the erase. Please tell me if I broke anything.

It looks good, but you don't cleanup the new DC if the bitmap creation fails.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






ANN: Wiki upgrade

2007-02-15 Thread Dimi Paun
Folks,

We finished upgrading the wiki to MoinMoin 1.5.7.
Please let me know if you encounter any problems.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: comctl32 kibitzers wanted

2007-02-05 Thread Dimi Paun

On Mon, February 5, 2007 03:16, Dan Kegel wrote:
> I and Lei Zhang, with some help from James Hawkins,
> are leading a group of 13 UCLA students who are
> writing conformance tests for comctl32.

Brilliant!

> Each student picked one control, and is now busily writing
> getter/setter tests.  In the coming few weeks we'll
> also try more interesting tests, like verifying that
> the right messages are sent in the right order.
> If you're interested in helping the students in any way
> (reviewing code before it hits wine-patches, offering
> suggestions on how to test tricky bits, or whatever),
> please let me know and I can add you to the project's
> mailing list.

Sure, please add me to the list. I've had my share of work
in that area (comboex, listview, progressbar, updown, etc.)
and I might be able to help.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






[ANN] Wine wiki

2007-01-10 Thread Dimi Paun
Folks,

As promised, the server that the wiki is on has been upgraded to a much
better and faster box. Everything should work just fine, only faster :)

Please let me know if you notice any problems or glitches.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: tools/. mono.php

2006-12-04 Thread Dimi Paun

On Mon, December 4, 2006 10:20 am, Jeremy Newman wrote:
> I don't maintain the Wine SF.net uploads section. I can't remember if I
> even have privileges to upload anymore. Who is in charge of that these
> days?

You should have (if you ever had), I didn't remove them.
I can grant upload privileges if need be.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: [winetest] Make sure we can send larger files

2006-11-30 Thread Dimi Paun

On Thu, November 30, 2006 1:01 pm, Paul Vriens wrote:
> I'm hitting the 1MB limit already with my win98 tests. Most other tests
> are about to reach that threshold as well.

I'd make it 2MB, what's 1MB these days... :)

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: shlwapi: Cast-qual warnings fix (2 of 4)

2006-11-16 Thread Dimi Paun

On Thu, November 16, 2006 12:42 pm, Andrew Talbot wrote:
> As I understand it, declaring them static means that the storage will be
> assigned and initialised at compile time, rather than run time, since the
> size and contents are already known.

Correct. However, if they aren't constant, it means that they may
get modified, which is an obvious problem. Making them non-static
would indeed initialize them at runtime (small cost), but they would
be guaranteed to have the value that we expect always.

I haven't looked at the code, maybe you can prove they are indeed
constant, but that's ugly. I'd take the trivial runtime hit, for
the sake of cleanliness.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wine-wiki broken by design

2006-11-16 Thread Dimi Paun

On Thu, November 16, 2006 6:52 am, Dan Kegel wrote:
> One of these days, we probably want the wiki, appdb, and bugzilla to
> all output a sitemap so they can be searched better,
> I think.  'Course, someone will have to do it in their
> copious free time, so who knows when it'll happen...

OK, sounds good, I'll add them to the TODO.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: shlwapi: Cast-qual warnings fix (2 of 4)

2006-11-15 Thread Dimi Paun

On Wed, November 15, 2006 5:02 pm, Andrew Talbot wrote:
> -  static const WCHAR szProperty[] = {
> +  static WCHAR szProperty[] = { '{','D','0','F','C','A','4','2','0',

If they aren't constant, shouldn't they be non-static too?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: [FYI] Wiki down (Back up!)

2006-11-09 Thread Dimi Paun
On Thu, 2006-11-09 at 10:18 -0500, Dimi Paun wrote:
> We are hoping to have it back up by the end of the day. 

The wiki is back up! We are very sorry for the downtime,
and all the associated inconvenience this has caused.

We will try to beef up the infrastructure to avoid such 
problems in the future.

Please let me know if you notice anything off on the site.

Happy hacking!

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





[FYI] Wiki down

2006-11-09 Thread Dimi Paun
Folks,

We are experiencing some hardware problems on wiki.winehq.org.

I have taken the wiki down until we work through the issues
to protect the data. We are working to fix it, and to provide
better failover in the future. We are hoping to have it back
up by the end of the day.

I am sorry about the downtime, and I apologize for any
inconvenience caused by it.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: uploading files to the wikie

2006-10-30 Thread Dimi Paun

On Mon, October 30, 2006 2:25 pm, James Hawkins wrote:
> Do we have the ability to upload files to our Wiki?

Yes, you do. Avoid uploading GBs of data though :)

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Governance Ideas

2006-09-28 Thread Dimi Paun

On Thu, September 28, 2006 9:24 am, Chris Morgan wrote:
> I'm of the opinion that code is "art" as its implementation is
> subjective. The idea that you could document when a patch is
> acceptable or not seems like an impossibility.

I wholeheartedly subscribe to this. We are far away (as a profession)
to document what is a good/bad patch even when that is fairly obvious
to a good maintainer, let alone document exactly the thought process
for more complicated cases.

This is a waste of time. Alexandre is an amazing judge of patches,
we should be happy we have him. More to the point, I think this is
missing the point. If we are good at something, it is in evaluating
patches on their techincal merit. This doesn't need improvement.

What we may be erring a bit is putting the techincal aspects above
and beyond other considerations, such as desire for a feature at the
expense of a little quality. We are delaying patch inclusion waiting
for the 'right' solution, which in part is good, but when that means
keeping desired features away for years on end, i think it hurts us
more than it helps us being relevant to our users.

Maybe there's a way to help Alexandre better understand how much
people want something, maybe that can be factored in a bit?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






Re: Wine translations statistics

2006-09-25 Thread Dimi Paun
On Mon, 2006-09-25 at 13:29 +0200, Mikołaj Zalewski wrote:
> To check what needs to be translated I have played a bit with wrc 
> --verify-translation and made some HTML from it's results. As this
> might interest other translators I've put the statistics at 
> http://pf128.krakow.sdi.tpnet.pl/wine-transl/ .

Very nice! It would be cool if we could integrate this on winehq.org.
Care to try that?

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Governance revisited

2006-09-25 Thread Dimi Paun
On Mon, 2006-09-25 at 19:47 +0900, Dmitry Timoshkov wrote:
> Dimi, I thought you were aware of it, and Alexandre at least at
> previous WineConf stated that he accepts dubious code in cases, when
> he sees that nobody works on some component: that components were
> OLE/COM, DDraw/D3D, BiDi at some point.

Yes, you are correct. I was trying to make a point, and I couldn't
let reality mess with that :)

In fact, I must say that the most fun I had with Wine was when Alexandre
let me run with listview a few year back. He clearly committed patches
that weren't perfect, but I appreciated that because that's how I work:
I like to do several iterations, maybe redo the code several times, but
commit the intermediate steps.

If I would have had to refine each patch more, I would have given up
working on it, since it wouldn't have been nearly as fun for me.

Truth of the matter is that in the meantime listview broke, and there
was a dip in quality. However, by the time I was done, I think Wine
was in better shape than when I started. For me, that worked.

Unfortunately, that doesn't say much. Whom, when, and where you let
people play is a black art, and there can not be clear policy about
it. In fact, clear policy in these matters would defeat the purpose,
as it would take that 'play' aspect out of it.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: Governance revisited

2006-09-24 Thread Dimi Paun
On Sun, 2006-09-24 at 12:36 +0900, Dmitry Timoshkov wrote:
> Everyone who complaints about "problems" with patch acceptance policy
> seem to claim that, but my impression is that complaints are going
> from technically incompetent people, who just "feels" that the process
> can be improved, but can't explain it in developer's language (i.e. in
> technical words) how.

One thing to be careful about is the ever growing trend of forming
a very tightly coupled in-group. It is very easy to happen: most
top developers work for the same company, they are extremely competent,
and have the technical argument on their side. It is way too easy to
feel righteous.

This is a big problem, as it elevates the (already high) barrier to
entry to a dangerous altitude. And the feedback is positive, as people
are being put off, the in-group grows tighter, etc.

The net is littered with amazingly smart and competent teams that
killed projects via this process: *BSD, XFree86, etc. The human
aspect of engineering a lively community is still a black art,
so we have to tread carefully.

Now, for the problem at hand: I think people's intuition that something
is off has a seed of truth. And I find it difficult to say that because
I think Alexandre does an amazing job. He is probably by far the person
that had the largest (positive) influence on me from a professional
perspective. 

To my mind, Alexandre is the Roger Federer and Michael Schumacher of
software development. He is never wrong.

And paradoxically, I think this is part of the problem. He is just too
good for mere mortals. And I think a lot of folks get discouraged
because it is just too much work to reach Alexandre's standards. This is
even more difficult when you have to guess Alexandre's ideas about how
you should properly solve the problem :)

IOW, I think we're missing on an important human aspect of development:
the need to compete, and show that you can do it better than the other
guy. I always found it interesting on LKML, how Linus lets in sometimes
dubious code, and that results in an effervescence of work!

It's like bad stuff motivates people to show that things can be done
better. I think Tom Tromey is onto something:
http://tromey.com/blog/?p=252

So, what is the solution? Let in crappy code? Certainly not. And in all
honesty, how can we ask Alexandre to let in stuff that he know sucks? I
can appreciate how silly and difficult that would be.

Bottom line, I don't know. At most I can say that sometimes I wish
Alexandre would be a bit more impulsive, and just let (a selected few)
things in that people want. Maybe this way we generate more excitement,
and the tiny bit of quality drop we pay with would be worth it. 

YMMV :)

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.





Re: cabinet: Add breaks to switch statements

2006-09-13 Thread Dimi Paun

On Wed, September 13, 2006 1:18 pm, Dan Kegel wrote:
> Offhand that looks like a more serious change than you thought.
> You'd better either really understand the code, or
> add a conformance test that shows this fixes a bug, IMHO.

Agreed. But that is confusing code, it should have a /* fallthrough */
comment instead of the break statement if that was the intent.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.






  1   2   3   4   >