Re: [3/5] d3dx9: Introduce a function for copying pixels.

2012-10-29 Thread Matteo Bruni 
2012/10/29 Christian Costa :
>
>>
>>  pixel_format = get_format_info(src_desc.Format);
>> -if (pixel_format->type != FORMAT_ARGB)
>> -{
>> -FIXME("Unsupported pixel format %#x\n", src_desc.Format);
>> -return E_NOTIMPL;
>> -}
>> +if (pixel_format->type == FORMAT_UNKNOWN) return E_NOTIMPL;
>>
>>
>
>  Doesn't this still require a FIXME or at least a WARN?
>

There is still a FIXME in get_format_info(), that's enough I guess.

Re: [3/5] d3dx9: Introduce a function for copying pixels.

2012-10-29 Thread Christian Costa 
>
>  pixel_format = get_format_info(src_desc.Format);
> -if (pixel_format->type != FORMAT_ARGB)
> -{
> -FIXME("Unsupported pixel format %#x\n", src_desc.Format);
> -return E_NOTIMPL;
> -}
> +if (pixel_format->type == FORMAT_UNKNOWN) return E_NOTIMPL;
>
>

 Doesn't this still require a FIXME or at least a WARN?