Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Vincent Povirk
> Well, GdipWidenPath is actually good enough for the things I've tested
> so far, so it's basically working. What are the possible problems with
> it you are aware of?

It doesn't implement dashed lines and most line cap styles. I think it
also mishandles pen->width == 0.

It doesn't have to be perfect, but it should at least have the
features we implement now.




Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Dmitry Timoshkov
Vincent Povirk  wrote:

> > Please don't apply this [14/14] patch, it causes a test failure. I'm sending
> > it to show how this is going to look like eventually.
> 
> Yeah, GdipWidenPath isn't good enough for this yet. But I agree this
> is the way to go, and the rest of the series looks good.

Well, GdipWidenPath is actually good enough for the things I've tested
so far, so it's basically working. What are the possible problems with
it you are aware of?

-- 
Dmitry.




Re: [14/14] gdiplus: Reimplement GdipDrawPath.

2013-02-19 Thread Vincent Povirk
> Please don't apply this [14/14] patch, it causes a test failure. I'm sending
> it to show how this is going to look like eventually.

Yeah, GdipWidenPath isn't good enough for this yet. But I agree this
is the way to go, and the rest of the series looks good.