Re: Resend: Add d3drmdef.h header file - try 3
On Mon, 19 Mar 2007, Vijay Kiran Kamuju wrote: [...] > Add minimalistic d3drmdef.h [...] Something I just noticed: +#include "d3dtypes.h" This should be: #include If I remember correctly it's important in the public headers for compiling Winelib in some circumstances. (I'm not saying this is why it's been dropped before) -- Francois Gouget <[EMAIL PROTECTED]> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
Re: Resend: Add d3drmdef.h header file - try 3
On 20/03/07, Dan Kegel <[EMAIL PROTECTED]> wrote: Vijay wrote: > We have made the tests and implementation. > We are waiting for this to get into the tree. > Just ironing out minor issues with our implementation. > Once this gets in it would be easy to send in the > implementation and tests. You need to submit them all together, I think. - Dan The logical way to split this up would be by function rather than header/implementation/tests.
Re: Resend: Add d3drmdef.h header file - try 3
Vijay wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. You need to submit them all together, I think. - Dan
Re: Resend: Add d3drmdef.h header file - try 3
"Carl-Daniel Hailfinger" <[EMAIL PROTECTED]> wrote: On 20.03.2007 09:37, Dmitry Timoshkov wrote: "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: I know its very tough to get patches done by newbies to get in, esp wine. It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for the comments and fix your work accordingly. Sorry, "listen for the comments" is not entirely correct. Often there are no comments at all and the patches simply don't get applied. That's not the case here. If soemone is a newbie and really wants to get his/her patches accepted, mail patches repeatedly once every day until the patches get applied or someone comments. It's hard to find a worse suggestion for a person sending patches. As there was explained numerous times it's a very bad idea to flood wine-patches by sending the same patch over and over, it makes a chance of accepting the patch even less possible. At the same time, ask on IRC why the patches didn't get applied. http://www.winehq.org/site/sending_patches -- Dmitry.
Re: Resend: Add d3drmdef.h header file - try 3
On 20.03.2007 09:37, Dmitry Timoshkov wrote: > "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > >> I know its very tough to get patches done by newbies to get in, esp wine. > > It's absolutely not hard to get patches accepted, be it Wine or any other > project. But it's absolutely required to listen for the comments and fix > your work accordingly. Sorry, "listen for the comments" is not entirely correct. Often there are no comments at all and the patches simply don't get applied. If soemone is a newbie and really wants to get his/her patches accepted, mail patches repeatedly once every day until the patches get applied or someone comments. At the same time, ask on IRC why the patches didn't get applied. Regards, Carl-Daniel
Re: Resend: Add d3drmdef.h header file - try 3
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont wanna let him down. I know its very tough to get patches done by newbies to get in, esp wine. It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for the comments and fix your work accordingly. I'm sorry, but to me it looks like you either don't understand what people are telling you, or you can't read. -- Dmitry.
Re: Resend: Add d3drmdef.h header file - try 3
Hi, Can somebody more experienced than me, please look into this? Modify and Submit to the wine-patches, please anyone who is working on wined3d. I and David Adam put a lotta effort making implementation and tests for d3drm. So that we can make older games that use vector manipulations work, there are bugs in bugzilla that need this functionality. I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont wanna let him down. I know its very tough to get patches done by newbies to get in, esp wine. Please someone from wined3d please help us. Thanks, VJ On 3/20/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > We have made the tests and implementation. > We are waiting for this to get into the tree. > Just ironing out minor issues with our implementation. > Once this gets in it would be easy to send in the implementation and tests. How this could get in if you didn't bother to fix all the problems pointed out? -- Dmitry.
Re: Resend: Add d3drmdef.h header file - try 3
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. How this could get in if you didn't bother to fix all the problems pointed out? -- Dmitry.
Re: Resend: Add d3drmdef.h header file - try 3
Hi, We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. Thanks, VJ PS: - If implementation and tests are needed, will be sending on thursday as I am on vacation/leave. On 3/20/07, Dan Kegel <[EMAIL PROTECTED]> wrote: Vijay wrote: >Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan
re: Resend: Add d3drmdef.h header file - try 3
Vijay wrote: Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan
