Re: Route WGL font code through gdi32.dll

2006-09-28 Thread Roderick Colenbrander 
The spec file line read '+@  stdcall wglUseFontOutlinesW(long long long long 
long long long ptr) gdi32.wglUseFontOutlinesW' the last part wasn't needed I 
think. I thought it was about that. Didn't see the FontBitmaps/FontOutlines 
issue ..

I guess I'll need a take 4 and hope it is right then.

Thanks,

Roderick


> On Thu, Sep 28, 2006 at 08:20:51PM +0200, Roderick Colenbrander wrote:
> > Again as mentioned by Huw, the gdi32.spec file wasn't correct.
> > It should be correct this time.
> 
> No.  Your gdi32.spec was fine.  It was the opengl32.spec that was
> wrong (hint: that's why I quoted that bit of the patch ;-).
> 
> Your patch is for the wglUseFont*Bitmaps* functions and not the
> wglUseFont*Outlines* functions, so the only thing that should be
> changing is the former and not the latter.
> 
> So in opengl32.spec you need to forward the wglUseFont*Bitmaps*
> functions to functions of the same name in gdi32.
> 
> Huw.

-- 
GMX DSL-Flatrate 0,- Euro* - Überall, wo DSL verfügbar ist!
NEU: Jetzt bis zu 16.000 kBit/s! http://www.gmx.net/de/go/dsl

Re: Route WGL font code through gdi32.dll

2006-09-28 Thread Huw Davies 
On Thu, Sep 28, 2006 at 08:20:51PM +0200, Roderick Colenbrander wrote:
> Again as mentioned by Huw, the gdi32.spec file wasn't correct.
> It should be correct this time.

No.  Your gdi32.spec was fine.  It was the opengl32.spec that was
wrong (hint: that's why I quoted that bit of the patch ;-).

Your patch is for the wglUseFont*Bitmaps* functions and not the
wglUseFont*Outlines* functions, so the only thing that should be
changing is the former and not the latter.

So in opengl32.spec you need to forward the wglUseFont*Bitmaps*
functions to functions of the same name in gdi32.

Huw.

Re: Route WGL font code through gdi32.dll

2006-09-28 Thread Huw Davies 
On Thu, Sep 28, 2006 at 08:01:00AM +0200, Roderick Colenbrander wrote:
> As mentioned by Huw, I forgot to attach the gdi32.spec changes :(
> This is (hopefully) a full patch.
> 
> --- dlls/opengl32/opengl32.spec   2006-09-25 23:15:35.0 +0200
> +++ dlls/opengl32/opengl32.spec   2006-09-27 23:09:11.0 +0200
> @@ -396,5 +396,5 @@
>  @  stdcall wglSwapLayerBuffers(long long)
>  @  stdcall wglUseFontBitmapsA(long long long long)
>  @  stdcall wglUseFontBitmapsW(long long long long)
> -@  stdcall wglUseFontOutlinesA(long long long long long long long ptr)
> -@  stdcall wglUseFontOutlinesW(long long long long long long long ptr)
> +@  stdcall wglUseFontOutlinesA(long long long long long long long ptr) 
> gdi32.wglUseFontOutlinesA
> +@  stdcall wglUseFontOutlinesW(long long long long long long long ptr) 
> gdi32.wglUseFontOutlinesW

You're still forwarding the wrong set of UseFont functions here.  Your
patch moved wglUseFontBitmaps to gdi32, so you should forward those
not wglUseFontOutlines.

Huw.
-- 
Huw Davies
[EMAIL PROTECTED]

Re: Route WGL font code through gdi32.dll

2006-09-27 Thread Huw Davies 
On Wed, Sep 27, 2006 at 11:34:35PM +0200, Roderick Colenbrander wrote:
> Hi,
> 
> This patch routes the WGL font code through gdi32.dll. The patch depends on 
> the other routing patch which routed the WGL context code through gdi32.dll.
> 

--- dlls/opengl32/opengl32.spec 2006-09-25 23:15:35.0 +0200
+++ dlls/opengl32/opengl32.spec 2006-09-27 23:09:11.0 +0200
@@ -396,5 +396,5 @@
 @  stdcall wglSwapLayerBuffers(long long)
 @  stdcall wglUseFontBitmapsA(long long long long)
 @  stdcall wglUseFontBitmapsW(long long long long)
-@  stdcall wglUseFontOutlinesA(long long long long long long long ptr)
-@  stdcall wglUseFontOutlinesW(long long long long long long long ptr)
+@  stdcall wglUseFontOutlinesA(long long long long long long long ptr) 
gdi32.wglUseFontOutlinesA
+@  stdcall wglUseFontOutlinesW(long long long long long long long ptr) 
gdi32.wglUseFontOutlinesW

You want to forward the wglUseFontBitmaps functions here since that's
what the rest of your patch touches ;-)

You also forgot to include the changes to gdi32.spec.

Huw.