Re: setupapi: Make sure machine name is non-empty before failing (try 2)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11589

Your paranoid android.


=== WNT4WSSP6 (32 bit devinst) ===
No test summary line found

Re: setupapi: Make sure machine name is non-empty before failing

[Juan Lang]

> What's wrong with 'if (MachineName && *MachineName)' ?

Nothing, it's my brain that's lacking.  Thanks.
--Juan

Re: setupapi: Make sure machine name is non-empty before failing

[Dmitry Timoshkov]

Juan Lang  wrote:

> +static const WCHAR emptyW[] = { 0 };
...
> -if (MachineName != NULL)
> +if (MachineName != NULL && strcmpW(MachineName, emptyW))

What's wrong with 'if (MachineName && *MachineName)' ?

-- 
Dmitry.