[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-04-17 Thread Simon Pichugin
The LDAP+StartTLS was changed back to StartTLS by Mark suggestions and I support his commentary. https://pagure.io/389-ds-base/pull-request/49613#comment-50699 Please, check once again if everything is okay. Thanks! Simon On Thu, Apr 12, 2018 at 11:38:51AM +0200, Simon Pichugin wrote: > On Wed,

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-04-12 Thread Simon Pichugin
On Wed, Mar 21, 2018 at 11:05:06PM +0100, Simon Pichugin wrote: > Hi team, > as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS to > LDAP+StartTLS. > Also, I've changed existed TLS test suite so it covers the change. I changed the name for DNA_PROT_ as William proposed. Al

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-03-21 Thread Simon Pichugin
Hi team, as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS to LDAP+StartTLS. Also, I've changed existed TLS test suite so it covers the change. On Tue, Mar 20, 2018 at 12:45:52AM +0100, Simon Pichugin wrote: > Hi team, > please, review: > > https://pagure.io/389-ds-base/