[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-21 Thread Ludwig Krispenz
On 06/20/2016 05:55 PM, Noriko Hosoi wrote: On 06/20/2016 02:20 AM, Ludwig Krispenz wrote: I have a question about your tombstone entry... You are using entrydn instead of entryrdn? no, sorry for the confusion, I was using ldapsearch to get teh tombstones, not dbscan Hmmm, if that's the case,

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-20 Thread Noriko Hosoi
On 06/20/2016 02:20 AM, Ludwig Krispenz wrote: I have a question about your tombstone entry... You are using entrydn instead of entryrdn? no, sorry for the confusion, I was using ldapsearch to get teh tombstones, not dbscan Hmmm, if that's the case, I need to learn why you don't have the paren

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-20 Thread Ludwig Krispenz
On 06/17/2016 09:16 PM, Noriko Hosoi wrote: On 06/17/2016 08:49 AM, Ludwig Krispenz wrote: On 06/17/2016 05:31 PM, Noriko Hosoi wrote: On 06/17/2016 12:17 AM, Ludwig Krispenz wrote: Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index,

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Noriko Hosoi
On 06/17/2016 08:49 AM, Ludwig Krispenz wrote: On 06/17/2016 05:31 PM, Noriko Hosoi wrote: On 06/17/2016 12:17 AM, Ludwig Krispenz wrote: Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index, but when creating a tombstone, the entry is

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Ludwig Krispenz
On 06/17/2016 05:31 PM, Noriko Hosoi wrote: On 06/17/2016 12:17 AM, Ludwig Krispenz wrote: Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index, but when creating a tombstone, the entry is removed from the parentid index. So you will mis

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Noriko Hosoi
On 06/17/2016 06:01 AM, Ludwig Krispenz wrote: On 06/17/2016 02:36 PM, Martin Babinsky wrote: On 06/17/2016 08:42 AM, Martin Babinsky wrote: On 06/17/2016 03:05 AM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Noriko Hosoi
On 06/17/2016 12:17 AM, Ludwig Krispenz wrote: Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index, but when creating a tombstone, the entry is removed from the parentid index. So you will miss the tombstones in the total init. Well, I

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Ludwig Krispenz
On 06/17/2016 02:36 PM, Martin Babinsky wrote: On 06/17/2016 08:42 AM, Martin Babinsky wrote: On 06/17/2016 03:05 AM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.3.

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Martin Babinsky
On 06/17/2016 08:42 AM, Martin Babinsky wrote: On 06/17/2016 03:05 AM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.3.patch git patch file (master) -- additional fix

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-17 Thread Ludwig Krispenz
Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index, but when creating a tombstone, the entry is removed from the parentid index. So you will miss the tombstones in the total init. Ludwig On 06/17/2016 03:05 AM, Noriko Hosoi wrote: ht

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

2016-06-16 Thread Martin Babinsky
On 06/17/2016 03:05 AM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.3.patch git patch file (master) -- additional fix to the server patch https://fedorahosted.org/389