[MediaWiki-commits] [Gerrit] operations/puppet[production]: xenon: pass --mindwidth to flamegraph.pl

2017-11-13 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/390645 ) Change subject: xenon: pass --mindwidth to flamegraph.pl .. xenon: pass --mindwidth to flamegraph.pl The flame graphs are

[MediaWiki-commits] [Gerrit] operations/puppet[production]: xenon: pass --mindwidth to flamegraph.pl

2017-11-11 Thread Ori.livneh (Code Review)
Hello Aaron Schulz, Krinkle, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/390645 to review the following change. Change subject: xenon: pass --mindwidth to flamegraph.pl .. xenon: pass

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: xenon: encode the request method as a virtual stack frame

2017-11-08 Thread Ori.livneh (Code Review)
Hello Aaron Schulz, Krinkle, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/390073 to review the following change. Change subject: xenon: encode the request method as a virtual stack frame

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update my (ori) keys

2017-10-30 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387301 ) Change subject: Update my (ori) keys .. Update my (ori) keys One of my YKs got damaged, and the other is unrecoverable due to my having

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set $wgAutoloadAttemptLowercase to false

2017-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386384 ) Change subject: Set $wgAutoloadAttemptLowercase to false .. Set $wgAutoloadAttemptLowercase to false No autoloader.log entries since

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: labs: Set $wgAutoloadAttemptLowercase to false

2017-10-23 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385978 ) Change subject: labs: Set $wgAutoloadAttemptLowercase to false .. labs: Set $wgAutoloadAttemptLowercase to false In preparation for

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: Add $wgAutoloadAttemptLowercase = false to dev settings

2017-10-20 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385405 ) Change subject: Add $wgAutoloadAttemptLowercase = false to dev settings .. Add $wgAutoloadAttemptLowercase = false to dev settings

[MediaWiki-commits] [Gerrit] mediawiki...OATHAuth[wmf/1.31.0-wmf.4]: Fix class name letter-case

2017-10-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385311 ) Change subject: Fix class name letter-case .. Fix class name letter-case Change-Id: Ifbbe537e8cac8b022793e4398c30dfdd148b4bfe --- M

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.4]: Fix class name letter-case

2017-10-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385310 ) Change subject: Fix class name letter-case .. Fix class name letter-case Change-Id: I1bccc8a72e0fe33939c7db4a60a80bc12b8fb6ff --- M

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix class name letter-case

2017-10-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385276 ) Change subject: Fix class name letter-case .. Fix class name letter-case Change-Id: I1bccc8a72e0fe33939c7db4a60a80bc12b8fb6ff --- M

[MediaWiki-commits] [Gerrit] mediawiki...OATHAuth[master]: Fix class name letter-case

2017-10-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385274 ) Change subject: Fix class name letter-case .. Fix class name letter-case Change-Id: Ifbbe537e8cac8b022793e4398c30dfdd148b4bfe --- M

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Set $wgAutoloadAttemptLowercase to false

2017-10-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384654 ) Change subject: Set $wgAutoloadAttemptLowercase to false .. Set $wgAutoloadAttemptLowercase to false As a prelude to Wikimedia turning

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Fix letter-case of class name

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384310 ) Change subject: Fix letter-case of class name .. Fix letter-case of class name Bug: T166759 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Fix letter-case of class name

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384309 ) Change subject: Fix letter-case of class name .. Fix letter-case of class name Bug: T166759 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Fix class name letter-case

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384308 ) Change subject: Fix class name letter-case .. Fix class name letter-case Bug: T166759 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix letter-case of XML

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384303 ) Change subject: Fix letter-case of XML .. Fix letter-case of XML Bug: T166759 Change-Id: Ief6834016add694d2ce11974b5ae21562fd9bd33 ---

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix letter-case of several namespace and class names

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384301 ) Change subject: Fix letter-case of several namespace and class names .. Fix letter-case of several namespace and class names

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add lowercase variants to the autoloader for legacy history ...

2017-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384288 ) Change subject: Add lowercase variants to the autoloader for legacy history blob classes .. Add lowercase variants to the autoloader

[MediaWiki-commits] [Gerrit] performance/docroot[master]: Minor language tweak

2017-06-05 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357329 ) Change subject: Minor language tweak .. Minor language tweak Change-Id: If5f584c7c976492e8ab94c9d5ee690d3cea59c74 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Capture messages on 'autoloader' debug log channel

2017-06-02 Thread Ori.livneh (Code Review)
Hello Aaron Schulz, Krinkle, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/356841 to review the following change. Change subject: Capture messages on 'autoloader' debug log channel ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add X-Wikimedia-Debug config

2016-11-21 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/322708 Change subject: Add X-Wikimedia-Debug config .. Add X-Wikimedia-Debug config Add ./debug.json, which holds configuration data for the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Changes to coal-web.py should refresh the coal webapp

2016-11-21 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Changes to coal-web.py should refresh the coal webapp .. Changes to coal-web.py should refresh the coal webapp Bug: T131820 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: Revert "Remove obsolete hiphop code"

2016-11-18 Thread Ori.livneh (Code Review)
Hello Krinkle, MaxSem, Mkoch, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/322295 to review the following change. Change subject: Revert "Remove obsolete hiphop code" .. Revert "Remove

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Don't use AbuseFilterCachingParser on bgwiki"

2016-11-18 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/322289 Change subject: Revert "Don't use AbuseFilterCachingParser on bgwiki" .. Revert "Don't use AbuseFilterCachingParser on bgwiki" This

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.29.0-wmf.2]: Don't report stats when page visibility changes during page ...

2016-11-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/322095 Change subject: Don't report stats when page visibility changes during page load .. Don't report stats when page visibility changes during

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.29.0-wmf.3]: Don't report stats when page visibility changes during page ...

2016-11-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/322096 Change subject: Don't report stats when page visibility changes during page load .. Don't report stats when page visibility changes during

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Don't use AbuseFilterCachingParser on bgwiki

2016-11-16 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/321890 Change subject: Don't use AbuseFilterCachingParser on bgwiki .. Don't use AbuseFilterCachingParser on bgwiki Bug: T148660 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Re-enable AbuseFilterCachingParser everywhere

2016-11-15 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/321728 Change subject: Re-enable AbuseFilterCachingParser everywhere .. Re-enable AbuseFilterCachingParser everywhere With T148673 fixed, I

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Use systemd's process watchdog to trigger restarts

2016-11-14 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Use systemd's process watchdog to trigger restarts .. Use systemd's process watchdog to trigger restarts I3ad8bb49ce was supposed to take care of the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: statsv: use systemd's process watchdog

2016-11-13 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/321231 Change subject: statsv: use systemd's process watchdog .. statsv: use systemd's process watchdog This is the companion change to

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Use systemd's process watchdog to trigger restarts

2016-11-13 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/321230 Change subject: Use systemd's process watchdog to trigger restarts .. Use systemd's process watchdog to trigger restarts I3ad8bb49ce was

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add an Icinga check for Graphite metric freshness

2016-11-06 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Add an Icinga check for Graphite metric freshness .. Add an Icinga check for Graphite metric freshness Checks a Graphite metric and generates WARNING or

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix-up for Ia07b03f12b

2016-11-04 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Fix-up for Ia07b03f12b .. Fix-up for Ia07b03f12b Get the right field name. Change-Id: Ib2329d08579ca938584035f290a17bacdcd893d8 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix-up for Ia07b03f12b

2016-11-04 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/319916 Change subject: Fix-up for Ia07b03f12b .. Fix-up for Ia07b03f12b Get the right field name. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Report save timing by MediaWiki version

2016-11-04 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Report save timing by MediaWiki version .. Report save timing by MediaWiki version Add a 'mw.performance.save_by_version' key namespace which includes a

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[master]: Don't report stats when page visibility changes during page ...

2016-11-04 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/319902 Change subject: Don't report stats when page visibility changes during page load .. Don't report stats when page visibility changes during

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Module storage: count modules which fail to execute, too

2016-11-02 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/319389 Change subject: Module storage: count modules which fail to execute, too .. Module storage: count modules which fail to execute, too

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix-up for Iff996299

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Fix-up for Iff996299 .. Fix-up for Iff996299 Change-Id: I4c6e3859917c7b34d76c23eb0628402a188f60a2 --- M modules/coal/files/coal 1 file changed, 1

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix-up for Iff996299

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317856 Change subject: Fix-up for Iff996299 .. Fix-up for Iff996299 Change-Id: I4c6e3859917c7b34d76c23eb0628402a188f60a2 --- M

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Die if no metrics received in one minute

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Die if no metrics received in one minute .. Die if no metrics received in one minute If no message is received in TIMEOUT_SECONDS (hard-coded to 60), die

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Use ^ and $ while spliting metric value and type

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Use ^ and $ while spliting metric value and type .. Use ^ and $ while spliting metric value and type If stats are sent to the enpoint using jsonp then a

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Die if no metrics received in one minute

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317847 Change subject: Die if no metrics received in one minute .. Die if no metrics received in one minute Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: coal: using stdlib's logging

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: coal: using stdlib's logging .. coal: using stdlib's logging Using syslog.syslog() is fine, except exception info doesn't end up there. We could use

[MediaWiki-commits] [Gerrit] operations/puppet[production]: coal: die if no events in N seconds

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: coal: die if no events in N seconds .. coal: die if no events in N seconds Sometimes coal will keep running even when the publisher has stopped sending it

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Use correct IP for Vanderbilt 2016-10-25 edit-a-thon throttl...

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317838 Change subject: Use correct IP for Vanderbilt 2016-10-25 edit-a-thon throttle exception .. Use correct IP for Vanderbilt 2016-10-25

[MediaWiki-commits] [Gerrit] operations/puppet[production]: coal: using stdlib's logging

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317832 Change subject: coal: using stdlib's logging .. coal: using stdlib's logging Using syslog.syslog() is fine, except exception info doesn't

[MediaWiki-commits] [Gerrit] operations/puppet[production]: coal: die if no events in N seconds

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317831 Change subject: coal: die if no events in N seconds .. coal: die if no events in N seconds Sometimes coal will keep running even when the

[MediaWiki-commits] [Gerrit] operations...pybal[master]: Drop support for the legacy configuration format

2016-10-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317823 Change subject: Drop support for the legacy configuration format .. Drop support for the legacy configuration format Per Mark, in

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.22]: mw.loader: Fix off-by-one error in splitModuleKey()

2016-10-24 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/317743 Change subject: mw.loader: Fix off-by-one error in splitModuleKey() .. mw.loader: Fix off-by-one error in splitModuleKey() Follows-up

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable AbuseFilterCachingParser on bgwiki

2016-10-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/316825 Change subject: Disable AbuseFilterCachingParser on bgwiki .. Disable AbuseFilterCachingParser on bgwiki After enabling

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove ~ori/.hushlogin

2016-10-18 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Remove ~ori/.hushlogin .. Remove ~ori/.hushlogin Hiding the MOTD banners isn't optimal when they are used to signal things like the active deployment

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable AbuseFilterCachingParser by default

2016-10-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/316364 Change subject: Enable AbuseFilterCachingParser by default .. Enable AbuseFilterCachingParser by default Set AbuseFilterParserClass to

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[wmf/1.28.0-wmf.22]: Fix-up for Ia3d767e86

2016-10-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/316361 Change subject: Fix-up for Ia3d767e86 .. Fix-up for Ia3d767e86 Add 'use ContentHandler' statement to avoid having references to

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: Fix-up for Ia3d767e86

2016-10-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/316360 Change subject: Fix-up for Ia3d767e86 .. Fix-up for Ia3d767e86 Add 'use ContentHandler' statement to avoid having references to

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable AbuseFilterCachingParser on metawiki and commonswiki

2016-10-17 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/316354 Change subject: Enable AbuseFilterCachingParser on metawiki and commonswiki .. Enable AbuseFilterCachingParser on metawiki and commonswiki

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ori: update personal dot files

2016-10-14 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: ori: update personal dot files .. ori: update personal dot files - iron isn't the ops/root bastion anymore, we all use bast* - palladium isn't the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable AbuseFilterCachingParser on testwiki and mediawikiwiki

2016-10-13 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/315729 Change subject: Enable AbuseFilterCachingParser on testwiki and mediawikiwiki .. Enable AbuseFilterCachingParser on testwiki and

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Module and role for Recommendation API

2016-10-12 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Module and role for Recommendation API .. Module and role for Recommendation API The Wikimedia Recommendation API is a JSON API that provides personalized

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: CachingSiteStore: store site list using global key

2016-10-05 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/314291 Change subject: CachingSiteStore: store site list using global key .. CachingSiteStore: store site list using global key As best as I can

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Keep counts of login errors by type

2016-09-29 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/313547 Change subject: Keep counts of login errors by type .. Keep counts of login errors by type For obvious reasons: to catch bugs and

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] Module for Recommendation API

2016-09-21 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/312045 Change subject: [WIP] Module for Recommendation API .. [WIP] Module for Recommendation API Change-Id:

[MediaWiki-commits] [Gerrit] research/recommendation-api[master]: Add .gitreview

2016-09-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/311468 Change subject: Add .gitreview .. Add .gitreview Change-Id: Ifcd49ca5a1a9301c0fc23b8240b4bbcd63291a0d --- A .gitreview 1 file changed, 6

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Memoize isWideScreen()

2016-09-16 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/311199 Change subject: Memoize isWideScreen() .. Memoize isWideScreen() It is called multiple times, and each call triggers a reflow.

[MediaWiki-commits] [Gerrit] mediawiki...PerformanceInspector[master]: Handle string input in humanSize()

2016-08-25 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/306804 Change subject: Handle string input in humanSize() .. Handle string input in humanSize() The $.isNumeric( bytes ) in humanSize() is not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: graphite: Set xFilesFactor to 0 for sum/count.

2016-08-09 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: graphite: Set xFilesFactor to 0 for sum/count. .. graphite: Set xFilesFactor to 0 for sum/count. Carbon uses xFilesFactor to decide whether to aggregate

[MediaWiki-commits] [Gerrit] Support reading/writing data to/from a static PHP array - change (mediawiki...TrustedXFF)

2016-07-22 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/300587 Change subject: Support reading/writing data to/from a static PHP array .. Support reading/writing data to/from a static PHP array If

[MediaWiki-commits] [Gerrit] Add alerting for MediaWiki exceptions and fatals - change (operations/puppet)

2016-07-21 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Add alerting for MediaWiki exceptions and fatals .. Add alerting for MediaWiki exceptions and fatals Watch the rate per minute of MediaWiki exceptions and

[MediaWiki-commits] [Gerrit] Add alerting for MediaWiki exceptions and fatals - change (operations/puppet)

2016-07-21 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/300327 Change subject: Add alerting for MediaWiki exceptions and fatals .. Add alerting for MediaWiki exceptions and fatals Watch the rate per

[MediaWiki-commits] [Gerrit] Fix-up for I39d2d7db576: move log_format directive to top level - change (operations/puppet)

2016-07-19 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Fix-up for I39d2d7db576: move log_format directive to top level .. Fix-up for I39d2d7db576: move log_format directive to top level Change-Id:

[MediaWiki-commits] [Gerrit] Fix-up for I39d2d7db576: move log_format directive to top level - change (operations/puppet)

2016-07-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/299898 Change subject: Fix-up for I39d2d7db576: move log_format directive to top level .. Fix-up for I39d2d7db576: move log_format directive to

[MediaWiki-commits] [Gerrit] rcstream: log X-Forwarded-Proto - change (operations/puppet)

2016-07-19 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: rcstream: log X-Forwarded-Proto .. rcstream: log X-Forwarded-Proto Right now the Nginx logs on rcs hosts are useless for determining which clients are

[MediaWiki-commits] [Gerrit] rcstream: log X-Forwarded-Proto - change (operations/puppet)

2016-07-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/299892 Change subject: rcstream: log X-Forwarded-Proto .. rcstream: log X-Forwarded-Proto Right now the Nginx logs on rcs hosts are useless

[MediaWiki-commits] [Gerrit] Add Http::sendBeacon() - change (mediawiki/core)

2016-07-15 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/299203 Change subject: Add Http::sendBeacon() .. Add Http::sendBeacon() Add a PHP implementation of `navigator.sendBeacon`, part of the

[MediaWiki-commits] [Gerrit] Update expected length of module version hash - change (mediawiki/core)

2016-07-13 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/298895 Change subject: Update expected length of module version hash .. Update expected length of module version hash It's 7, not 8, as of

[MediaWiki-commits] [Gerrit] Update expected length of module version hash - change (mediawiki/core)

2016-07-13 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/298892 Change subject: Update expected length of module version hash .. Update expected length of module version hash It's 7, not 8, as of

[MediaWiki-commits] [Gerrit] All wikis back to 1.28.0-wmf8 - change (operations/mediawiki-config)

2016-07-11 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/298414 Change subject: All wikis back to 1.28.0-wmf8 .. All wikis back to 1.28.0-wmf8 Due to T115198: $ zgrep -c 'local user data'

[MediaWiki-commits] [Gerrit] PCC: Fix success/failure detection - change (operations/puppet)

2016-07-11 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: PCC: Fix success/failure detection .. PCC: Fix success/failure detection Puppet always sets a nonzero exit code, so resort to cruder means of testing for

[MediaWiki-commits] [Gerrit] PCC: Fix success/failure detection - change (operations/puppet)

2016-07-11 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/298252 Change subject: PCC: Fix success/failure detection .. PCC: Fix success/failure detection Puppet always sets a nonzero exit code, so

[MediaWiki-commits] [Gerrit] Bump $wgResourceLoaderMaxQueryLength to 4, 000 - change (operations/mediawiki-config)

2016-07-01 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296963 Change subject: Bump $wgResourceLoaderMaxQueryLength to 4,000 .. Bump $wgResourceLoaderMaxQueryLength to 4,000 See if this eliminates the

[MediaWiki-commits] [Gerrit] explicitly specify identity for EL legacy zmq forwarder - change (operations/puppet)

2016-07-01 Thread Ori.livneh (Code Review)
Hello Nuria, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/296959 to review the following change. Change subject: explicitly specify identity for EL legacy zmq forwarder .. explicitly

[MediaWiki-commits] [Gerrit] Bump $wgResourceLoaderStorageEnabled to 3, 000 - change (operations/mediawiki-config)

2016-06-30 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296862 Change subject: Bump $wgResourceLoaderStorageEnabled to 3,000 .. Bump $wgResourceLoaderStorageEnabled to 3,000 The strictest URL length

[MediaWiki-commits] [Gerrit] Drop check for mbstring in copyFileBackend maintenance script - change (mediawiki/core)

2016-06-30 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296799 Change subject: Drop check for mbstring in copyFileBackend maintenance script .. Drop check for mbstring in copyFileBackend maintenance

[MediaWiki-commits] [Gerrit] For discussion: add installer option to share env data with WMF - change (mediawiki/core)

2016-06-30 Thread Ori.livneh (Code Review)
Hello Tim Starling, Krinkle, Brion VIBBER, MaxSem, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/296699 to review the following change. Change subject: For discussion: add installer option to share env data with WMF

[MediaWiki-commits] [Gerrit] Don't show the banner on action=edit - change (mediawiki...CentralNotice)

2016-06-27 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296275 Change subject: Don't show the banner on action=edit .. Don't show the banner on action=edit * It's a nice gesture to contributors. *

[MediaWiki-commits] [Gerrit] Remove ResourceLoaderModule methods that were deprecated in ... - change (mediawiki/core)

2016-06-26 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296184 Change subject: Remove ResourceLoaderModule methods that were deprecated in 1.26 .. Remove ResourceLoaderModule methods that were

[MediaWiki-commits] [Gerrit] Use hashes instead of names in module strings - change (mediawiki/core)

2016-06-26 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296179 Change subject: Use hashes instead of names in module strings .. Use hashes instead of names in module strings The code that enforces

[MediaWiki-commits] [Gerrit] Replace SHA1 with 32-bit FNV-1 as ResourceLoader's hash func... - change (mediawiki/core)

2016-06-26 Thread Ori.livneh (Code Review)
Hello Krinkle, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/296176 to review the following change. Change subject: Replace SHA1 with 32-bit FNV-1 as ResourceLoader's hash function ..

[MediaWiki-commits] [Gerrit] [NOT FOR MERGING] hack maintain-replicas.pl for adywiki/jamwiki - change (operations/software)

2016-06-22 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295564 Change subject: [NOT FOR MERGING] hack maintain-replicas.pl for adywiki/jamwiki .. [NOT FOR MERGING] hack maintain-replicas.pl for

[MediaWiki-commits] [Gerrit] Optimize mobile static images - change (operations/mediawiki-config)

2016-06-21 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295374 Change subject: Optimize mobile static images .. Optimize mobile static images Each file was converted to PNG8+alpha with ImageAlpha

[MediaWiki-commits] [Gerrit] Provision a "staging" microsite for the transparency report - change (operations/puppet)

2016-06-20 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Provision a "staging" microsite for the transparency report .. Provision a "staging" microsite for the transparency report Provision a private microsite

[MediaWiki-commits] [Gerrit] Add passwords::misc::private_static_site - change (labs/private)

2016-06-20 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Add passwords::misc::private_static_site .. Add passwords::misc::private_static_site Change-Id: Ifb52d0c19ce1181150a96c243c0cf841ca1c77db --- M

[MediaWiki-commits] [Gerrit] Add passwords::misc::private_static_site - change (labs/private)

2016-06-20 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295193 Change subject: Add passwords::misc::private_static_site .. Add passwords::misc::private_static_site Change-Id:

[MediaWiki-commits] [Gerrit] Provision a "staging" microsite for the transparency report - change (operations/puppet)

2016-06-20 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295192 Change subject: Provision a "staging" microsite for the transparency report .. Provision a "staging" microsite for the transparency report

[MediaWiki-commits] [Gerrit] Better cache headers for 'Powered by MediaWiki' badge - change (operations/mediawiki-config)

2016-06-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295184 Change subject: Better cache headers for 'Powered by MediaWiki' badge .. Better cache headers for 'Powered by MediaWiki' badge Serve

[MediaWiki-commits] [Gerrit] mediawiki.js: remove type-checks - change (mediawiki/core)

2016-06-18 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/295108 Change subject: mediawiki.js: remove type-checks .. mediawiki.js: remove type-checks I searched Google and could not find any indication

[MediaWiki-commits] [Gerrit] Simplify dynamic CSS loading by removing IE8-specific hacks - change (mediawiki/core)

2016-06-18 Thread Ori.livneh (Code Review)
Hello Krinkle, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/295100 to review the following change. Change subject: Simplify dynamic CSS loading by removing IE8-specific hacks .. Simplify

[MediaWiki-commits] [Gerrit] Make edit preview detection less expensive - change (mediawiki...Scribunto)

2016-06-15 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/294437 Change subject: Make edit preview detection less expensive .. Make edit preview detection less expensive Checking if

[MediaWiki-commits] [Gerrit] Improve client-side edit stash change detection - change (mediawiki/core)

2016-06-14 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Improve client-side edit stash change detection .. Improve client-side edit stash change detection The keypress event does not fire for backspace or

[MediaWiki-commits] [Gerrit] Improve client-side edit stash change detection - change (mediawiki/core)

2016-06-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/294418 Change subject: Improve client-side edit stash change detection .. Improve client-side edit stash change detection The keypress event

[MediaWiki-commits] [Gerrit] Revert "Make sure AntiSpoof mappings are mapping in the corr... - change (mediawiki...AntiSpoof)

2016-06-14 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/294402 Change subject: Revert "Make sure AntiSpoof mappings are mapping in the correct direction." .. Revert "Make sure AntiSpoof mappings are

  1   2   3   4   5   6   7   8   9   10   >