To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66580 Issue #:|66580 Summary:|crash in lingucomponent thesaurus Component:|lingucomponent Version:|OOo 2.0.1 Platform:|All URL:| OS/Version:|All Status:|NEW Status whiteboard:| Keywords:| Resolution:| Issue type:|DEFECT Priority:|P3 Subcomponent:|thesaurus Assigned to:|[EMAIL PROTECTED] Reported by:|tl
------- Additional comments from [EMAIL PROTECTED] Tue Jun 20 02:37:47 -0700 2006 ------- The following two stacks come from the crashreporter (the internal bug ID's are 130934 and 130690). The stacks look like this: =============================================== 00e1f4b8 64334eda lnth680mi!MyThes::binsearch(char* sw = 0965c910 "", char** list = 00000000 , int nlst = 0)+0xb [o:\src680\src.m1\lingucomponent\source\thesaurus\mythes\mythes.cxx @ 309] 00e1f5b0 64333444 lnth680mi!MyThes::Lookup(char* pText = 0cdeb9e8 "", int len = 0x965c910, mentry** pme = 00e1f608 )+0x57 [o:\src680\src.m1\lingucomponent\source\thesaurus\mythes\mythes.cxx @ 151] 00e1f648 64462d5c lnth680mi!Thesaurus::queryMeanings(rtl::OUString* rTerm = 00e1f6a0 , com::sun::star::lang::Locale* rLocale = 00e1f750 , com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>* rProperties = 00e1f760 )+0x38e =============================================== 00e1dcb8 64334e7e lnth680mi!MyThes::binsearch(char* sw = 064dda18 "", char** list = 064dd9f8 , int nlst = 0xffffffff)+0x52 [o:\src680\src.m3\lingucomponent\source\thesaurus\mythes\mythes.cxx @ 310] 00e1ddb0 643333e9 lnth680mi!MyThes::Lookup(char* pText = 05593d00 "", int len = 0x64dda18, mentry** pme = 00e1de08 )+0x57 [o:\src680\src.m3\lingucomponent\source\thesaurus\mythes\mythes.cxx @ 151] 00e1de48 64462d5c lnth680mi!Thesaurus::queryMeanings(rtl::OUString* rTerm = 00e1dea0 , com::sun::star::lang::Locale* rLocale = 00e1df50 , com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>* rProperties = 00e1df60 )+0x333 [o:\src680\src.m3\lingucomponent\source\thesaurus\libnth\nthesimp.cxx @ 380] =============================================== The first has a report count of 37 and the second of 6. The respective code part is int MyThes::binsearch(char * sw, char* list[], int nlst) { int lp, up, mp, j, indx; lp = 0; up = nlst-1; indx = -1; if (strcmp(sw,list[lp]) < 0) return -1; if (strcmp(sw,list[up]) > 0) return -1; The first crash takes place in the line with the first 'strcmp' and the second crash in the following line. Looking in the source code of m172 the line int idx = nw > 0 ? binsearch(wrd,list,nw) : -1; seems to already take care of the second crash. But it seems to me 'list' should be checked against NULL as well to guard against the first crash. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]