Hi Daniel
Thank you for your feedback! We are working on the comments you pointed out.
On 6/7/22 23:36, Daniel Latypov wrote:
> On Tue, Jun 7, 2022 at 6:09 PM Maíra Canal wrote:
>> diff --git
>> a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/display_mode_lib_test.c
>>
the proper functioning of
the basic mathematical operations of fixed-point arithmetic, such as
multiplication, conversion from fractional to fixed-point number, and more.
Co-developed-by: Tales Aparecida
Signed-off-by: Tales Aparecida
Signed-off-by: Magali Lemes
Co-developed-by: Maíra Canal
, making it accessible to future unit tests.
Signed-off-by: Maíra Canal
---
.../gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c| 14 +-
drivers/gpu/drm/amd/display/dc/inc/bw_fixed.h | 14 ++
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu
one part of the Display Mode
Library: display_mode_lib, in order to introduce the basic structure of the
tests on the DML.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/Kconfig | 1 +
.../gpu/drm/amd/display/amdgpu_dm/Makefile| 5 ++
.../gpu/drm/amd/display/amdgpu_dm
This RFC is a preview of the work being developed by Isabella Basso [1],
Maíra Canal [2], and Tales Lelo [3], as part of their Google Summer of Code
projects [4], and Magali Lemes [5], as part of her capstone project.
Our main goal is to bring unit testing to the AMDPGU driver; in particular
u/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:488:1:
note: declare 'static' if the function is not intended to be used outside
of this translation unit
void dcn316_clk_mgr_helper_populate_bw_params(
^
static
1 warning generated.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/displ
u32 tmp;
^
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:325:6: warning: variable 'tmp' set but
not used [-Wunused-but-set-variable]
u32 tmp;
^
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 +---
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 +---
SOURCE_VUPDATE1 + reg_num] = {\
^~
6 warnings generated.
fixes: 688f97ed ("drm/amd/display: Add vupdate_no_lock interrupts for
DCN2.1")
Signed-off-by: Maíra Canal
---
.../amd/display/dc/irq/dcn21/irq_service_dcn21.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/
e uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *adev,
^
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
index de85a998ef99..f3
ult(struct amdgpu_device *adev,
^
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev,
^
static
Signed-off-by: Maíra Canal
---
This patchset intends to deal with a couple of warnings in the AMD graphic
drivers. All warnings were generated with Clang and W=1 flag.
Maíra Canal (10):
drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope
drm/amdgpu: Remove tmp unused variable
drm/amdgpu: Remove unused
t-variable]
bool clamshell_closed = false;
^
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
b/drivers/gpu/drm/amd/displa
' set but not used [-Wunused-but-set-variable]
uint64_t temp;
^
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
b/drivers/g
hyclk' [-Wmissing-prototypes]
int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int
requested_phyclk_khz)
^
Signed-off-by: Maíra Canal
---
.../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/g
(struct dc *dc)
^
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c
b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c
index f1f89f93603f..1826dd7f3
'dmub_outbox_irq_info_funcs'
[-Wunused-const-variable]
static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs = {
^
Signed-off-by: Maíra Canal
---
.../gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 5 -
1 file changed, 5
xes: 6ddbd37f ("drm/amd/pm: optimize the amdgpu_pm_compute_clocks()
implementations")
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/amd/pm/amdgpu_dpm_internal.c | 1 +
drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 1 -
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 1 +
3 files changed, 2
101 - 117 of 117 matches
Mail list logo
