RE: [PATCH] drm/amd/display: Fix do_mccs handling (MCCS/DDC) in amdgpu_dm_update_freesync_caps

[SHANMUGAM, SRINIVASAN]

[AMD Official Use Only - AMD Internal Distribution Only]

> -Original Message-
> From: Hung, Alex 
> Sent: Monday, April 6, 2026 9:15 PM
> To: SHANMUGAM, SRINIVASAN ;
> Pillai, Aurabindo 
> Cc: amd-gfx@lists.freedesktop.org; Wentland, Harry ;
> Lin, Wayne ; Li, Roman ; Chung,
> ChiaHsuan (Tom) 
> Subject: Re: [PATCH] drm/amd/display: Fix do_mccs handling (MCCS/DDC) in
> amdgpu_dm_update_freesync_caps
>
>
> On 4/4/26 20:31, Srinivasan Shanmugam wrote:
> > Fix do_mccs parameter usage in amdgpu_dm_update_freesync_caps.
> >
> > This function checks FreeSync support from the display and updates
> > driver state.  MCCS (Monitor Control Command Set) over DDC (Display
> > Data
> > Channel) is used for communication between GPU and monitor.
>
> This changes comments but the title and the commit descriptions sound like
> changing the code. Can you clarify them?

Thanks for the review.

The change only adds a missing description for the do_mccs parameter in
the function kdoc. There is no functional impact.

I’ll reword the title and commit message to avoid confusion.

Best regards,
Srini

Re: [PATCH] drm/amd/display: Fix do_mccs handling (MCCS/DDC) in amdgpu_dm_update_freesync_caps

[Alex Hung]

On 4/4/26 20:31, Srinivasan Shanmugam wrote:

Fix do_mccs parameter usage in amdgpu_dm_update_freesync_caps.

This function checks FreeSync support from the display and updates
driver state.  MCCS (Monitor Control Command Set) over DDC (Display Data
Channel) is used for communication between GPU and monitor.


This changes comments but the title and the commit descriptions sound 
like changing the code. Can you clarify them?




Fixes: 980a8981351a ("drm/amd/display: Avoid to do MCCS transaction if 
unnecessary")
Cc: Harry Wentland 
Cc: Wayne Lin 
Cc: Roman Li 
Cc: Alex Hung 
Cc: Tom Chung 
Cc: Aurabindo Pillai 
Signed-off-by: Srinivasan Shanmugam 
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index bac02ea15b8a..4b6a1c62bfa8 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -13259,6 +13259,7 @@ static int parse_hdmi_amd_vsdb(struct 
amdgpu_dm_connector *aconnector,
   *
   * @connector: Connector to query.
   * @drm_edid: DRM EDID from monitor
+ * @do_mccs: Whether to query/update MCCS-based FreeSync capability handling.
   *
   * Amdgpu supports Freesync in DP and HDMI displays, and it is required to 
keep
   * track of some of the display information in the internal data struct used 
by

[PATCH] drm/amd/display: Fix do_mccs handling (MCCS/DDC) in amdgpu_dm_update_freesync_caps

[Srinivasan Shanmugam]

Fix do_mccs parameter usage in amdgpu_dm_update_freesync_caps.

This function checks FreeSync support from the display and updates
driver state.  MCCS (Monitor Control Command Set) over DDC (Display Data
Channel) is used for communication between GPU and monitor.

Fixes: 980a8981351a ("drm/amd/display: Avoid to do MCCS transaction if 
unnecessary")
Cc: Harry Wentland 
Cc: Wayne Lin 
Cc: Roman Li 
Cc: Alex Hung 
Cc: Tom Chung 
Cc: Aurabindo Pillai 
Signed-off-by: Srinivasan Shanmugam 
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index bac02ea15b8a..4b6a1c62bfa8 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -13259,6 +13259,7 @@ static int parse_hdmi_amd_vsdb(struct 
amdgpu_dm_connector *aconnector,
  *
  * @connector: Connector to query.
  * @drm_edid: DRM EDID from monitor
+ * @do_mccs: Whether to query/update MCCS-based FreeSync capability handling.
  *
  * Amdgpu supports Freesync in DP and HDMI displays, and it is required to keep
  * track of some of the display information in the internal data struct used by
-- 
2.34.1