Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 19, 2014, 5:46 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review14013 --- When I was writing tests for this new functionality, I came acr

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13993 --- Ship it! Ship It! - greenfieldtech On Dec. 17, 2014, 6:59 p

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13991 --- Ship it! Looks good to me. Thanks, Nir! I'll give this about a

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 17, 2014, 6:59 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Dec. 17, 2014, 5:14 p.m., Mark Michelson wrote: > > /trunk/rest-api/api-docs/channels.json, line 374 > > > > > > Why is this change present? > > greenfieldtech wrote: > I changed this from int to long, fo

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Dec. 17, 2014, 11:14 a.m., Mark Michelson wrote: > > /trunk/rest-api/api-docs/channels.json, line 374 > > > > > > Why is this change present? > > greenfieldtech wrote: > I changed this from int to long, f

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Dec. 17, 2014, 5:14 p.m., Mark Michelson wrote: > > /trunk/rest-api/api-docs/channels.json, line 374 > > > > > > Why is this change present? I changed this from int to long, for consistency sake. The other fu

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13983 --- Thanks for the upload Nir. The remaining issues on the patch ar

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 17, 2014, 12:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 17, 2014, 11:59 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 17, 2014, 10:31 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Dec. 17, 2014, 10:27 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Dec. 16, 2014, 5:01 p.m., Mark Michelson wrote: > > Hey Nir, I just wanted to see what's going on with this and if we can > > expect to see a new diff posted any time soon. If you're busy with other > > things, that's fine, but we'd love to get this merged in sometime soon if > > we can.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Dec. 16, 2014, 5:01 p.m., Mark Michelson wrote: > > Hey Nir, I just wanted to see what's going on with this and if we can > > expect to see a new diff posted any time soon. If you're busy with other > > things, that's fine, but we'd love to get this merged in sometime soon if > > we can.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13964 --- Hey Nir, I just wanted to see what's going on with this and if

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 5:43 p.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 5:43 p.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 11:43 a.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 11:43 a.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

> On Nov. 5, 2014, 5:43 p.m., Joshua Colp wrote: > > Matt brought it up that this is actually a backwards incompatible change - > > specifically changing priority into a string from an integer. What about > > having label as a separate argument that is optional? If present it's > > treated as

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13690 --- Matt brought it up that this is actually a backwards incompatib

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Nov. 5, 2014, 2:16 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13688 --- /trunk/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Nov. 2, 2014, 1:25 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Nov. 2, 2014, 7:14 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/#review13624 --- /trunk/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Oct. 21, 2014, 5:50 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Oct. 21, 2014, 5:47 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Oct. 21, 2014, 5:27 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4101/ --- (Updated Oct. 21, 2014, 5:27 p.m.) Review request for Asterisk Developers.