Re: [ath5k-devel] [PATCH] ath5k: fix setup of transmit descriptors

2007-10-26 Thread Nick Kossifidis
2007/10/26, Ulrich Meis <[EMAIL PROTECTED]>: > This patch fixes the setup of transmit descriptors. tx_control_1 is set > in ath5k_hw_setup_{2,4}word_tx_desc but was subsequently overriden by > ath5k_hw_fill_{2,4}word_tx_desc. The victims were FRAME_TYPE and NO_ACK. > The missing no_ack in broadcast

Re: [ath5k-devel] [PATCH 1/2] ath5k: Maintain coding style

2007-10-26 Thread Nick Kossifidis
2007/10/26, Nick Kossifidis <[EMAIL PROTECTED]>: > 2007/10/25, John W. Linville <[EMAIL PROTECTED]>: > > On Sun, Oct 21, 2007 at 01:36:30AM +, Nick Kossifidis wrote: > > > * Sort functions in segments like we do on the rest of the code (eg. > > > hw.c). This improves readability and maintainabi

Re: [ath5k-devel] [PATCH] ath5k: fix setup of transmit descriptors

2007-10-26 Thread Ulrich Meis
On Fri 26.10.07 10:37, Luis R. Rodriguez wrote: > On 10/26/07, Ulrich Meis <[EMAIL PROTECTED]> wrote: > > This patch fixes the setup of transmit descriptors. tx_control_1 is set > > in ath5k_hw_setup_{2,4}word_tx_desc but was subsequently overriden by > > ath5k_hw_fill_{2,4}word_tx_desc. The victim

Re: [ath5k-devel] [PATCH] ath5k: fix setup of transmit descriptors

2007-10-26 Thread Luis R. Rodriguez
On 10/26/07, Ulrich Meis <[EMAIL PROTECTED]> wrote: > This patch fixes the setup of transmit descriptors. tx_control_1 is set > in ath5k_hw_setup_{2,4}word_tx_desc but was subsequently overriden by > ath5k_hw_fill_{2,4}word_tx_desc. The victims were FRAME_TYPE and NO_ACK. > The missing no_ack in br

[ath5k-devel] [PATCH] ath5k: fix setup of transmit descriptors

2007-10-26 Thread Ulrich Meis
This patch fixes the setup of transmit descriptors. tx_control_1 is set in ath5k_hw_setup_{2,4}word_tx_desc but was subsequently overriden by ath5k_hw_fill_{2,4}word_tx_desc. The victims were FRAME_TYPE and NO_ACK. The missing no_ack in broadcast frames caused them to be retried up to the retry_lim

Re: [ath5k-devel] [PATCH 1/2] ath5k: Maintain coding style

2007-10-26 Thread Nick Kossifidis
2007/10/25, John W. Linville <[EMAIL PROTECTED]>: > On Sun, Oct 21, 2007 at 01:36:30AM +, Nick Kossifidis wrote: > > * Sort functions in segments like we do on the rest of the code (eg. > > hw.c). This improves readability and maintainability. > > > > * Add myself as module author (a patch for