Re: [ath5k-devel] [PATCH] [PATCH 2/4] Remove Atheros 11n devices from ath5k

2008-07-20 Thread Michael Renzmann
Hi. Luis R. Rodriguez wrote: > Remove Atheros 11n devices from being claimed by ath5k as its > now handled by ath9k. I must admit that I can't tell it myself due to a lack of in-depth knowledge about both drivers, hence the question: why a new driver, rather than adding 11n support to ath5k and h

Re: [ath5k-devel] 2425 tests

2008-07-20 Thread Nick Kossifidis
2008/7/20 Alan Jenkins <[EMAIL PROTECTED]>: > Frédéric Weisbecker wrote: >> Yes I have the same problem. >> I think I found the origin. >> That's because wme_qdiscop_destroy in net/mac80211/wme.c passes a bad >> pointer in tcf_destroy_chain. >> It requires a struct tcf_proto **fl and not a struct t

Re: [ath5k-devel] 2425 tests

2008-07-20 Thread Alan Jenkins
Frédéric Weisbecker wrote: > Yes I have the same problem. > I think I found the origin. > That's because wme_qdiscop_destroy in net/mac80211/wme.c passes a bad > pointer in tcf_destroy_chain. > It requires a struct tcf_proto **fl and not a struct tcf_proto *fl > > Here is a patch, I can't test it b

Re: [ath5k-devel] [PATCH 1/5] ath9k: fix bad udelay

2008-07-20 Thread Luis R. Rodriguez
On Sun, Jul 20, 2008 at 6:33 AM, Felix Fietkau <[EMAIL PROTECTED]> wrote: > Replace udelay(3000) with mdelay(3), because udelay(3000) fails on > some architectures, e.g. ARM > > Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> This is for 1-5, thanks. Acked-by: Luis R. Rodriguez <[EMAIL PROTECTED

[ath5k-devel] [PATCH 5/5] ath9k: fix DMA descriptor access on big-endian

2008-07-20 Thread Felix Fietkau
Remove the descriptor swap, as the driver already configures the hardware for descriptor swapping on big endian systems Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/core.c +++ b/drivers/net/wireless/ath9k/core.c @@ -2141,22 +2141,6 @@ memzero(dd, si

[ath5k-devel] [PATCH 4/5] ath9k: fix return code check

2008-07-20 Thread Felix Fietkau
Fix a return code check for ath9k_hw_nvram_read, this function returns AH_TRUE when the call succeeded Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/hw.c +++ b/drivers/net/wireless/ath9k/hw.c @@ -803,7 +803,7 @@ u_int16_t magic, magic2;

[ath5k-devel] [PATCH 3/5] ath9k: add missing device ID for AR9160 MiniPCI cards

2008-07-20 Thread Felix Fietkau
Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/hw.c +++ b/drivers/net/wireless/ath9k/hw.c @@ -8329,6 +8329,8 @@ case AR5416_DEVID_PCI: case AR5416_DEVID_PCIE: return "Atheros 5416"; + case AR9160_DEVID_PCI: +

[ath5k-devel] [PATCH 2/5] ath9k: add missing include statements

2008-07-20 Thread Felix Fietkau
Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/regd.c +++ b/drivers/net/wireless/ath9k/regd.c @@ -14,6 +14,8 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ +#include +#include #include "ath9k.h" #include "regd.h" #includ

[ath5k-devel] [PATCH 1/5] ath9k: fix bad udelay

2008-07-20 Thread Felix Fietkau
Replace udelay(3000) with mdelay(3), because udelay(3000) fails on some architectures, e.g. ARM Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/recv.c +++ b/drivers/net/wireless/ath9k/recv.c @@ -737,7 +737,7 @@ ath9k_hw_stoppcurecv(ah); /* disabl

Re: [ath5k-devel] [PATCH v2] ath5k: don't enable MSI, we cannot handle it yet

2008-07-20 Thread Kyle McMartin
On Fri, Jul 18, 2008 at 08:57:39PM +0300, Nick Kossifidis wrote: > > MSI is a nice thing, but we cannot enable it without changing the > > interrupt handler. If we do it, we break MSI capable hardware, > > specifically AR5006 chipset. > > > > Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> > > Th

Re: [ath5k-devel] [stable] [PATCH] ath5k: don't enable MSI, we cannot handle it yet

2008-07-20 Thread Greg KH
On Fri, Jul 18, 2008 at 06:49:24PM +0200, Michael Buesch wrote: > On Friday 18 July 2008 18:44:47 Pavel Roskin wrote: > > On Fri, 2008-07-18 at 12:28 -0400, Pavel Roskin wrote: > > > This fixes support for AR5006 chipset, which supports MSI > > > > Sorry, I found Documentation/stable_kernel_rules.

Re: [ath5k-devel] [PATCH v2] ath5k: don't enable MSI, we cannot handle it yet

2008-07-20 Thread Henrique de Moraes Holschuh
On Fri, 18 Jul 2008, Nick Kossifidis wrote: > 2008/7/18 Pavel Roskin <[EMAIL PROTECTED]>: > > MSI is a nice thing, but we cannot enable it without changing the > > interrupt handler. If we do it, we break MSI capable hardware, > > specifically AR5006 chipset. > > > > Signed-off-by: Pavel Roskin <[

Re: [ath5k-devel] [PATCH] ath5k: don't enable MSI, we cannot handle it yet

2008-07-20 Thread Michael Buesch
On Friday 18 July 2008 18:44:47 Pavel Roskin wrote: > On Fri, 2008-07-18 at 12:28 -0400, Pavel Roskin wrote: > > This fixes support for AR5006 chipset, which supports MSI > > Sorry, I found Documentation/stable_kernel_rules.txt minutes after > sending the patch. We need to get it to the Linus' tr