Re: [ath5k-devel] problems with debugfs

2009-04-19 Thread Paride Legovini
On Sun, Apr 19, 2009 at 11:32:46PM -0400, Bob Copeland wrote: > On Mon, Apr 20, 2009 at 04:07:11AM +0200, Paride Legovini wrote: > > Are we sure that current led settings for this card, i.e. ATH_LED(0, 0), > > are not just wrong? > > No, not sure it's correct, but that's been in the code forever.

Re: [ath5k-devel] problems with debugfs

2009-04-19 Thread Bob Copeland
On Mon, Apr 20, 2009 at 04:07:11AM +0200, Paride Legovini wrote: > Are we sure that current led settings for this card, i.e. ATH_LED(0, 0), > are not just wrong? No, not sure it's correct, but that's been in the code forever. However, if you put the subdevice match first in the match table, it sh

Re: [ath5k-devel] problems with debugfs

2009-04-19 Thread Bob Copeland
On Sat, Apr 18, 2009 at 10:53 AM, Paride Legovini wrote: > I wanted to enable my laptop's (thinkpad x60s) wireless led with the new > debugfs interface, as described e.g. here: > > http://www.mail-archive.com/ath5k-devel@lists.ath5k.org/msg01903.html That patch didn't actually go in, so you'll ha

Re: [ath5k-devel] [PATCH 1/7] ath5k: Allow user/driver to set txpower

2009-04-19 Thread Bob Copeland
On Thu, Apr 16, 2009 at 03:22:20AM +0300, Nick Kossifidis wrote: > * Now that we have regulatory control enable the driver to set txpower on hw I assume this needs my patch for the CTLs (reproduced below). Any objections to it? From: Bob Copeland Subject: [PATCH] ath5k: use ctl settings based

Re: [ath5k-devel] [PATCH 5/7] ath5k: Enable AP mode

2009-04-19 Thread Bob Copeland
On Thu, Apr 16, 2009 at 03:36:04AM +0300, Nick Kossifidis wrote: > Author: Jiri Slaby (Jiri added AP support on ath5k, i'm just setting the > flag here) Should do this like: From: Jiri Slaby <...> Then git-am will pick it up automatically. > + BIT(NL80211_IFTYPE_AP) | Yay! Ack

Re: [ath5k-devel] [PATCH 4/7] ath5k: Beaconing fixes

2009-04-19 Thread Bob Copeland
On Thu, Apr 16, 2009 at 03:29:51AM +0300, Nick Kossifidis wrote: > * Fix num_tx_pending function, we never read the register :P that's why we > got all those "beacon queue 7 didn't stop messages". > > @@ -160,7 +160,8 @@ u32 ath5k_hw_num_tx_pending(struct ath5k_hw *ah, unsigned > int queue) >