Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Bob Copeland
On Mon, Jun 15, 2009 at 09:58:30PM +0200, Rafael J. Wysocki wrote: > On Monday 15 June 2009, Alan Stern wrote: > > I'm not sure whether the example is trustworthy. There was some > > discussion quite a while ago regarding whether drivers should free > > their IRQs during suspend, but I don't remem

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Rafael J. Wysocki
On Monday 15 June 2009, Alan Stern wrote: > On Mon, 15 Jun 2009, Rafael J. Wysocki wrote: > > > > I'm not sure whether the example is trustworthy. There was some > > > discussion quite a while ago regarding whether drivers should free > > > their IRQs during suspend, but I don't remember what the

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Alan Stern
On Mon, 15 Jun 2009, Rafael J. Wysocki wrote: > > I'm not sure whether the example is trustworthy. There was some > > discussion quite a while ago regarding whether drivers should free > > their IRQs during suspend, but I don't remember what the outcome was. > > No, they shouldn't. > > That's w

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Rafael J. Wysocki
On Monday 15 June 2009, Alan Stern wrote: > On Mon, 15 Jun 2009, Alan Jenkins wrote: > > > Alan Stern wrote: > > > On Mon, 15 Jun 2009, Alan Jenkins wrote: > > > > > > > > >> Hi, > > >> > > >> I triggered a WARNING while hacking on eeepc-laptop's > > >> rfkill-by-pci-hotplug. I saw "Trying to

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Alan Stern
On Mon, 15 Jun 2009, Alan Jenkins wrote: > Alan Stern wrote: > > On Mon, 15 Jun 2009, Alan Jenkins wrote: > > > > > >> Hi, > >> > >> I triggered a WARNING while hacking on eeepc-laptop's > >> rfkill-by-pci-hotplug. I saw "Trying to free already-free IRQ" in > >> ath5k_pci_remove(), because t

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Alan Stern
On Mon, 15 Jun 2009, Alan Jenkins wrote: > Hi, > > I triggered a WARNING while hacking on eeepc-laptop's > rfkill-by-pci-hotplug. I saw "Trying to free already-free IRQ" in > ath5k_pci_remove(), because the IRQ was already freed by > ath5k_pci_suspend(). My changes to eeepc-laptop had allowe

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-15 Thread Alan Jenkins
Alan Stern wrote: > On Mon, 15 Jun 2009, Alan Jenkins wrote: > > >> Hi, >> >> I triggered a WARNING while hacking on eeepc-laptop's >> rfkill-by-pci-hotplug. I saw "Trying to free already-free IRQ" in >> ath5k_pci_remove(), because the IRQ was already freed by >> ath5k_pci_suspend(). My cha

[ath5k-devel] PCI hotplug v.s. suspend

2009-06-15 Thread Alan Jenkins
Hi, I triggered a WARNING while hacking on eeepc-laptop's rfkill-by-pci-hotplug. I saw "Trying to free already-free IRQ" in ath5k_pci_remove(), because the IRQ was already freed by ath5k_pci_suspend(). My changes to eeepc-laptop had allowed the PCI device to be removed while suspended. Are