Re: [ath5k-devel] [PATCH 1/1] ath5k: fix beacon_int handling

2009-06-18 Thread Bob Copeland
On Thu, Jun 18, 2009 at 9:14 PM, Bob Copeland wrote: >> Otherwise it will be set only once by upper layer through >> bss_info_changed but not on second and further hostap executions. > > Shouldn't we just not destroy the value in add_interface? Err, nevermind, that's exactly what your patch does.

Re: [ath5k-devel] [PATCH 1/1] ath5k: fix beacon_int handling

2009-06-18 Thread Bob Copeland
On Thu, Jun 18, 2009 at 7:06 PM, Jiri Slaby wrote: > 73ca5203366235f8a43e490767284ba8cfd8c479 > (ath5k: remove conf->beacon_int usage) > removed bintval setting from ath5k_config. We need to init the > interval earlier and don't touch it in add_interface anymore. > > Otherwise it will be set only o

[ath5k-devel] [PATCH 1/1] ath5k: fix beacon_int handling

2009-06-18 Thread Jiri Slaby
73ca5203366235f8a43e490767284ba8cfd8c479 (ath5k: remove conf->beacon_int usage) removed bintval setting from ath5k_config. We need to init the interval earlier and don't touch it in add_interface anymore. Otherwise it will be set only once by upper layer through bss_info_changed but not on second

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-18 Thread Alan Jenkins
Alan Stern wrote: > On Thu, 18 Jun 2009, Alan Jenkins wrote: > > >> Unfortunately this makes it worse. My eeepc-laptop hacks are now in >> wireless-testing. If I apply the above patch to wireless-testing and >> "remove" the device while suspended, I get a soft hang on resume. >> > > Is t

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-18 Thread Alan Stern
On Thu, 18 Jun 2009, Alan Jenkins wrote: > Unfortunately this makes it worse. My eeepc-laptop hacks are now in > wireless-testing. If I apply the above patch to wireless-testing and > "remove" the device while suspended, I get a soft hang on resume. Is this different from the behavior without

[ath5k-devel] [PATCH 1/5] MAINTAINERS: Fix Atheros pattern paths

2009-06-18 Thread Joe Perches
Signed-off-by: Joe Perches --- MAINTAINERS |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fb94add..4e73646 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -946,7 +946,7 @@ M: m...@bobcopeland.com L: linux-wirel...@vger.kernel.org

Re: [ath5k-devel] [linux-pm] PCI hotplug v.s. suspend

2009-06-18 Thread Alan Jenkins
Bob Copeland wrote: > On Mon, Jun 15, 2009 at 09:58:30PM +0200, Rafael J. Wysocki wrote: > >> On Monday 15 June 2009, Alan Stern wrote: >> >>> I'm not sure whether the example is trustworthy. There was some >>> discussion quite a while ago regarding whether drivers should free >>> their IR