* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
a) We don't need a timer for this, there is no need for accuracy
even with round_jiffies i think this is a waste of resources.
Also we don't need to run calibration if we are idle
On 07/31/2009 11:08 AM, Nick Kossifidis wrote:
> * Don't put chip to full sleep because there are problems during
> wakeup. Instead hold MAC/Baseband on warm reset state via a new
> function ath5k_hw_on_hold.
>
> * Durring attach preserve pcicfg bits when enabling pci core
> sw retr
2009/7/31 Bob Copeland :
> On Fri, Jul 31, 2009 at 2:25 PM, Nick Kossifidis wrote:
>> Also we don't need to run calibration if we are idle (no interrupts).
>
> I think this is the big win right now...
>
>> c) Having calibration on a tasklet is better since during calibration
>> we can't trans
On Fri, 2009-07-31 at 22:35 +0300, Nick Kossifidis wrote:
> Nope calibration deals mostly with noise immunity, it calculates the
> noise floor and fixes QAM constellation. It's not related to the synthesizer
> so it's not related to the channel frequency.
OK then, good to know.
--
Regards,
Pave
2009/7/31 Pavel Roskin :
> On Fri, 2009-07-31 at 21:25 +0300, Nick Kossifidis wrote:
>
>> a) We don't need a timer for this, there is no need for accuracy
>> even with round_jiffies i think this is a waste of resources.
>> Also we don't need to run calibration if we are idle (no interrupts)
On Fri, Jul 31, 2009 at 2:25 PM, Nick Kossifidis wrote:
> Also we don't need to run calibration if we are idle (no interrupts).
I think this is the big win right now...
> c) Having calibration on a tasklet is better since during calibration
> we can't transmit or receive (antennas are detac
On Fri, 2009-07-31 at 21:25 +0300, Nick Kossifidis wrote:
> a) We don't need a timer for this, there is no need for accuracy
> even with round_jiffies i think this is a waste of resources.
> Also we don't need to run calibration if we are idle (no interrupts).
It doesn't sound right to me
On Fri, Jul 31, 2009 at 12:03 PM, Ben Greear wrote:
> On 07/31/2009 11:08 AM, Nick Kossifidis wrote:
>>
>> * Don't put chip to full sleep because there are problems during
>> wakeup. Instead hold MAC/Baseband on warm reset state via a new
>> function ath5k_hw_on_hold.
>>
>> * Durring attach
On Fri, Jul 31, 2009 at 11:39 AM, Nick Kossifidis wrote:
> 2009/7/31 Luis R. Rodriguez :
>> On Fri, Jul 31, 2009 at 11:08 AM, Nick
>> Kossifidis wrote:
>>> * Don't put chip to full sleep because there are problems during
>>> wakeup. Instead hold MAC/Baseband on warm reset state via a new
>>> f
On Fri, Jul 31, 2009 at 11:25 AM, Nick Kossifidis wrote:
> 2009/7/31 Luis R. Rodriguez :
>> On Fri, Jul 31, 2009 at 11:10 AM, Nick
>> Kossifidis wrote:
>>> * Get rid of calibration timer, instead use a software interrupt
>>> to schedule the calibration tasklet.
>>
>> An example of itemizing one
On Fri, Jul 31, 2009 at 11:02 AM, Nick
Kossifidis wrote:
> * Read PCI-E infos offset from EEPROM and if it points to
> serdes section (0x40), enable serdes programming (further
> tweaking of serdes values during attach). This follows
> Legacy and Sam's HAL sources.
>
> ---
> drivers/net/wir
2009/7/31 Luis R. Rodriguez :
> On Fri, Jul 31, 2009 at 11:08 AM, Nick
> Kossifidis wrote:
>> * Don't put chip to full sleep because there are problems during
>> wakeup. Instead hold MAC/Baseband on warm reset state via a new
>> function ath5k_hw_on_hold.
>>
>> * Durring attach preserve pcicf
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
Signed-off-by: Nick Kossifidis
---
drivers/net/wireless/ath/ath5k/ath5k.h | 16
drivers/net/wireless/ath/ath5k/base.c | 28 ++--
drivers/net/w
* Don't put chip to full sleep because there are problems during
wakeup. Instead hold MAC/Baseband on warm reset state via a new
function ath5k_hw_on_hold.
* Durring attach preserve pcicfg bits when enabling pci core
sw retry fix.
* Minor cleanups
Signed-off-by: Nick Kossifidis
--
* Set correct xpd curve indices for high/low gain curves during
rfbuffer setup on RF5112B with both calibration curves available.
* Don't return zero min power when we have the same pcdac value
twice because it breaks interpolation. Instead return the right
x barrier as we do when we ha
* Read PCI-E infos offset from EEPROM and if it points to
serdes section (0x40), enable serdes programming (further
tweaking of serdes values during attach). This follows
Legacy and Sam's HAL sources.
Signed-off-by: Nick Kossifidis
---
drivers/net/wireless/ath/ath5k/attach.c | 56 +
2009/7/31 Luis R. Rodriguez :
> On Fri, Jul 31, 2009 at 11:18 AM, Nick Kossifidis wrote:
>> 2009/7/31 Luis R. Rodriguez :
>>>
>>> Can the changes for the code be done before the move, or after so that
>>> way the actual code changes to the section can be easily readable?
>>>
>>
>> Since we use EEPR
On Fri, Jul 31, 2009 at 11:18 AM, Nick Kossifidis wrote:
> 2009/7/31 Luis R. Rodriguez :
>>
>> Can the changes for the code be done before the move, or after so that
>> way the actual code changes to the section can be easily readable?
>>
>
> Since we use EEPROM infos we must move this after eeprom
2009/7/31 Luis R. Rodriguez :
> On Fri, Jul 31, 2009 at 11:10 AM, Nick
> Kossifidis wrote:
>> * Get rid of calibration timer, instead use a software interrupt
>> to schedule the calibration tasklet.
>
> An example of itemizing one change. Explain the why, not the how.
>
We 've discussed this wi
2009/7/31 Luis R. Rodriguez :
>
> Can the changes for the code be done before the move, or after so that
> way the actual code changes to the section can be easily readable?
>
Since we use EEPROM infos we must move this after eeprom initialization.
>
> This is just comment-picky mind using this s
On Fri, Jul 31, 2009 at 11:10 AM, Nick
Kossifidis wrote:
> * Get rid of calibration timer, instead use a software interrupt
> to schedule the calibration tasklet.
An example of itemizing one change. Explain the why, not the how.
Luis
___
ath5k-deve
On Fri, Jul 31, 2009 at 11:08 AM, Nick
Kossifidis wrote:
> * Don't put chip to full sleep because there are problems during
> wakeup. Instead hold MAC/Baseband on warm reset state via a new
> function ath5k_hw_on_hold.
>
> * Durring attach preserve pcicfg bits when enabling pci core
> sw re
2009/7/31 Luis R. Rodriguez :
> On Fri, Jul 31, 2009 at 11:05 AM, Nick
> Kossifidis wrote:
>> * Set correct xpd curve indices for high/low gain curves during
>> rfbuffer setup on RF5112B with both calibration curves available.
>>
>> * Don't return zero min power when we have the same pcdac valu
* Get rid of calibration timer, instead use a software interrupt
to schedule the calibration tasklet.
---
drivers/net/wireless/ath/ath5k/ath5k.h | 16
drivers/net/wireless/ath/ath5k/base.c | 28 ++--
drivers/net/wireless/ath/ath5k/base.h |3 +
* Don't put chip to full sleep because there are problems during
wakeup. Instead hold MAC/Baseband on warm reset state via a new
function ath5k_hw_on_hold.
* Durring attach preserve pcicfg bits when enabling pci core
sw retry fix.
* Minor cleanups
---
drivers/net/wireless/ath/ath5k/
On Fri, Jul 31, 2009 at 11:05 AM, Nick
Kossifidis wrote:
> * Set correct xpd curve indices for high/low gain curves during
> rfbuffer setup on RF5112B with both calibration curves available.
>
> * Don't return zero min power when we have the same pcdac value
> twice because it breaks interpol
* Set correct xpd curve indices for high/low gain curves during
rfbuffer setup on RF5112B with both calibration curves available.
* Don't return zero min power when we have the same pcdac value
twice because it breaks interpolation. Instead return the right
x barrier as we do when we ha
* Read PCI-E infos offset from EEPROM and if it points to
serdes section (0x40), enable serdes programming (further
tweaking of serdes values during attach). This follows
Legacy and Sam's HAL sources.
---
drivers/net/wireless/ath/ath5k/attach.c | 56 +++
dr
* Read PCI-E infos offset from EEPROM and if it points to
serdes section (0x40), enable serdes programming (further
tweaking of serdes values during attach). This follows
Legacy and Sam's HAL sources.
---
drivers/net/wireless/ath/ath5k/attach.c | 56 +++
dr
29 matches
Mail list logo
