Re: [ath5k-devel] [PATCH 5/5] ath5k: add bounds check to pdadc table

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:13 Bob Copeland wrote: > We check the bounds on pdadc once when correcting for > negative curves but not when we later copy values from > from the pdadc_tmp array, leading to a potential overrun. > > Although we shouldn't hit this case in practice, let's > be consiste

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:11 Bob Copeland wrote: > Review spotted a couple of strange invocations to > ieee80211_wake_queues that could potentially cause problems: > > - queues are awakened in the calibration tasklet before >phy calibration, and then again after calibration > > - queues

Re: [ath5k-devel] [PATCH 2/5] ath5k: correct channel setting for 2.5 mhz spacing

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:10 Bob Copeland wrote: > These channels aren't selectable anyway, but our calculations > for 2.5 mhz frequencies are incorrect. The value is supposed to > be: > > (frequency - reference) * (10/25) > > i.e., divide by 2.5, but we were instead doing: > > (10 * fr

Re: [ath5k-devel] [PATCH 1/5] ath5k: fix off-by-one in pilot magnitude mask

2010-03-29 Thread Bruno Randolf
On Monday 29 March 2010 10:42:09 Bob Copeland wrote: > If the symbol offset is 46, it will be counted in both > the third and fourth bytes of the mask, and in this > case the shift will be negative which can pollute > high order bits in the mask. This may negatively impact > OFDM symbol detection.

Re: [ath5k-devel] Module unload effect on card's working

2010-03-29 Thread Pavel Roskin
On Mon, 2010-03-29 at 18:45 +0530, anmol khurana wrote: > Hi > > My PCI wireless card uses the module ath5k . I am using > compat-wireless to make changes in the source code and > make/install/load it again and see how my card's working is affected > by the changes.Basically the following command

[ath5k-devel] Module unload effect on card's working

2010-03-29 Thread anmol khurana
Hi My PCI wireless card uses the module ath5k . I am using compat-wireless to make changes in the source code and make/install/load it again and see how my card's working is affected by the changes.Basically the following commands ./scripts/driver-select ath5k make sudo make install sudo make un

[ath5k-devel] Old PCI cards with AR5212 Chipset

2010-03-29 Thread Raptor Victor
HI Folks I am in need of some old PCI cards which contain AR5212 chipsets and the cards these days dont come with them anymore. If You have an old PCI card which has this particular chipset and You dont happen to use it often, then i am willing to buy it. I will prefer someone residing in Europe