Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-11 Thread Dmytro Milinevskyy
29 PM, Johannes Berg wrote: > On Fri, 2010-06-11 at 23:26 +0300, Dmytro Milinevskyy wrote: >> Generic LED class is not disabled so it's possible to control leds in sysfs. > > But if you turn off ATH5K_LEDS?? > > johannes > > ___

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-11 Thread Dmytro Milinevskyy
Generic LED class is not disabled so it's possible to control leds in sysfs. -- Dima On Fri, Jun 11, 2010 at 11:09 PM, Johannes Berg wrote: > On Wed, 2010-06-09 at 17:43 +0300, Dmytro Milinevskyy wrote: >> Hi, Bob. >> >> For instance I don't use 802.11 l

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-11 Thread Dmytro Milinevskyy
I didn't know. Thank you for noting that. However I think it's better to give a chance to disable 802.11 leds. -- Dima On Fri, Jun 11, 2010 at 8:07 PM, Bob Copeland wrote: > On Wed, Jun 9, 2010 at 10:43 AM, Dmytro Milinevskyy > wrote: >> Hi, Bob. >> >> Fo

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-09 Thread Dmytro Milinevskyy
Hi, Bob. For instance I don't use 802.11 leds layer and trigger leds from userspace according to my purposes. -- Dima On Wed, Jun 9, 2010 at 4:58 PM, Bob Copeland wrote: > On Wed, Jun 9, 2010 at 3:31 AM, Dmytro Milinevskyy > wrote: >> However if the leds support was ena

[ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-09 Thread Dmytro Milinevskyy
: - Use bool directive in Kconfig for switching LEDs support - Move ath5k_hw_set_ledstate into led.c and change its semantic to align with other leds routines Regards, --Dima Signed-off-by: Dmytro Milinevskyy --- drivers/net/wireless/ath/ath5k/Kconfig | 12 +-- drivers/net/wireless/ath

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-07 Thread Dmytro Milinevskyy
Jun 4, 2010 at 7:22 PM, Pavel Roskin wrote: > On Fri, 2010-06-04 at 16:43 +0300, Dmytro Milinevskyy wrote: >> Hi! >> >> Here is the patch to disable ath5k leds support on build stage. >> However if the leds support was enabled do not force selection of 802.11 >> leds l

[ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-04 Thread Dmytro Milinevskyy
Hi! Here is the patch to disable ath5k leds support on build stage. However if the leds support was enabled do not force selection of 802.11 leds layer. Depency on LEDS_CLASS is kept. Suggestion given by Pavel Roskin and Bob Copeland applied. Regards, --Dima --- drivers/net/wireless/ath/ath5

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-01 Thread Dmytro Milinevskyy
m keeping it around. I suppose this should go away with another patch to keep current clean. These dfinitions are not related to the subject. Regards, -- Dima On Tue, Jun 1, 2010 at 11:34 PM, Bob Copeland wrote: > On Wed, Apr 7, 2010 at 2:58 PM, Dmytro Milinevskyy > wrote: >> He

[ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-01 Thread Dmytro Milinevskyy
Hello! Here is the patch to disable ath5k leds support on build stage. However if the leds support was enabled do not force selection of 802.11 leds layer. I've applied suggestion given by Pavel Roskin. Best regards, --Dima --- drivers/net/wireless/ath/ath5k/Kconfig | 10 +++--- drive

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-05-13 Thread Dmytro Milinevskyy
rspace. -- Dima Milinevskyy On Wed, May 12, 2010 at 6:48 PM, Pavel Roskin wrote: > On Wed, 2010-04-07 at 21:58 +0300, Dmytro Milinevskyy wrote: > >> Here is the patch to disable ath5k leds support on build stage. >> However if the leds support was enabled do not force selection

[ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-05-11 Thread Dmytro Milinevskyy
Hello! Here is the patch to disable ath5k leds support on build stage. However if the leds support was enabled do not force selection of 802.11 leds layer. --- drivers/net/wireless/ath/ath5k/Kconfig | 10 +++--- drivers/net/wireless/ath/ath5k/Makefile |2 +- drivers/net/wireless/ath/