Re: [ath5k-devel] [PATCH 2/2] ath5k: capture CCK and OFDM restarts

2014-06-13 Thread Felix Fietkau
On 2014-06-13 23:41, Mathy Vanhoef wrote: > Hi all, > > This patch allows users to see CCK and OFDM restarts when FIF_FCSFAIL is set. > Without this patch only the stronger frame (causing the restart) would be > visible. > > The patch has been tested using our reactive jammer. The prefix of the w

Re: [ath5k-devel] [PATCH v2] ath5k: make use of the new rate control API

2013-06-07 Thread Felix Fietkau
On 2013-06-07 10:25 AM, Thomas Huehn wrote: > This patch enabels ath5k to use the new rate table to lookup each > mrr rate and retry information per packet. > > Signed-off-by: Benjamin Vahl > Signed-off-by: Thomas Huehn > --- > drivers/net/wireless/ath/ath5k/base.c | 77 > +++

Re: [ath5k-devel] [PATCH] ath5k: make use of the new rate control API

2013-06-06 Thread Felix Fietkau
On 2013-06-06 11:04 AM, Thomas Huehn wrote: > This patch enabels ath5k to use the new rate table to lookup each > mrr rate and retry information per packet. > > Signed-off-by: Benjamin Vahl > Signed-off-by: Thomas Huehn This patch is missing changes in the tx status path. At tx completion, info-

[ath5k-devel] [PATCH] ath5k: fix tx path skb leaks

2012-12-10 Thread Felix Fietkau
ieee80211_free_txskb() needs to be used instead of dev_kfree_skb_any for tx packets passed to the driver from mac80211 Signed-off-by: Felix Fietkau Cc: sta...@vger.kernel.org --- drivers/net/wireless/ath/ath5k/base.c | 4 ++-- drivers/net/wireless/ath/ath5k/mac80211-ops.c | 2 +- 2

Re: [ath5k-devel] [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes

2012-07-26 Thread Felix Fietkau
On 2012-07-26 12:31 PM, Nick Kossifidis wrote: > 2012/7/26 Felix Fietkau : >> On 2012-07-26 12:20 PM, Nick Kossifidis wrote: >>> 2012/7/26 Thomas Huehn : >>>> Hi Nick, >>>> >>>> Nick Kossifidis schrieb: >>>> >>>>>

Re: [ath5k-devel] [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes

2012-07-26 Thread Felix Fietkau
On 2012-07-26 12:20 PM, Nick Kossifidis wrote: > 2012/7/26 Thomas Huehn : >> Hi Nick, >> >> Nick Kossifidis schrieb: >> >>> 2012/7/26 Thomas Huehn : >> >>> There is nothing in your patch that suggests that's related to this. >>> Anyway there's a simple way to fix this: >>> >>> Just move this: >>> >

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Felix Fietkau
On 2012-07-25 8:42 PM, Nick Kossifidis wrote: > 2012/7/23 Thomas Huehn : >> This patch reduces the per rate target power eeprom reads for >> AR5K_EEPROM_MODE_11A from 10 to 8, as there are only 8 valid >> power curve entries on the eeprom. The former 10 reads lead to >> wrong per rate power limits

[ath5k-devel] [PATCH] ath5k: fix txop limit handling

2012-07-16 Thread Felix Fietkau
Same as the recent ath9k fix Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/mac80211-ops.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/mac80211-ops.c b/drivers/net/wireless/ath/ath5k/mac80211-ops.c index 22b80af

Re: [ath5k-devel] [ath9k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-14 Thread Felix Fietkau
On 2012-07-14 12:10 PM, Arend van Spriel wrote: > On 07/13/2012 08:52 PM, Thomas Huehn wrote: >> The pointer control.sta is removed from ieee80211_tx_info to free up >> sufficient >> memory in SKB_CB on the tx-path to enable new annotations per data packet >> e.g. >> support of upcoming Transmit

Re: [ath5k-devel] [PATCH v3] ath5k: add possible wiphy interface combinations

2012-05-24 Thread Felix Fietkau
On 2012-04-17 2:39 AM, Felix Fietkau wrote: > Signed-off-by: Felix Fietkau John, please merge this into 3.5, otherwise people will be unable to use multiple interfaces with ath5k anymore because of the commit "cfg80211: enforce lack of interface combinations&q

[ath5k-devel] [PATCH v3] ath5k: add possible wiphy interface combinations

2012-04-16 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 3007bba..ad549d2 100644 --- a/drivers/net

Re: [ath5k-devel] [PATCH] ath5k: add possible wiphy interface combinations

2012-04-16 Thread Felix Fietkau
On 2012-04-16 6:02 PM, Ben Greear wrote: > On 04/16/2012 08:28 AM, Felix Fietkau wrote: >> Signed-off-by: Felix Fietkau >> --- >> drivers/net/wireless/ath/ath5k/base.c | 16 >> 1 files changed, 16 insertions(+), 0 deletions(-) >> >> diff

[ath5k-devel] [PATCH v2] ath5k: add possible wiphy interface combinations

2012-04-16 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 3007bba..d4f410e 100644 --- a/drivers/net/wireless

[ath5k-devel] [PATCH] ath5k: add possible wiphy interface combinations

2012-04-16 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 3007bba..2e385f5 100644 --- a/drivers/net/wireless

Re: [ath5k-devel] ath5k disassociates when physical carrier sensing is disabled

2012-02-28 Thread Felix Fietkau
On 2012-02-28 3:01 AM, srinivas prasad wrote: > hi, > I am using voyage linux(3.0.0-voyage kernel) for my work. All my > wireless cards are atheros cards(Atheros Communications Inc. Atheros > AR5001X+ Wireless Network Adapter (rev 01)) and I am using ath5k driver. > I incorporated the following cha

Re: [ath5k-devel] ath5k phy0: gain calibration timeout

2012-02-27 Thread Felix Fietkau
On 2012-02-27 4:12 AM, David Fries wrote: > Wireless network stopped working after 22 hours with ath5k, I have the > following message repeating, suspending to ram and back was enough to > get it talking again. > ath5k phy0: gain calibration timeout (2462MHz) > > I previously was running 3.2-rc5 f

Re: [ath5k-devel] [PATCH 06/13] ath5k: Use usleep_range where possible

2011-11-20 Thread Felix Fietkau
On 2011-11-20 8:56 AM, Nick Kossifidis wrote: > Use usleep_range where possible to reduce busy waits > > Signed-off-by: Nick Kossifidis > --- > drivers/net/wireless/ath/ath5k/attach.c |2 +- > drivers/net/wireless/ath/ath5k/pci.c|2 +- > drivers/net/wireless/ath/ath5k/phy.c| 22

[ath5k-devel] [PATCH v3 5/8] ath5k: delay full calibration after reset

2011-07-11 Thread Felix Fietkau
During scans the full calibration usually does not make much sense, PAPD probing and IQ calibration should be deferred until there is enough time to complete them. Adding 100 ms to the initial full calibration delay should be enough to do this. Signed-off-by: Felix Fietkau Acked-by: Nick

[ath5k-devel] [PATCH v3 4/8] ath5k: initialize common->clockrate

2011-07-11 Thread Felix Fietkau
Fixes a division by zero when setting distance before activating the device for the first time. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/base.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH v3 6/8] ath5k: fix reference clock usec duration setting restore

2011-07-11 Thread Felix Fietkau
enabling the sleep clock alters the AR5K_USEC_32 field, but disabling it didn't restore it. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/reset.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/driver

[ath5k-devel] [PATCH v3 7/8] ath5k: disable 32KHz sleep clock operation by default

2011-07-11 Thread Felix Fietkau
, so it makes sense to leave it disabled in ath5k as well. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/ath5k.h |2 ++ drivers/net/wireless/ath/ath5k/debug.c |3 +++ drivers/net/wireless/ath/ath5k/reset.c | 11 --- 3 files changed, 13

[ath5k-devel] [PATCH v3 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211

2011-07-11 Thread Felix Fietkau
Instead of using ieee80211_stop_queue, check the configured tx queue limit before calling ieee80211_get_buffered_bc. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH v3 1/8] ath5k: add missing checks for rfgain probe

2011-07-11 Thread Felix Fietkau
rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH v3 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413

2011-07-11 Thread Felix Fietkau
AR2413 uses the same reference clock as AR5413 Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index acf73a0..dd2b417

[ath5k-devel] [PATCH v3 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2

2011-07-11 Thread Felix Fietkau
Might fix some stability issues on newer chips Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/phy.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net

Re: [ath5k-devel] [PATCH v2 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
On 2011-07-05 11:46 AM, Nick Kossifidis wrote: > 2011/7/5 Felix Fietkau: >> rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. >> >> Signed-off-by: Felix Fietkau >> --- >>drivers/net/wireless/ath/ath5k/phy.c | 10 ++ >>

[ath5k-devel] [PATCH v2 7/8] ath5k: disable 32KHz sleep clock operation by default

2011-07-04 Thread Felix Fietkau
, so it makes sense to leave it disabled in ath5k as well. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h |2 ++ drivers/net/wireless/ath/ath5k/debug.c |3 +++ drivers/net/wireless/ath/ath5k/reset.c | 11 --- 3 files changed, 13 insertions(+), 3 deletions

[ath5k-devel] [PATCH v2 6/8] ath5k: fix reference clock usec duration setting restore

2011-07-04 Thread Felix Fietkau
enabling the sleep clock alters the AR5K_USEC_32 field, but disabling it didn't restore it. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/reset.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/driver

[ath5k-devel] [PATCH v2 5/8] ath5k: delay full calibration after reset

2011-07-04 Thread Felix Fietkau
During scans the full calibration usually does not make much sense, PAPD probing and IQ calibration should be deferred until there is enough time to complete them. Adding 100 ms to the initial full calibration delay should be enough to do this. Signed-off-by: Felix Fietkau Acked-by: Nick

[ath5k-devel] [PATCH v2 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211

2011-07-04 Thread Felix Fietkau
Instead of using ieee80211_stop_queue, check the configured tx queue limit before calling ieee80211_get_buffered_bc. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH v2 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Felix Fietkau
Fixes a division by zero when setting distance before activating the device for the first time. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/base.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH v2 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413

2011-07-04 Thread Felix Fietkau
AR2413 uses the same reference clock as AR5413 Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index a28ef9e..b6085d0

[ath5k-devel] [PATCH v2 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2

2011-07-04 Thread Felix Fietkau
Might fix some stability issues on newer chips Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/phy.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net

[ath5k-devel] [PATCH v2 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k

Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Felix Fietkau
On 2011-07-04 5:40 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> Fixes a division by zero when setting distance before activating the >> device for the first time. >> >> Signed-off-by: Felix Fietkau >> --- >>drivers/net/wireless/ath/ath5k/b

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Felix Fietkau
On 2011-07-04 4:58 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> While 32 KHz sleep clock might provide some power saving benefits, >> it is also a major source of stability issues, on OpenWrt it produced >> some reproducible data bus errors on registe

Re: [ath5k-devel] [PATCH 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
On 2011-07-04 4:48 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> rfgain probe is only necessary for OFDM operation on AR5112 and no other >> radio chips >> > > It's also available on RF5111 (with AR5211 or AR5212)... Oh, right, misse

[ath5k-devel] [PATCH 6/8] ath5k: fix reference clock usec duration setting restore

2011-07-03 Thread Felix Fietkau
enabling the sleep clock alters the AR5K_USEC_32 field, but disabling it didn't restore it. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/reset.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset

[ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-03 Thread Felix Fietkau
, so it makes sense to leave it disabled in ath5k as well. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/reset.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c index

[ath5k-devel] [PATCH 1/8] ath5k: add missing checks for rfgain probe

2011-07-03 Thread Felix Fietkau
rfgain probe is only necessary for OFDM operation on AR5112 and no other radio chips Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net

[ath5k-devel] [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413

2011-07-03 Thread Felix Fietkau
AR2413 uses the same reference clock as AR5413 Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index f66124a..c65c33a

[ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2

2011-07-03 Thread Felix Fietkau
Might fix some stability issues on newer chips Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index

[ath5k-devel] [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211

2011-07-03 Thread Felix Fietkau
Instead of using ieee80211_stop_queue, check the configured tx queue limit before calling ieee80211_get_buffered_bc. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset

2011-07-03 Thread Felix Fietkau
During scans the full calibration usually does not make much sense, PAPD probing and IQ calibration should be deferred until there is enough time to complete them. Adding 100 ms to the initial full calibration delay should be enough to do this. Signed-off-by: Felix Fietkau --- drivers/net

[ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011-07-03 Thread Felix Fietkau
Fixes a division by zero when setting distance before activating the device for the first time. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net

Re: [ath5k-devel] Performance regression between Madwifi/net80211 and ath5k/mac80211

2011-06-26 Thread Felix Fietkau
On 2011-06-22 5:07 PM, Joerg Pommnitz wrote: >> I guess you'll need more help from the HW people here. > > Bob, Bruno, Felix, Luis, Nick: Do you read? What mac80211/ath5k version did you use? If you're using the in-kernel ath5k from 2.6.38, then I'd suggest testing with a recent compat-wireless

Re: [ath5k-devel] ath5k regression associating with APs in 2.6.38

2011-05-31 Thread Felix Fietkau
On 2011-05-17 7:14 PM, Nick Kossifidis wrote: > 2011/5/17 Seth Forshee: >> On Mon, May 09, 2011 at 09:02:30AM +0200, Seth Forshee wrote: >>> On Thu, May 05, 2011 at 05:30:42PM +0300, Nick Kossifidis wrote: >>> > Hmm I don't see any errors from reset/phy code, can you disable >>> > Network Man

Re: [ath5k-devel] kernel panic on MIPS + ath5k + Wistron CM9 radio

2011-05-04 Thread Felix Fietkau
On 2011-05-04 4:39 PM, Russell Senior wrote: >> "Russell" == Russell Senior writes: > > Russell> Recently trying to abandon madwifi for good on some embedded > Russell> devices with OpenWrt, encountered kernel panics. Same radio > Russell> on an x86 platform (Soekris net4826), no kernel p

Re: [ath5k-devel] kernel panic on MIPS + ath5k + Wistron CM9 radio

2011-05-03 Thread Felix Fietkau
On 2011-05-03 8:18 AM, Adrian Chadd wrote: > Well, I see the same on FreeBSD/MIPS whenever an Atheros device is > fondled incorrectly. Either because the chip isn't yet fully awake or > the register plainly doesn't exist. > > See if you can add some debugging in ath5k_hw_reset_tx_queue() to see > w

[ath5k-devel] [PATCH 2/5] ath: unshare struct ath_bus_ops between ath5k and ath9k

2011-04-13 Thread Felix Fietkau
This struct is not used in any common code, and moving it out of the ath header makes it easier to add more driver specific ops. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath.h |9 + drivers/net/wireless/ath/ath5k/ath5k.h |6 ++ drivers/net/wireless

[ath5k-devel] [PATCH 5/5] ath5k: disable 5 GHz support for the dualband PHY chip on dual-radio AR5312

2011-04-13 Thread Felix Fietkau
PHY. Disable 2.4 GHz for the first MAC on an AR5312, but only if the board configuration indicates a dual-radio device. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ahb.c| 10 ++ drivers/net/wireless/ath/ath5k/attach.c |5 + drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH 3/5] ath5k: add a new bus op for reading the mac address

2011-04-13 Thread Felix Fietkau
On AHB, the calibration data usually does not contain a valid MAC address, the correct MAC address is stored in the board config. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ahb.c| 18 + drivers/net/wireless/ath/ath5k/ath5k.h |2 +- drivers/net

[ath5k-devel] [PATCH 1/5] ath5k: disable 5 GHz support if a 2.4 GHz radio is detected

2011-04-13 Thread Felix Fietkau
On a dual-radio dual-band AR5312 device, the calibration data is shared between the 5 GHz and the 2.4 GHz radio/MAC. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/caps.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH 4/5] ath5k: fix the EEPROM check for hw AES crypto support

2011-04-13 Thread Felix Fietkau
EEPROM version 5.0 adds a new field for disabling AES support, having an older version means that AES is present. This patch fixes hw AES crypto support on AR5312 boards, which have an older EEPROM version. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/attach.c |2 +- 1

Re: [ath5k-devel] [PATCH 5/7] ath5k: remove ts_retry from ath5k_tx_status

2011-04-12 Thread Felix Fietkau
On 2011-04-12 9:04 AM, 海藻敬之 wrote: > Hi, > > Isn't there any chance in which info->status.rates[x].count has >different retry-count value from the one which the firmware actually did. > >For example, driver requests invalid value of retry count and firmware > rejects it (take other value).

[ath5k-devel] [PATCH v2 1/7] ath5k: optimize tx descriptor setup

2011-04-12 Thread Felix Fietkau
Use local variables to reduce the number of load/store operations on uncached memory. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/desc.c | 45 +++-- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH v2 1/7] ath5k: optimize tx descriptor setup

2011-04-12 Thread Felix Fietkau
Use local variables to reduce the number of load/store operations on uncached memory. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/desc.c | 45 +++-- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k

Re: [ath5k-devel] [PATCH 1/7] ath5k: optimize tx descriptor setup

2011-04-12 Thread Felix Fietkau
On 2011-04-11 8:29 AM, Kalle Valo wrote: > Felix Fietkau writes: > >> Use local variables to reduce the number of load/store operations on >> uncached >> memory. > > A comment in the code would be nice as well. Otherwise later on > someone decides to "op

[ath5k-devel] [PATCH 4/7] ath5k: optimize rx status processing

2011-04-10 Thread Felix Fietkau
Use ACCESS_ONCE to reduce the number of redundant loads on uncached memory Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/desc.c | 41 ++-- 1 files changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/desc.c b

[ath5k-devel] [PATCH 5/7] ath5k: remove ts_retry from ath5k_tx_status

2011-04-10 Thread Felix Fietkau
Reusing the configured retry counts from the skb cb is more efficient than reloading the data from uncached memory. Replace ts_longretry (unused) with ts_final_retry which contains the retry count for the final rate only Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h

[ath5k-devel] [PATCH 3/7] ath5k: optimize tx status processing

2011-04-10 Thread Felix Fietkau
Use ACCESS_ONCE to reduce the number of variable reloads on uncached memory Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/desc.c | 37 ++-- 1 files changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/desc.c b

[ath5k-devel] [PATCH 6/7] ath5k: clean up debugfs code

2011-04-10 Thread Felix Fietkau
The pointers to the debugfs entries do not need to be saved, because they will be recursively removed when the wiphy is unregistered. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |1 - drivers/net/wireless/ath/ath5k/debug.c | 65

[ath5k-devel] [PATCH 2/7] ath5k: remove ts_rate from ath5k_tx_status

2011-04-10 Thread Felix Fietkau
It is no longer necessary for preparing mac80211 tx status Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h |1 - drivers/net/wireless/ath/ath5k/desc.c | 13 - 2 files changed, 0 insertions(+), 14 deletions(-) diff --git a/drivers/net/wireless/ath

[ath5k-devel] [PATCH 1/7] ath5k: optimize tx descriptor setup

2011-04-10 Thread Felix Fietkau
Use local variables to reduce the number of load/store operations on uncached memory. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/desc.c | 38 +--- 1 files changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH 7/7] ath5k: reduce interrupt load caused by rx/tx interrupts

2011-04-10 Thread Felix Fietkau
While the rx/tx tasklet is pending, new unnecessary interrupts may arrive. Decrease the load by temporarily disabling the interrupts until the tasklet has completed. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h | 13 + drivers/net/wireless/ath/ath5k/base.c

[ath5k-devel] [PATCH 3/3] ath5k: fix slot time handling

2011-04-09 Thread Felix Fietkau
Set the slot time based on the mac80211 short slot vs long slot setting instead of just forcing long slot for all CCK-enabled channels. This slightly improves 802.11g mode performance in in my tests. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h|1

[ath5k-devel] [PATCH 1/3] ath5k: fix short preamble rate duration value

2011-04-09 Thread Felix Fietkau
Subtract the difference in preamble duration (in usec) from the value returned by ieee80211_generic_frame_duration. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h |2 +- drivers/net/wireless/ath/ath5k/pcu.c | 31 --- drivers/net

[ath5k-devel] [PATCH 2/3] ath5k: fix SIFS time handling

2011-04-09 Thread Felix Fietkau
writing the SIFS register. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/ath5k.h |3 +-- drivers/net/wireless/ath/ath5k/qcu.c |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH] ath5k: fix tx status reporting issues

2011-04-09 Thread Felix Fietkau
211 tx status will still have the original rate index which was used to set up the descriptor. Additionally, one more inaccuracy was fixed - the final rate attempt count only needs to be increased by one if the transmission attempt was successful. Signed-off-by: Felix Fietkau --- drivers/net/wirele

Re: [ath5k-devel] Atheros AR2315 WiSOC Support?

2010-10-19 Thread Felix Fietkau
On 2010-10-19 9:14 AM, Hugh Davenport wrote: > On 19/10/10 11:21, Jonathan Lassoff wrote: >> Greetings ath5k hackers! > > Hey, > >> Has anyone experimented with this device? Searching has revealed a >> thread on this list from about a year ago about the same thi

Re: [ath5k-devel] Atheros AR2315 WiSOC Support?

2010-10-18 Thread Felix Fietkau
On 2010-10-19 12:39 AM, Jonathan Lassoff wrote: > On Mon, Oct 18, 2010 at 3:31 PM, Felix Fietkau wrote: >> I did some work on WiSoC support a long time ago. Ported over large >> parts, but did not have the time to finish my work. >> Here are my patches: http://nbd.name

Re: [ath5k-devel] Atheros AR2315 WiSOC Support?

2010-10-18 Thread Felix Fietkau
't seem to > support this chip as 802.11 hardware. A recent MadWifi tree seems to > support the hardware just fine. > > Has anyone experimented with this device? Searching has revealed a > thread on this list from about a year ago about the same thing. Felix > Fietkau mention

Re: [ath5k-devel] [PATCH 5/5] ath5k: Add busy ratios to survey data

2010-10-05 Thread Felix Fietkau
On 2010-10-06 4:25 AM, Bruno Randolf wrote: > On Wed October 6 2010 07:38:34 Luis R. Rodriguez wrote: >> This is all being sucked out of common, so can we just share the >> filler for the survey between ath5k and ath9k? Note we should split up >> hw code and core driver code on the ath module by f

Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration

2010-05-21 Thread Felix Fietkau
On 2010-05-21 7:11 PM, Luis R. Rodriguez wrote: > On Thu, May 20, 2010 at 06:59:33PM -0700, Bruno Randolf wrote: >> so from my point of view this is not very different from what we can support >> with the API i suggested. for RX it seems to be 100% equivalent. > > Well I agree, the API *supports

Re: [ath5k-devel] [ath9k-devel] Significiant performance differences between ath5k and ath9k in 802.11a

2010-01-29 Thread Felix Fietkau
On 2010-01-29 9:10 AM, Joerg Pommnitz wrote: > --- rootki...@yahoo.it wrote: > >> >> Can you try in AP-client mode? I think you'll get more >> throughput so. >> > > No, IBSS is what I'm interested in. And the point is, that there is > a 30% performance difference between ath5k (and Madwifi) an

Re: [ath5k-devel] [PATCH 1/5] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-15 Thread Felix Fietkau
On 2009-12-15 10:58 PM, Luis R. Rodriguez wrote: > On Tue, Dec 15, 2009 at 12:56:42PM -0800, Lukáš Turek wrote: >> On 15.12.2009 20:00 you wrote: >> > Does setting the coverage class make sense for all modes of operation? >> > If not it'd be good to catch those early and avoid setting them and also

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-09 Thread Felix Fietkau
On 2009-12-09 2:12 PM, Lukáš Turek wrote: >> Some hardware internally calculates the ACK timeout based on the >> configured slot time. Broadcom does it this way. >> Maybe adjusting the ACK timeout without adjusting the slot time works, >> but it'll probably interfere with CSMA. > Ahteros is not Bro

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-08 Thread Felix Fietkau
On 2009-12-09 2:15 AM, Lukáš Turek wrote: > On 7.12.2009 10:48 you wrote: >> ACKTimeout is: aSIFSTime + aSlotTime + aPHY-RX-START-Delay > 802.11a uses SIFS of 16 µs and 9 µs slot time, that's 25 µs in total. > However, > the athctrl calculation uses 21 µs ACK timeout for zero distance. And I kno

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-07 Thread Felix Fietkau
Lukáš Turek wrote: > On 6.12.2009 20:20 Felix Fietkau wrote: >> In 2.4 GHz, regular slot time is 20 usec, unless short slot is enabled. >> 2.4 GHz with short slot and 5 GHz both use 9 usec. > Yes, but where the short slot time gets enabled? According to the standard > (don

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Felix Fietkau
Lukáš Turek wrote: > On 6.12.2009 19:34 Felix Fietkau wrote: >> This part is wrong. The slot time can be either short or long, based on >> configuration and PHY type. > I did some test, and the value returned by ath5k_hw_get_slot_time was always > 9, even when connected

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Felix Fietkau
Lukáš Turek wrote: > The callback sets slot time as specified in IEEE 802.11-2007 section > 17.3.8.6 (for 20MHz channels only for now) and ACK and CTS timeouts > using calculations taken from Madwifi's athctrl. The values are > persistent, they are restored after device reset. > > Signed-off-by: L

Re: [ath5k-devel] ACK timeout

2009-11-22 Thread Felix Fietkau
Luis R. Rodriguez wrote: > On Sat, Nov 21, 2009 at 2:14 PM, Lukáš Turek <8...@praha12.net> wrote: >> Hi, >> >> it seems Ath5k is missing a Madwifi feature that is essential for our >> long-distance links: setting ACK timeout value based on the link distance. >> >> I found a function ath5k_hw_set_ac

Re: [ath5k-devel] ath_info for WiSoC devices

2009-11-13 Thread Felix Fietkau
Gus Wirth wrote: > On 11/13/2009 03:59 PM, Pavel Roskin wrote: >> On Fri, 2009-11-13 at 15:26 -0800, Gus Wirth wrote: >> >>> # ath_info 0xb000 >>> >>> And it promptly reboots. >>> >>> So at this point I'm not sure if the problem is in the madwifi_multi or >>> if this won't work with a WiSoC typ

Re: [ath5k-devel] AR2315/AR2317 chip support

2009-10-13 Thread Felix Fietkau
Tomáš Dulík wrote: > Hello Gus, > we've had measured TX parameters of the Ubiquity Bullet2 on a vector > WLAN signal analyzer and it had one of the best overall results from all > the other devices we were able to find. > We have some of these devices in our network so we would be interested > i

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes()

2009-08-28 Thread Felix Fietkau
John W. Linville wrote: > I think I am on the side of removing the non-standard extensions. > FWIW, I'll need a patch posted with a proper Subject and > Signed-off-by... > > I think Nick has some valid points. His position sounds similar to > that expressed to me by Felix and some others that it

Re: [ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

2009-07-04 Thread Felix Fietkau
Bob Copeland wrote: > Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets" > introduced a regression into 2.6.28 where the PCU registers are never > initialized, due to ath5k_reset() always passing true for change_channel. > We subsequently program a lot of these registers but sev

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-01-31 Thread Felix Fietkau
Nick Kossifidis wrote: > 2009/2/1 Felix Fietkau : >> Nick Kossifidis wrote: >>> 2009/2/1 Bob Copeland : >>>> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote: >>>>> > Heh, we should write a little tool to check the shifts and mask

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-01-31 Thread Felix Fietkau
Nick Kossifidis wrote: > 2009/2/1 Bob Copeland : >> On Sat, Jan 31, 2009 at 08:48:02PM +0200, Nick Kossifidis wrote: >>> > Heh, we should write a little tool to check the shifts and masks :) >>> > >>> >>> Yup :P >> >> I just wrote one, I can post it later :) It also found: >> >> AR5K_PHY_SIGMA_DE

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-01-31 Thread Felix Fietkau
Nick Kossifidis wrote: >>> My intention is to reimplement hw_htoclock to account for half/quarter >>> rate so it'll soon be >>> clock = ath5k_hw_htoclock(1, channel->hw_value); >> AFAIK Sam's HAL might have a bug there. If I remember correctly, the MAC >> runs at the same clock speed with Half/Quar

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-01-31 Thread Felix Fietkau
Nick Kossifidis wrote: >>> [...] >>> @@ -2156,7 +2157,8 @@ >>> #define AR5K_PHY_ANT_CTL_TXRX_EN0x0001 /* Enable >>> TX/RX (?) */ >>> #define AR5K_PHY_ANT_CTL_SECTORED_ANT 0x0004 /* Sectored >>> Antenna */ >>> #define AR5K_PHY_ANT_CTL_HITUNE50x

Re: [ath5k-devel] [PATCH 1/5] ath5k: PHY code cleanup

2009-01-30 Thread Felix Fietkau
: Nick Kossifidis For the whole series: Acked-by: Felix Fietkau Nick: Do you want me to rebase my 2413 RF changes on top of this series? Another thing: could you please test if my stuff also works on RF2425? I don't have such a card. Thanks, - Felix

Re: [ath5k-devel] [PATCH] ath5k: Update EEPROM code

2008-12-21 Thread Felix Fietkau
th_info (i wrote some > debug code > on debug.c to print everything like ath_info but i haven't tested it yet on > 5111 and it's > full of > 80 col lines, if anyone wants to play with it let me know). > > Signed-Off-by: Nick Kossifidis Acked-by: Felix Fietkau

Re: [ath5k-devel] Unusually low speeds with ath5k and iwl3945

2008-11-25 Thread Felix Fietkau
Benoit PAPILLAULT wrote: > Felix Fietkau a écrit : >> While reading the code for calculating the frame duration, i noticed >> something odd: It doesn't seem to be taking into account the short >> vs long preamble distinction for ERP rates. IMHO this might be causing >

Re: [ath5k-devel] Unusually low speeds with ath5k and iwl3945

2008-11-24 Thread Felix Fietkau
Benoit PAPILLAULT wrote: > I did a similar test here and results is very strange. AP was my good > old linksys WRT54G running an iperf server. Client was a laptop running > either ath5k or madwifi/trunk and an iperf client. Channel is 5. Both > drivers show the same behaviour. > > At the beginning

Re: [ath5k-devel] AR5513 radio with AR5112 / AR2112

2008-10-16 Thread Felix Fietkau
Luis R. Rodriguez wrote: > http://support.dlink.com/products/view.asp?productid=DWL-G520M > > AR5513 is dual band 5 GHZ/2.4 GHZ radio. This seems to come with > AR5112 or AR2112 which I think are the MACs. Not sure if we support > these yet, will have to check in ath5k. We also released our legacy

[ath5k-devel] [PATCH 5/5] ath9k: fix DMA descriptor access on big-endian

2008-07-20 Thread Felix Fietkau
Remove the descriptor swap, as the driver already configures the hardware for descriptor swapping on big endian systems Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/core.c +++ b/drivers/net/wireless/ath9k/core.c @@ -2141,22 +2141,6 @@ memz

[ath5k-devel] [PATCH 4/5] ath9k: fix return code check

2008-07-20 Thread Felix Fietkau
Fix a return code check for ath9k_hw_nvram_read, this function returns AH_TRUE when the call succeeded Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/hw.c +++ b/drivers/net/wireless/ath9k/hw.c @@ -803,7 +803,7 @@ u_int16_t magic,

[ath5k-devel] [PATCH 3/5] ath9k: add missing device ID for AR9160 MiniPCI cards

2008-07-20 Thread Felix Fietkau
Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/hw.c +++ b/drivers/net/wireless/ath9k/hw.c @@ -8329,6 +8329,8 @@ case AR5416_DEVID_PCI: case AR5416_DEVID_PCIE: return "Atheros 5416"; + case

[ath5k-devel] [PATCH 2/5] ath9k: add missing include statements

2008-07-20 Thread Felix Fietkau
Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/regd.c +++ b/drivers/net/wireless/ath9k/regd.c @@ -14,6 +14,8 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ +#include +#include #include "ath9k.h"

[ath5k-devel] [PATCH 1/5] ath9k: fix bad udelay

2008-07-20 Thread Felix Fietkau
Replace udelay(3000) with mdelay(3), because udelay(3000) fails on some architectures, e.g. ARM Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ath9k/recv.c +++ b/drivers/net/wireless/ath9k/recv.c @@ -737,7 +737,7 @@ ath9k_hw_stoppcur

  1   2   >