Re: [ath5k-devel] Searching new home for ath[59]k-devel mailing lists

2017-01-13 Thread Kalle Valo
example from infradead.org. So feel free to close both of the lists and thanks for the heads up. Are you planning to update the MAINTAINERS file or should I? -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] ath5k: document a fall-through case in ath5k_hw_set_opmode

2015-01-23 Thread Kalle Valo
> Coverity: CID 114932 > > Signed-off-by: John W. Linville > Acked-by: Nick Kossifidis Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/li

Re: [ath5k-devel] [PATCH 11/28] net: wireless: ath: ath5k: drop owner assignment from platform_drivers

2015-01-06 Thread Kalle Valo
erge window. This series catches the bits fallen > through. The patches shall go in via the subsystem trees. Thanks, applied to wireless-drivers-next.git. But I simplified the patch title: c0c3163a7213 ath5k: drop owner assignment from platform_drivers -- Kalle Valo

Re: [ath5k-devel] [PATCH 1/5] ath: add common function ath_is_mybeacon

2014-01-16 Thread Kalle Valo
Oleksij Rempel writes: > +bool ath_is_mybeacon(struct ath_common *common, struct ieee80211_hdr *hdr) Would a static inline be better? At least on ath9k I suspect the compiler automatically inlines the static function, after your patch there's an extra function call. -- Ka

Re: [ath5k-devel] [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-08 Thread Kalle Valo
ugging facilities from user's point of view don't change. I don't care if the code is in ath10k.ko or ath.ko, we are talking about ~100 lines of code anyway. > One of the nominal benefits of separating the ath_ > macros by subsystem was perf/tracing. Nominal? -- Kalle Valo ___

Re: [ath5k-devel] [PATCH] ath5k: add support of HW encryption in management frames

2012-09-10 Thread Kalle Valo
icks up the work. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Kalle Valo
le git commit id is a good reference and I'm sure it will work even after 10 years. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH v2 1/7] ath5k: optimize tx descriptor setup

2011-04-13 Thread Kalle Valo
y fault as I was so slow to comment. But I blame the sun for this, it's so amazing to see the sun again after six months! ;) -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH 1/7] ath5k: optimize tx descriptor setup

2011-04-11 Thread Kalle Valo
gt; - memset(&desc->ud.ds_tx5212, 0, sizeof(struct ath5k_hw_5212_tx_desc)); > + memset(&desc->ud.ds_tx5212.tx_stat, 0, > +sizeof(desc->ud.ds_tx5212.tx_stat)); Is this an unrelated change? Or maybe I just missed something. -- Kalle Valo __

Re: [ath5k-devel] [ath5k] Incorrect value for ACK_TIMEOUT

2010-09-15 Thread Kalle Valo
Jonathan Guerin writes: > Any chance we can 'acquire' those test plans? ;-) Most probably you need to pay kilo dollars to get access to them. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5

Re: [ath5k-devel] [ath5k] Incorrect value for ACK_TIMEOUT

2010-09-15 Thread Kalle Valo
is sound reasonable? Yes, it does sound reasonable. You might get throughput increase by violating the spec. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [ath5k] Incorrect value for ACK_TIMEOUT

2010-09-15 Thread Kalle Valo
ts of throughput tests to test for contending the medium. So, for example, can we trust a device which has passed Wi-Fi certification? I don't know. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH 2/4] mac80211: Add new callback set_coverage

2009-12-07 Thread Kalle Valo
rage class as specified > + * in IEEE 802.11-2007 section 17.3.8.6 and modify ACK timeout > + * accordingly. Optional function, could be NULL. > + * Please document if the callback can sleep or not. Preferably the former. -- Kalle Valo __

Re: [ath5k-devel] [PATCH 1/4]: Check EEPROM before tweaking SERDES

2009-08-01 Thread Kalle Valo
I'm with Luis here. It makes a lot easier to read patches and find bugs if the patches do one thing at a time. Don't worry about the number of patches, usually that's not a problem. -- Kalle Valo ___ ath5k-devel mailing list ath5k-d

Re: [ath5k-devel] [PATCH 2/7] ath5k: Read Spur channels from EEPROM

2009-04-15 Thread Kalle Valo
in usenet 72 characters was the recommended width, right? That way quoting was also easier. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH] ath5k: Add debug code for EEPROM

2009-01-10 Thread Kalle Valo
et (r) 3.0 (2006) [wn]: ditto n 1: a mark used to indicate the word above it should be repeated [syn: {ditto mark}, {ditto}] v 1: repeat an action or statement; "The next speaker dittoed her argument" -- Kalle Valo _

Re: [ath5k-devel] [PATCH 1/2] ath5k: debug level improvements

2008-01-20 Thread Kalle Valo
bruno randolf <[EMAIL PROTECTED]> writes: > On Monday 21 January 2008 15:44:46 Kalle Valo wrote: >> > + char buf[20]; >> > + >> > + if (copy_from_user(buf, userbuf, min_t(size_t, count, 20))) >> > + return -EFAULT; >> >> Ho

Re: [ath5k-devel] [PATCH 1/2] ath5k: debug level improvements

2008-01-20 Thread Kalle Valo
= file->private_data; > + char buf[1000]; To my eyes allocating 1000 bytes from stack is too large. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] [PATCH] ath5k: consistent info and error logging

2007-11-16 Thread Kalle Valo
a inline function with va_args is not possible? I can be wrong, though. -- Kalle Valo ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel