Re: [ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-30 Thread Alan Jenkins
On 5/30/09, Johannes Berg wrote: > On Sat, 2009-05-30 at 00:33 +0200, Tobias Doerffel wrote: > >> > Could you try to work against v11 >> > of my rfkill patch, or better even against the cfg80211 rfkill instead? >> I didn't look at both of them yet. However I think we first should try to >> get >>

Re: [ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-29 Thread Johannes Berg
On Sat, 2009-05-30 at 00:33 +0200, Tobias Doerffel wrote: > > Could you try to work against v11 > > of my rfkill patch, or better even against the cfg80211 rfkill instead? > I didn't look at both of them yet. However I think we first should try to get > current rfkill support into mainline as fas

Re: [ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-29 Thread Tobias Doerffel
Hi, Am Dienstag, 26. Mai 2009 01:32:46 schrieb Johannes Berg: > On Tue, 2009-05-26 at 01:24 +0200, Tobias Doerffel wrote: > > + err = rfkill_register(sc->rf_kill.rfkill); > > + if (err) { > > + sc->rf_kill.rfkill = NULL; > > + return -1; > > + } > > Mi

[ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-25 Thread Tobias Doerffel
Hi, Am Mittwoch, 20. Mai 2009 22:29:42 schrieb Bob Copeland: > I'm definitely interested in seeing rfkill gpio support getting in, > it's overdue. So I say repost it and we can fasttrack that. Digging > up your last patchset was already on my todo list. Here we go. I attached a patch (against wi

Re: [ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-25 Thread Johannes Berg
On Tue, 2009-05-26 at 01:24 +0200, Tobias Doerffel wrote: > + err = rfkill_register(sc->rf_kill.rfkill); > + if (err) { > + sc->rf_kill.rfkill = NULL; > + return -1; > + } Missing rfkill_free, and why -EPERM? Could you try to work against v11 of my rf