Re: [ath5k-devel] [PATCH 4/4] ath5k: add hardware CCMP encyption support

2009-09-01 Thread Pavel Roskin
On Thu, 2009-08-27 at 15:17 -0400, Bob Copeland wrote: > - ah->ah_aes_support = > + ah->ah_aes_support = srev >= AR5K_SREV_AR5212_V4 && Fine with me, but please use parentheses here, just for readability: h->ah_aes_support = (srev >= AR5K_SREV_AR5212_V4) && ... Also, let's call it AR5K_S

Re: [ath5k-devel] [PATCH 4/4] ath5k: add hardware CCMP encyption support

2009-08-27 Thread Bob Copeland
Subject: [PATCH] ath5k: clarify srev comparison for CCMP check As Pavel Roskin noted, the check for mac version as copied from legacy_hal made no sense. This replaces it with the equivalent and makes up a suitable #define for the mac version legacy_hal checked. Signed-off-by: Bob Copeland ---

Re: [ath5k-devel] [PATCH 4/4] ath5k: add hardware CCMP encyption support

2009-08-26 Thread Bob Copeland
On Wed, Aug 26, 2009 at 10:09:31PM -0400, Pavel Roskin wrote: > On Mon, 2009-08-24 at 23:00 -0400, Bob Copeland wrote: > > + ah->ah_aes_support = > > + (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 && > > +!AR5K_EEPROM_AES_DIS(ee->ee_misc5) && > > +(ah->ah_mac_versi

Re: [ath5k-devel] [PATCH 4/4] ath5k: add hardware CCMP encyption support

2009-08-26 Thread Pavel Roskin
On Mon, 2009-08-24 at 23:00 -0400, Bob Copeland wrote: > + ah->ah_aes_support = > + (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 && > + !AR5K_EEPROM_AES_DIS(ee->ee_misc5) && > + (ah->ah_mac_version > (AR5K_SREV_AR5212 >> 4) || > + (ah->ah_mac_ve

[ath5k-devel] [PATCH 4/4] ath5k: add hardware CCMP encyption support

2009-08-24 Thread Bob Copeland
Recent ath5k hardware is capable of doing CCMP acceleration. Enable it for the cards that support it. Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/ath5k/ath5k.h |1 + drivers/net/wireless/ath/ath5k/attach.c | 10 ++ drivers/net/wireless/ath/ath5k/base.c |3 +++ 3