On Fri, 2012-07-13 at 08:41 -0400, Bob Copeland wrote:
> On Fri, Jul 13, 2012 at 08:19:04AM +0200, Wojciech Dubowik wrote:
> > ... or sombeody could port AR231x code from OpenWrt upstream but it's
> > maybe a waste of resources for such an old chipset.
>
> I took a look, it seems we're only missin
On 07/12/2012 10:38 PM, Bob Copeland wrote:
> On Thu, Jul 12, 2012 at 10:19:12PM +0200, Paul Bolle wrote:
>> I again stumbled on the Kconfig symbol ATHEROS_AR231X and its macro
>> CONFIG_ATHEROS_AR231X, while peeking at the tree for unrelated issues.
>> Nothing seems to have changed as of v3.5-rc6.
On Fri, Jul 13, 2012 at 08:19:04AM +0200, Wojciech Dubowik wrote:
> >-#ifndef CONFIG_ATHEROS_AR231X
> > struct pci_dev *pdev = ah->pdev;
> >-#endif
> > char name[ATH5K_LED_MAX_NAME_LEN + 1];
> > const struct pci_device_id *match;
> > if (!ah->pdev)
> > return 0;
> >-#ifd
On Thu, Jul 12, 2012 at 10:50:21PM +0200, Paul Bolle wrote:
> If this patch ever becomes fully serious we should also remove
> ATHEROS_AR231X from the sole Kconfig file that uses it.
Heh, yes, I knew I'd get called on that. I just didn't want to
think about the implications of removing it -- ath5
On Thu, Jul 12, 2012 at 10:19:12PM +0200, Paul Bolle wrote:
> I again stumbled on the Kconfig symbol ATHEROS_AR231X and its macro
> CONFIG_ATHEROS_AR231X, while peeking at the tree for unrelated issues.
> Nothing seems to have changed as of v3.5-rc6. So this symbol and this
> macro appear to be jus
On Thu, 2012-07-12 at 16:38 -0400, Bob Copeland wrote:
> Yup, and I complained about it when it went in too. Ok, how's this?
>
> From: Bob Copeland
> Date: Thu, 12 Jul 2012 16:27:27 -0400
> Subject: [PATCH] Remove code conditional on CONFIG_ATHEROS_AR231X
>
> Since the patch adding this landed
On Tue, 2011-11-08 at 09:16 -0500, Bob Copeland wrote:
> On Tue, Nov 08, 2011 at 01:41:53PM +0100, Paul Bolle wrote:
> > 0) Since commit a0b907ee ("ath5k: Add AHB bus support") the mainline
> > kernel tree uses the Kconfig symbol ATHEROS_AR231X and the preprocessor
> > macro CONFIG_ATHEROS_AR231X.
On Tue, Nov 08, 2011 at 01:41:53PM +0100, Paul Bolle wrote:
> 0) Since commit a0b907ee ("ath5k: Add AHB bus support") the mainline
> kernel tree uses the Kconfig symbol ATHEROS_AR231X and the preprocessor
> macro CONFIG_ATHEROS_AR231X.
>
> 1) But there's currently no Kconfig entry ATHEROS_AR231X.
0) Since commit a0b907ee ("ath5k: Add AHB bus support") the mainline
kernel tree uses the Kconfig symbol ATHEROS_AR231X and the preprocessor
macro CONFIG_ATHEROS_AR231X.
1) But there's currently no Kconfig entry ATHEROS_AR231X. (Neither is
there a direct definition of the macro CONFIG_ATHEROS_AR23