(warning: I have vague recollection of finding and fixing this bug
before, forgive me if this bug is known)

There seems to be some historical code that will add a note as a plain
string:

    ["Jason R." "Mastaler" nil nil nil nil ("[EMAIL PROTECTED]") "TMDA
    author" nil]

Instead of what might be more sane:

    ["Jason R." "Mastaler" nil nil nil nil ("[EMAIL PROTECTED]")
    ((notes . "TMDA author")) nil ]


For a while, I turned off timestamp and creation date stuff in bbdb,
so perhaps this is how I got the above example of a string notes
field.

Anyway, this breaks bbdb-format-record, which expects the return value
of bbbdb-record-raw-notes to always be a list.  The attached patch
fixes the problem (please forgive my childish elisp).

-- 
matt

Index: bbdb.el
===================================================================
RCS file: /cvsroot/bbdb/bbdb/lisp/bbdb.el,v
retrieving revision 1.172
diff -u -r1.172 bbdb.el
--- bbdb.el	2001/11/19 21:37:47	1.172
+++ bbdb.el	2001/12/07 20:37:37
@@ -1654,8 +1654,10 @@
          (omit-list   (bbdb-display-layout-get-option layout-spec 'omit))
          (order-list  (bbdb-display-layout-get-option layout-spec 'order))
          (all-fields  (append '(phones addresses net aka)
-                              (mapcar (lambda (r) (car r))
-                                      (bbdb-record-raw-notes record))))
+			      (let ((raw-notes (bbdb-record-raw-notes record)))
+				(if (stringp raw-notes)
+				    '(notes)
+				  (mapcar (lambda (r) (car r)) raw-notes)))))
          format-function field-list)
 
     (if (functionp omit-list)

Reply via email to