On 05/23/2013 11:36 PM, Ondrej Zajicek wrote:
> On Thu, May 23, 2013 at 07:35:29PM +0200, Matthias Schiffer wrote:
>> I think all routes should be handled the same way, without regard for
>> the source protocol.
>
> Well, this is nice idea, but BGP standard (RFC 4271
On 05/22/2013 12:36 PM, Ondrej Zajicek wrote:
> On Fri, May 17, 2013 at 04:31:07PM +0200, Matthias Schiffer wrote:
>> There is no reason to overwrite attributes like AS path, next hop, etc. when
>> the
>> route source is not BGP. Preserving them has several advantages:
>&
There is no reason to overwrite attributes like AS path, next hop, etc. when the
route source is not BGP. Preserving them has several advantages:
* no attributes are lost by using opaque pipes
* BGP attributes can by pre-populated in other protocols' import filters
As a side effect of moving co
There is no reason to overwrite attributes like AS path, next hop, etc. when the
route source is not BGP. Preserving them has several advantages:
* no attributes are lost by using opaque pipes
* BGP attributes can by pre-populated in other protocols' import filters
As a side effect of moving co
Okay, I'll fix that.
What about the neighbor.bound_iface field I introduced in my patch series?
Should
I just allocate the interface name from the same slab the neighbor node itself
is
allocated from, and free it before the neighbor is freed?
Matthias Schiffer
On 12/31/2011 02:13 PM, M
as the same bytes will be set in the interface
field for the same config. Still, it would be cleaner to zero out
bgp_config.interface
before setting it. Comments?
Thanks for looking at my patches,
Matthias Schiffer
On 12/31/2011 11:38 AM, Martin Mares wrote:
> Hello!
>
>> diff --gi
Signed-off-by: Matthias Schiffer
---
proto/bgp/bgp.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c
index 67594c7..59468c3 100644
--- a/proto/bgp/bgp.c
+++ b/proto/bgp/bgp.c
@@ -1151,6 +1151,9 @@ bgp_show_proto_info(struct proto *P
Signed-off-by: Matthias Schiffer
---
proto/bgp/bgp.c | 10 --
proto/bgp/bgp.h |1 +
proto/bgp/config.Y |4 +++-
proto/bgp/packets.c |3 +++
4 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c
index 28396a5..67594c7
Signed-off-by: Matthias Schiffer
---
nest/iface.h|2 ++
nest/neighbor.c | 34 +++---
2 files changed, 29 insertions(+), 7 deletions(-)
diff --git a/nest/iface.h b/nest/iface.h
index 7307844..8636c0a 100644
--- a/nest/iface.h
+++ b/nest/iface.h
@@ -106,6
his under
other BSDs though.
The patches have been tested under Linux and FreeBSD, with Bird
and Quagga peers, and a few different configurations.
Best regards,
Matthias Schiffer
Signed-off-by: Matthias Schiffer
---
sysdep/bsd/krt-sock.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sysdep/bsd/krt-sock.c b/sysdep/bsd/krt-sock.c
index 1647c5e..b70f166 100644
--- a/sysdep/bsd/krt-sock.c
+++ b/sysdep/bsd/krt-sock.c
@@ -544,7 +544,11
oncerning other
protocols.
Best regards,
Matthias Schiffer
From a0155e7e243e954adced3b7bca51e507077c8c3f Mon Sep 17 00:00:00 2001
Message-Id:
From: Matthias Schiffer
Date: Thu, 8 Dec 2011 01:09:26 +0100
Subject: [PATCH] Update the neighbor cache on every address addition or
removal Only updating
HOST is the
same as an invalid scope.
This bug currently blocks me fixing the problems you mentioned
concerning my link-local v6 peering patch.
Matthias Schiffer
signature.asc
Description: OpenPGP digital signature
On 12/22/2010 06:45 PM, Ondrej Zajicek wrote:
> On Sun, Dec 19, 2010 at 09:55:24AM +0100, Matthias Schiffer wrote:
>> Anyways, I'd love to see this patch included in Bird. It shouldn't make
>> any difference when you don't use the interface attribute, so it won
exactly that? Link-local addresses are broken (in BIRD)
> on non-multiaccess devices on *BSD?
>
Without that patch, on *BSD link-local addresses will be marked as
unnumbered on pointopoint interfaces, while they are in fact /64. This
breaks the is_connected() check that's called from ne
difference when you don't use the interface attribute, so it won't have
bad influence on people not using this feature, and it makes Bird an
alternative to Quagga when you need link-local peering support. :-)
Matthias Schiffer
From 993d07798e10f41c258c2a485650507c564e6990 Mon Sep 17 00:00:00
16 matches
Mail list logo
