Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Ángel González
On 12/05/13 21:50, Tim Rühsen wrote: > A real solution would be a rewrite of the init stuff (I saw that already > somewhere on the Wget 2.0 wish list or somewhere - don't remeber exactly). > > I already wrote this kind of code and would contribute it to Wget. > But i am unshure how to apply it to

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Tim Rühsen
Am Sonntag, 12. Mai 2013 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > > having an abort() without a message is simply a big waste of time for any > > developer who stumbles upon it. > > I disagree here, what is so difficult that a debugger cannot catch? On > the other hand, I agree this

Re: [Bug-wget] [PATCH] bit cleanup in utils.c

2013-05-12 Thread Giuseppe Scrivano
Hi, Tim Rühsen writes: > I replaced some hand-written string code by standard library functions. > In any case these functions may be found in gnulib as well. > From d540fd5dbd3644936a8ad1a384516abba10de268 Mon Sep 17 00:00:00 2001 > From: Tim Ruehsen > Date: Thu, 9 May 2013 19:53:36 +0200 > S

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*

2013-05-12 Thread Giuseppe Scrivano
Tim Rühsen writes: > having an abort() without a message is simply a big waste of time for any > developer who stumbles upon it. I disagree here, what is so difficult that a debugger cannot catch? On the other hand, I agree this can be improved. > Since the init code of Wget has to be rewri

Re: [Bug-wget] Bug inside the manpage

2013-05-12 Thread Giuseppe Scrivano
Darshit Shah writes: > Agreed! > The documentation should indeed read: Number of tries since that is what is > being set by the option. > > Attached a patch with the required change. > +2013-05-10 Darshit Shah (tiny change) > + > + * wget.text (No of tries): Fix typo to make it clear that

Re: [Bug-wget] http.c code cleaning

2013-05-12 Thread Giuseppe Scrivano
Hello, Dmitry Bogatov writes: > -request_set_method (req, meth, meth_arg); > +req = request_new(meth, meth_arg); I have amended this change: > +req = request_new (meth, meth_arg); and I am going to push it. Thanks for your contribution! Giuseppe