Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/3/2012 9:11 AM, Phil Race wrote: Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. Sorry about that. I thought I was jut

Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/2/2012 9:08 PM, Dmitry Samersoff wrote: Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm I don't plan to remove that myself, but jaxws will be notified and urged to remove their version. Do you have permis

Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/2/2012 7:13 PM, David Holmes wrote: Hi Jim, I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cross-compilation issues with building this? I'm assuming not but want to ch

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The official ASM distro has six JARs: core: processing classes based on Class{Reader,Writer} visitors tree: alternate API for processing classes; used in more advanced applications util: debugging utilities, such as the checking and tracing visitors commons: random contributions, some of wh

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
On 2/3/2012 9:38 AM, Brian Goetz wrote: Lambda was the proximate driving force. EE was also a contributor; as I mentioned earlier, Glassfish includes half a dozen versions of ASM, some of different vintages, because of how it is componentized. We can probably get rid of the extra repo once we

Re: Adding asm to JDK 8

2012-02-03 Thread Dmitry Samersoff
Brian, Does any body has a justification to include all of them. ASM has core and couple of interfaces around it. Subset included now to jaxp workspace is enough to do all necessary things. -Dmitry On 2012-02-03 07:34, Brian Goetz wrote: > The main ASM distribution is broken into 5 jars, based

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. But does it really need its own new repo ? I think there needs to be a discuss

Re: Request for review: hotspot/jprt.properties [S]

2012-02-03 Thread Paul Hohensee
Correct. Sustaining owns the pre-7 releases. Paul On 2/3/12 6:55 AM, Keith McGuigan wrote: On 2/2/2012 9:01 PM, David Holmes wrote: On 3/02/2012 9:56 AM, Keith McGuigan wrote: Here's a webrev for changing the default JPRT release value for hotspot to jdk8. It can still be overridden by the

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The hope there is that JAX-WS can convert over to / certify on the bundled ASM, and then we can get rid of their old copy. Same process as removing APT; they have to do some work first. On 2/3/2012 6:48 AM, Alan Bateman wrote: On 03/02/2012 05:08, Dmitry Samersoff wrote: Jim, Do you plan to

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. On 2/2/2012 10:33 PM, Mandy Chung wrote: On 2/2/2012 7:13 PM, David Holmes wrote: Okay two questions :) : do you know when this will get modul

Re: 7140918: Remove dependency on apt and com.sun.mirror API

2012-02-03 Thread Miroslav Kos
Hi Alan, do you have any update about approving the changeset? The jaxws bundle is already in place, so there should be nothing blocking us from the final step(?) We already have PIT Certificate from QA: https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=13491649 Regards Miran O

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The current plan is to use ASM long-term to generate classes at runtime. Now, it is possible that "something better will come along" (perhaps needed functionality will be provided by JSR-292 in the future) but we're not banking on this. The EE team has also asked that we officially include AS

Re: Patch to fix build breakage with GCC 4.7

2012-02-03 Thread Deepak Bhole
* David Holmes [2012-01-30 21:50]: > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 19:57]: > >>While gcc compilation on sparc is rare I'm not sure that simply > >>deleting the sparc-only option unconditionally is the right thing to > >>do. > >> > > > >I thought about t

Re: Patch to fix build breakage with GCC 4.7

2012-02-03 Thread Deepak Bhole
* David Holmes [2012-01-30 19:57]: > Hi Deepak, > > The primary change here is a build change so I've cc'ed build-dev. > > The majority of the changes are to JVMTI demo files hence I've cc'd > serviceability-dev. > > I think JDK8-dev doesn't need to be included now so I've bcc'd it. > > While

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 15:07, Brian Goetz wrote: The current plan is to use ASM long-term to generate classes at runtime. Now, it is possible that "something better will come along" (perhaps needed functionality will be provided by JSR-292 in the future) but we're not banking on this. The EE team has

Re: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD

2012-02-03 Thread Fredrik Öhrström
2012-02-03 02:43, David Holmes skrev: > Hi Erik, > > I think this has gone as far as it needs for now. My visual inspection > of these changes looks okay. > > My lingering concern is the impact on external scripts etc that may set > some of the renamed flags. Even I have a build script that sets

Re: Request for review: hotspot/jprt.properties [S]

2012-02-03 Thread Keith McGuigan
On 2/2/2012 9:01 PM, David Holmes wrote: On 3/02/2012 9:56 AM, Keith McGuigan wrote: Here's a webrev for changing the default JPRT release value for hotspot to jdk8. It can still be overridden by the -release jdk7 during JPRT submission. I also removed references to pre-7 releases and other un

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 05:08, Dmitry Samersoff wrote: Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm Do you have permission to include one particular version or plan to sync it regularly? -Dmitry This is a good point. On

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 04:04, Mandy Chung wrote: Great. That would give a good starting point. Mandy On 2/2/2012 7:34 PM, Brian Goetz wrote: The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. Brian - I