Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v12]

2021-03-10 Thread Alexey Ushakov
On Wed, 10 Mar 2021 10:51:08 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Iris Clark
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2930

RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Bradford Wetmore
Disable the "missing" target for java.smartcardio from doclint. - Commit messages: - Forgot copyright date update - 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module Changes: https://git.openjdk.java.net/jdk/pull/2930/files Webrev: https://webrevs.ope

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v8]

2021-03-10 Thread Yumin Qi
> Hi, Please review > Usually most OSes are configured with page size of 4K, but some others are > configured with 64K. If jdk binary is built on 4K platform and run on > different configured platforms, CDS fails to be loaded due to region > alignment mismatch: > Unable to map CDS archive --

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v7]

2021-03-10 Thread Thomas Stuefe
On Wed, 10 Mar 2021 18:44:18 GMT, Thomas Stuefe wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains seven commits: >> >> - Merge branch 'master' into jdk-8236847 >> - Merge master >> - Add --enable-compatible-cds

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v7]

2021-03-10 Thread Thomas Stuefe
On Wed, 10 Mar 2021 17:41:25 GMT, Yumin Qi wrote: >> Hi, Please review >> Usually most OSes are configured with page size of 4K, but some others are >> configured with 64K. If jdk binary is built on 4K platform and run on >> different configured platforms, CDS fails to be loaded due to region

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v7]

2021-03-10 Thread Yumin Qi
> Hi, Please review > Usually most OSes are configured with page size of 4K, but some others are > configured with 64K. If jdk binary is built on 4K platform and run on > different configured platforms, CDS fails to be loaded due to region > alignment mismatch: > Unable to map CDS archive --

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v6]

2021-03-10 Thread Yumin Qi
On Tue, 9 Mar 2021 17:42:34 GMT, Magnus Ihse Bursie wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge master >> - Add --enable-compatible-cds-alignment for linux-aarch64 and macosx-x64

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v12]

2021-03-10 Thread Kevin Rushforth
On Wed, 10 Mar 2021 10:51:08 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v11]

2021-03-10 Thread Ajit Ghaisas
On Tue, 9 Mar 2021 20:18:08 GMT, Sergey Bylokhov wrote: >> Ajit Ghaisas has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 41 additional >> commits

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]

2021-03-10 Thread Ajit Ghaisas
On Sun, 7 Mar 2021 22:40:53 GMT, Sergey Bylokhov wrote: >> Ajit Ghaisas has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 36 additional >> commits

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v12]

2021-03-10 Thread Ajit Ghaisas
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project -