Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 22:28:50 GMT, Yumin Qi wrote: >> src/hotspot/share/cds/lambdaProxyClassDictionary.hpp line 28: >> >>> 26: #define SHARED_CDS_LAMBDAPROXYCLASSINFO_HPP >>> 27: #include "cds/metaspaceShared.hpp" >>> 28: #include "classfile/javaClasses.hpp" >> >> Is this include necessary? > >

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Yumin Qi
On Fri, 25 Jun 2021 16:50:37 GMT, Calvin Cheung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > src/hotspot/share/cds/lambdaProxyClassDictionary.hpp l

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime