Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-28 Thread Ioi Lam
On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Integrated: 8268821: Split systemDictionaryShared.cpp

2021-06-28 Thread Yumin Qi
On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-28 Thread Yumin Qi
On Mon, 28 Jun 2021 23:13:24 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > This looks OK to me. > > The naming of the various classes

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found [v2]

2021-06-28 Thread Jan Lahoda
On Fri, 11 Jun 2021 21:06:41 GMT, Joe Darcy wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found [v2]

2021-06-28 Thread Jan Lahoda
> [this is an improved version of openjdk/jdk PR: > https://github.com/openjdk/jdk/pull/4428 > ] > > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation sun.misc.Contended). If > javac will try to load them (while discoverin

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-06-28 Thread Richard Reingruber
On Wed, 16 Jun 2021 16:13:58 GMT, jtfuller111 wrote: >> Hello, could anyone kindly take a look at this? > >> Hi @jtfuller111, >> >> I've tested the fix and found that it eliminates the random moves of the >> view port when zooming. Thumbs up for that. It still changes the point that >> is cen