Re: RFR [9] : get_source.sh should be more friendly to MQ

h qpop -a || exit 1 > >> +fi > >> + > >> # Update all existing repositories to the latest sources > >> -sh ./common/bin/hgforest.sh pull -u > >> +sh ./common/bin/hgforest.sh pull -u || exit 1 > >> > >> +# Push all patches, if any,

Re: RFR [9] : get_source.sh should be more friendly to MQ

all patches, if any, before updating > >>> +if [ "${patchdirs}" != "" ] ; then > >>> + echo "Found queue repository, qpop." > >>> + sh ./common/bin/hgforest.sh qpop -a || exit 1 > >>> +fi > >>> + > >>>

Re: RFR [9] : get_source.sh should be more friendly to MQ

${patchdirs}" != "" ] ; then > >> + echo "Found queue repository, qpop." > >> + sh ./common/bin/hgforest.sh qpop -a || exit 1 > >> +fi > >> + > >> # Update all existing repositories to the latest sources > >> -

Re: RFR 8030011: Update Hotspot version string output

Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: > ... > I think I incorporated all the changes David, John and you suggested and > started some sanity testing; > Here's is the latest webrev: > > http://cr.openjdk.java.net/~amurillo/9/8030011/ > > Please review (don't forget to refresh

Re: RFR 8030011: Update Hotspot version string output

Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: > > Please review this change to make the hotspot related output produced by > "java -version" > match the corresponding JDK output: > > webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ > Bug: https://bugs.openjdk.java.net/browse/J

Re: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit

Tao Mao (tao@oracle.com) wrote: > The hsx25 fix has been pushed already. Then I got the > 7u40-critical-approved. > > When I tried backporting to hsx24, it didn't apply to the hsx24 repo > cleanly. Thus, I made the patch manually (copy-and-paste style) and now > need some quick reviews to g

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

Erik Joelsson (erik.joels...@oracle.com) wrote: > I was wrong, just setting the macros below did not generate 10.7 > compatible bits when built on 10.8. Since I already pushed the old > solution (except for hotspot), I created a new bug. Here is a new set of > patches, combining -DMAC_OS_X_VERSI

Re: Need reviewers: more predictable binaries

Kelly O'Hair (kelly.oh...@oracle.com) wrote: > Yes, but I feel like I need to get some kind of approval from a higher level > before I try and declare that > use of THIS_FILE is a 'jdk convention', and that will trigger long debates :^( > > I also need to deal with hotspot, which is a bit trickie

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

Kelly O'Hair (kelly.oh...@oracle.com) wrote: > Looks fine to me. Thanks Kelly. -John > On Sep 5, 2012, at 12:08 PM, John Coomes wrote: > > > Please review this small change to keep the script in sync with the > > forest structure. > > > > webrev: > &

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

t; > -kto > > > > On Sep 5, 2012, at 12:08 PM, John Coomes wrote: > > > >> Please review this small change to keep the script in sync with the > >> forest structure. > >> > >> webrev: > >> > >> http://cr.openjdk.java.net/~jcoom

review request - 7196361 add hotspot/make/closed to hgforest.sh

Please review this small change to keep the script in sync with the forest structure. webrev: http://cr.openjdk.java.net/~jcoomes/7196361-hs-make-closed/ inline diff: diff -r d5e73011bde2 -r e177daf578bd make/scripts/hgforest.sh --- a/make/scripts/hgforest.sh Thu Aug 30 10:26:55 2012 -0700 +++

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

Tim Bell (tim.b...@oracle.com) wrote: > I went over the open changes again and removed some debug code left in > by mistake, updated copyright dates and fixed a few typos. Here is an > updated webrev: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.01/ > > These changes are building in

Re: Building OpenJDK 6 on Solaris sparc

Weiqi Gao (weiqi...@gmail.com) wrote: > Hi, > > I'm trying to build OpenJDK 6 and OpenJDK 7 on a variety of machines. > I have encountered the following error while building OpenJDK 7 > (http://hg.openjdk.java.net/jdk7/jdk7) on Solaris sparc (SunOS cicada2 > 5.10 Generic_139555-08 sun4u sparc SUNW

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

Erik Joelsson (erik.joels...@oracle.com) wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC)

Re: How to handle a merge problem

David Holmes (david.hol...@oracle.com) wrote: > On 31/01/2012 2:50 PM, Pete Brunet wrote: > ... > > Or maybe I should start from > > scratch, apply my patch and fix the issues that way. I seem to remember > > that the one time I did have a problem applying a patch to fresh clone I > > was able to

Re: RFR: 7133124 Remove redundant packages from JAR command line

Dmitry Samersoff (dmitry.samers...@oracle.com) wrote: > Kelly, > > > The serialize checkins issue can be minimized some by using > > distributed SCMs (Mercurial, Git, etc) > > We have chosen a model: > > build->test->integrate > > but we may consider different approach: > > integrate->build->t

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

David Holmes (david.hol...@oracle.com) wrote: > Okay now that my brain is functioning again lets see if it is third-time > lucky: > > http://cr.openjdk.java.net/~dholmes/7036525/webrev.2/ > > This reverts things back to my original webrev where we set > HS_ALT_SRC_REL to NO_SUCH_PATH. It has to

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

David Holmes (david.hol...@oracle.com) wrote: > John Coomes said the following on 05/04/11 02:37: > > David Holmes (david.hol...@oracle.com) wrote: > >> I've just made the change as John suggested and to be honest I don't > >> know why I didn't think of t

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

head is disbelief. I'll > > try this again. > > > > David > > > > John Coomes said the following on 04/30/11 03:47: > >> David Holmes (david.hol...@oracle.com) wrote: > >>> http://cr.openjdk.java.net/~dholmes/7036525/webrev/ > >>&g

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

David Holmes (david.hol...@oracle.com) wrote: > Hi Keith, > > Keith McGuigan said the following on 05/03/11 02:13: > > On Apr 29, 2011, at 1:47 PM, John Coomes wrote: > > > >> David Holmes (david.hol...@oracle.com) wrote: > >>> http://c

(Fwd) review request (S): 7037250 cscope.make is silently broken

Mea culpa, forgot to ask for permission, so am asking for forgiveness instead. This makefile change has been pushed to the hotspot-gc repo. It has no effect on the product, simply fixes cscope database generation. -John --- start of forwarded message --- From: John Coomes To: hotspot

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

David Holmes (david.hol...@oracle.com) wrote: > http://cr.openjdk.java.net/~dholmes/7036525/webrev/ > > Simple but crude. If OPENJDK is defined then the Hotspot "alternative > source" mechanism is effectively disabled by checking for a non-existent > path. This allows people using the alt-src me

Re: JDK8 Preliminary Repository Layout

Johan Walles (johan.wal...@oracle.com) wrote: > 2011-03-10 10:33, Anthony Petrov skrev: > > Hi Andrew, > > > > On 3/10/2011 3:48 AM, Dr Andrew John Hughes wrote: > [snip] > >> Hey, I'd just make it all one repository as they all interdepend on > >> each other > > > > One huge "all-in-all" repositor

Re: Need reviewer: change sanity check on make 3.81

Kelly O'Hair (kelly.oh...@oracle.com) wrote: > Need reviewer: change sanity check on make 3.81 > > 7014301: Change make 3.81 sanity check to a fatal, 3.81 is needed now > > Use of gnu make 3.81 or newer is required now, which should be readily > available on all platforms. I recommend a big he

Re: Need reviewer: NONFCS_BUILD_INFO to add to the non-fcs version string

Kelly O'Hair (kelly.oh...@oracle.com) wrote: > Dang... just shoot me now. :^( > > Try this: >http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/ > > Sorry about that. Aren't we using the term GA (general availability) instead of FCS these days? Aside from that, looks fine. -J

Re: Need reviewer on SS12u1 change for jdk7

Kelly O'Hair (kelly.oh...@oracle.com) wrote: > > Need a reviewer. > > As of jdk7 Build 108, the jdk7 Solaris builds are being done with Sun > Studio 12 Update 1 plus some patches. > These changes just update the sanity checks in the jdk repository. > Use of a different compiler just issues a sa

Re: Building OpenJDK with SunStudio 12u1 on OpenSolaris snv_134

Andreas Kohn (andreas.k...@fredhopper.com) wrote: > On Mon, 2010-04-12 at 09:58 -0700, Kelly O'Hair wrote: > > You need some of the Sun Studio compiler patches made to 12u1 to build > > hotspot. > > Ah, ok. I'll stick to SS12 then. I'd recommend that for now. There are some mods to hotspot req

Re: Building OpenJDK Java 1.7.0 on Mac OS X 10.6

Maxim Porges (maxim.por...@highwinds.com) wrote: > Hi, > > I've been following Stephen Bannasch's very thorough and detailed > article > (http://confluence.concord.org/display/CCTR/Build+OpenJDK+Java+1.7.0+on+Mac+OS+X+10.5 > > ) for installing OpenJDK 1.7.0 on OS X (thanks very much to

Re: OpenJDK 6 build 14 source posted

Mark Wielaard ([EMAIL PROTECTED]) wrote: > Hi John, > > On Thu, 2008-12-04 at 10:53 -0800, John Coomes wrote: > > > > 32-bit systems are unaffected (not sure why). > > > > > > It's a bug. The code is basically this: > > > ... > >

Re: OpenJDK 6 build 14 source posted

Andrew Haley ([EMAIL PROTECTED]) wrote: > Martin Buchholz wrote: > > On Wed, Dec 3, 2008 at 11:38, Joe Darcy <[EMAIL PROTECTED]> wrote: > >> The source bundle for OpenJDK 6 build 14 is available for download from: > >> > >>http://download.java.net/openjdk/jdk6/ > > > > The new Hotspot 11 faile

Re: Recommended GCC version?

Mario Torre ([EMAIL PROTECTED]) wrote: > Il giorno lun, 31/03/2008 alle 18.37 +0200, Clemens Eisserer ha scritto: > > Hello, > > > > I wonder which version of GCC is recommended for building OpenJDK? > > 4.3 will probably not work out-of-the-box, should I downgrade to 4.2 or 4.1? > > ... > > Thank

Re: multiple tags for a changeset (was Re: jdk7/MASTER/hotspot: 2 new changesets)

part of the "error checking and polish" that I conveniently left out :-). The script is a hack to workaround "hg tag" not accepting multiple tag names. I'd prefer to fix hg tag, but can't do that yet. > Not sure it matters a great deal either way. The moon won

multiple tags for a changeset (was Re: jdk7/MASTER/hotspot: 2 new changesets)

[EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: > Changeset: 38b77760d8e2 > Author:xdono > Date: 2007-11-15 17:12 -0800 > URL: http://hg.openjdk.java.net/jdk7/MASTER/hotspot/rev/38b77760d8e2 > > Added tag jdk7-b98 for changeset 280051e520a0 > > + .hgtags > > Changeset: de9a59a5e8da >

jdk7/hotspot-gc/hotspot: 9876543 make gc better (fix comment)

Changeset: 98a807091399 Author:jcoomes Date: 2007-11-14 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/98a807091399 9876543 make gc better (fix comment) ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

jdk7/hotspot-gc/hotspot: 9876543 make gc better

Changeset: e44754018a19 Author:jcoomes Date: 2007-11-14 16:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e44754018a19 9876543 make gc better ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp