Re: RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Hi Yumin, Looks good to me. Just one small nit: +   LogTarget(Info, cds) lt; +   if (lt.is_enabled()) { +   lt.print("trying to map %s", _full_path); +   } This can be simplified as log_info(cds)("trying to map %s", _full_path); NO need for updated webrev. Thanks - Ioi On 5/14/20 10:40

Re: RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Hi, Erik   Thanks for review! Yumin On 5/14/20 10:57 AM, Erik Joelsson wrote: Build changes look good. /Erik On 2020-05-14 10:40, Yumin Qi wrote: Hi,   Please review:   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/w

Re: RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Build changes look good. /Erik On 2020-05-14 10:40, Yumin Qi wrote: Hi,   Please review:   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/ Summary:  After 8232069, CDS can create shared archive with -XX:-UseCo

RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Hi,   Please review:   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/ Summary:  After 8232069, CDS can create shared archive with -XX:-UseCompressedOops which also turned off by ZGC. The build with cds enabled