Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-28 Thread Ioi Lam
On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-28 Thread Yumin Qi
On Mon, 28 Jun 2021 23:13:24 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > This looks OK to me. > > The naming of the various classes

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 22:28:50 GMT, Yumin Qi wrote: >> src/hotspot/share/cds/lambdaProxyClassDictionary.hpp line 28: >> >>> 26: #define SHARED_CDS_LAMBDAPROXYCLASSINFO_HPP >>> 27: #include "cds/metaspaceShared.hpp" >>> 28: #include "classfile/javaClasses.hpp" >> >> Is this include necessary? > >

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Yumin Qi
On Fri, 25 Jun 2021 16:50:37 GMT, Calvin Cheung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > src/hotspot/share/cds/lambdaProxyClassDictionary.hpp l

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-24 Thread Yumin Qi
> Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to > sharedClassInfo.[ch]pp, also moved lambda proxy

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v3]

2021-06-23 Thread Calvin Cheung
On Thu, 24 Jun 2021 03:11:35 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v3]

2021-06-23 Thread Yumin Qi
> Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to > sharedClassInfo.[ch]pp, also moved lambda proxy

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

2021-06-23 Thread Yumin Qi
On Wed, 23 Jun 2021 20:45:49 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

2021-06-23 Thread Calvin Cheung
On Wed, 23 Jun 2021 20:45:49 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

2021-06-23 Thread Yumin Qi
> Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to > sharedClassInfo.[ch]pp, also moved lambda proxy

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-23 Thread Yumin Qi
On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-23 Thread Yumin Qi
On Wed, 23 Jun 2021 12:40:57 GMT, Erik Joelsson wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/Ru

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-23 Thread Erik Joelsson
On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-22 Thread David Holmes
Hi Yumin, On 23/06/2021 4:19 pm, Yumin Qi wrote: Hi, Please review systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to shared

RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-22 Thread Yumin Qi
Hi, Please review systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to sharedClassInfo.[ch]pp, also moved lambda proxy related to