Re: RFR: 8296904: Improve handling of macos xcode toolchain [v5]

2022-11-17 Thread Christoph Langer
> With this PR I'd like to make it easier to use dedicated installations of > Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode > globally via `xcode-select`. > > I propose adding a new configure flag `--with-xcode-path` that takes the path > to an Xcode installation.

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v3]

2022-11-17 Thread Christoph Langer
On Wed, 16 Nov 2022 19:52:05 GMT, Magnus Ihse Bursie wrote: > Is there perhaps some documentation in doc/building.md that needs updating? I > know there is a bit written about Xcode, I can imagine some pointers to this > new argument would fit in there. Good suggestion. I made some edits in bu

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v6]

2022-11-17 Thread Christoph Langer
> With this PR I'd like to make it easier to use dedicated installations of > Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode > globally via `xcode-select`. > > I propose adding a new configure flag `--with-xcode-path` that takes the path > to an Xcode installation.

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v4]

2022-11-17 Thread Christoph Langer
> With this PR I'd like to make it easier to use dedicated installations of > Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode > globally via `xcode-select`. > > I propose adding a new configure flag `--with-xcode-path` that takes the path > to an Xcode installation.

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v5]

2022-11-17 Thread Matias Saavedra Silva
> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, > this flag doesn't work across JDK 19 and 20. > > Expected: JDK 20 should recreate the specified CDS archive > Actual: JDK 20 cannot recognize the archive file and gives up > > The new field from GenericCDSFileMapHeader

Re: RFR: 8297088: Update LCMS to 2.14

2022-11-17 Thread Erik Joelsson
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. Build change looks go

RFR: 8297088: Update LCMS to 2.14

2022-11-17 Thread Alisen Chung
Redo of 8295369: Update LCMS to 2.14 Update LCMS to newest release. Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a build error in linux. Automatic tests and J2D demo tests were run. - Commit messages: - disabled warning for type-limits for lcms - 8295369

Re: RFR: 8297165: Update Pandoc to version 2.19.2 for Oracle builds [v2]

2022-11-17 Thread Mikael Vidstedt
On Wed, 16 Nov 2022 23:11:58 GMT, Mikael Vidstedt wrote: >> Update to Pandoc 2.19.2 for all Oracle platforms/builds. This updates the >> createPandocBundle.sh script to reflect the bundle layout of the latest >> upstream pandoc bundles, and adds support for an optional platform argument >> to

Integrated: 8297165: Update Pandoc to version 2.19.2 for Oracle builds

2022-11-17 Thread Mikael Vidstedt
On Wed, 16 Nov 2022 22:02:43 GMT, Mikael Vidstedt wrote: > Update to Pandoc 2.19.2 for all Oracle platforms/builds. This updates the > createPandocBundle.sh script to reflect the bundle layout of the latest > upstream pandoc bundles, and adds support for an optional platform argument > to the

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v4]

2022-11-17 Thread Matias Saavedra Silva
> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, > this flag doesn't work across JDK 19 and 20. > > Expected: JDK 20 should recreate the specified CDS archive > Actual: JDK 20 cannot recognize the archive file and gives up > > The new field from GenericCDSFileMapHeader

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v3]

2022-11-17 Thread Erik Joelsson
On Wed, 16 Nov 2022 22:30:56 GMT, Matias Saavedra Silva wrote: >> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, >> this flag doesn't work across JDK 19 and 20. >> >> Expected: JDK 20 should recreate the specified CDS archive >> Actual: JDK 20 cannot recognize the ar

Integrated: 8297041: Remove the last remnants of sjavac

2022-11-17 Thread Magnus Ihse Bursie
On Wed, 16 Nov 2022 13:22:43 GMT, Magnus Ihse Bursie wrote: > The sjavac ("smart javac") was an ambitious project. It should parallelize > java compilation, create a background daemon process that kept the JVM "hot" > with the JITted javac code, define a public api so only noticeable changes in

Re: RFR: 8297041: Remove the last remnants of sjavac [v2]

2022-11-17 Thread Magnus Ihse Bursie
> The sjavac ("smart javac") was an ambitious project. It should parallelize > java compilation, create a background daemon process that kept the JVM "hot" > with the JITted javac code, define a public api so only noticeable changes in > a class caused further dependency compilations, etc etc. >

Re: RFR: 8296886: Fix various include sort order issues [v2]

2022-11-17 Thread Stefan Karlsson
On Mon, 14 Nov 2022 11:39:10 GMT, Kim Barrett wrote: >> src/hotspot/os/windows/jvm_windows.cpp line 27: >> >>> 25: #include "precompiled.hpp" >>> 26: #include "include/jvm.h" >>> 27: #include "os_windows.hpp" >> >> os_windows should be at the end, included using `OS_HEADER("os")`. > > But shoul

Re: RFR: 8296886: Fix various include sort order issues [v2]

2022-11-17 Thread Stefan Karlsson
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote: >> The sorted blocks of includes have deteriorated to the point that I felt >> compelled to clean up some of the issues. >> >> One of the more prevalent issues is that files in src/hotspot/share/include >> are not properly sorted. There

Re: RFR: 8296886: Fix various include sort order issues [v2]

2022-11-17 Thread Stefan Karlsson
On Fri, 11 Nov 2022 21:01:31 GMT, Kim Barrett wrote: >> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Cleanups >> - Merge remote-tracking branch 'upstream/master' into >> various_include