On Wed, 23 Nov 2022 04:58:38 GMT, Kim Barrett wrote:
>> Out of curiosity, is there a way to get the discussion on approving the use
>> of alignas back up? I've read through 8250269 briefly and unlike the issues
>> that come with C++ attributes, alignas looks relatively straightforward to
>> sw
On Tue, 29 Nov 2022 01:03:55 GMT, Julian Waters wrote:
> Add alignas to the permitted features set with some restrictions. (Thanks
> @kimbarrett for the help)
This pull request has now been integrated.
Changeset: 22f5d014
Author:Julian Waters
URL:
https://git.openjdk.org/jdk/commit
> Add alignas to the permitted features set with some restrictions. (Thanks
> @kimbarrett for the help)
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull re
On Tue, 29 Nov 2022 17:07:02 GMT, Julian Waters wrote:
>> Digging into this some more, the friend declaration exists to provide access
>> to the private `os::win32::enum Ept`.
>>
>> One obvious and cheap solution to that would be to make that enum public. I
>> think that would be an improveme
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10924
On Wed, 23 Nov 2022 21:36:24 GMT, Kim Barrett wrote:
>> I think the problem here is the friend declaration, which doesn't look like
>> it's needed and could be deleted.
>
> Digging into this some more, the friend declaration exists to provide access
> to the private `os::win32::enum Ept`.
>
>
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
Please review the change to update to using jtreg `7.1`.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
This pull requ
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10924
> Eclipse is a popular and very well-known IDE in the world of Java
> development, utilized widely in many contexts, by beginners and experienced
> teams alike. Although a relatively lightweight IDE, it features surprisingly
> powerful indexing and code analysis capabilities, as well as useful t
On Tue, 29 Nov 2022 01:03:55 GMT, Julian Waters wrote:
> Add alignas to the permitted features set with some restrictions. (Thanks
> @kimbarrett for the help)
I think this is okay (not surprisingly). Please add me as a contributor.
-
Marked as reviewed by kbarrett (Reviewer).
PR
13 matches
Mail list logo
