Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v10]

2022-12-16 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v9]

2022-12-16 Thread Justin King
On Sat, 17 Dec 2022 06:33:43 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Justin King
On Fri, 16 Dec 2022 15:56:44 GMT, Magnus Ihse Bursie wrote: > However, I do think the included source files should be treated like the > autoheaders, and reside in data rather than in `src`. The latter is intended > for buildtools, even though they are a bit scattered at the moment (there is >

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v9]

2022-12-16 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v21]

2022-12-16 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v20]

2022-12-16 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v7]

2022-12-16 Thread Adam Sotona
On Mon, 7 Nov 2022 16:28:19 GMT, Adam Sotona wrote: >> So this will be removed later on in one of the follow up "chicken" PRs? > > It will be removed in this PR later, this specific workaround is not intended > to fall into JDK. > The CompileInterimLangtools patch represents a way how to make th

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v7]

2022-12-16 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v18]

2022-12-16 Thread Julian Waters
On Thu, 15 Dec 2022 14:15:29 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v19]

2022-12-16 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Fri, 9 Dec 2022 20:38:26 GMT, Erik Joelsson wrote: >> make/autoconf/jdk-options.m4 line 450: >> >>> 448: >>> ### >>> 449: # >>> 450: # UndefinedBehaviorSanitizer >> >> I think this logic fits better in `flags.m4`, o

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Integrated: Merge jdk20

2022-12-16 Thread Jesper Wilhelmsson
On Fri, 16 Dec 2022 13:25:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 3696711e Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/3696711efa566fb776d6923da86e17b0e1e22964 Stats: 250 lines

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v18]

2022-12-16 Thread Magnus Ihse Bursie
On Thu, 15 Dec 2022 14:15:29 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

RFR: Merge jdk20

2022-12-16 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge - 8298797: Specification of some restricted methods is incorrect - 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there. - 8297979: ZGC: En