On Fri, 16 Dec 2022 16:10:10 GMT, Magnus Ihse Bursie wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify logic for including __ubsan_default_options
>>
>> Signed-off-by: Justin King
>
> I much also check:
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva
wrote:
> This is an enhancement of the test case in
> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
> against an archive created by the "boot JDK", which is usually set as the
> previous official JDK release when
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva
wrote:
> This is an enhancement of the test case in
> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
> against an archive created by the "boot JDK", which is usually set as the
> previous official JDK release when
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva
wrote:
> This is an enhancement of the test case in
> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
> against an archive created by the "boot JDK", which is usually set as the
> previous official JDK release when
On Wed, 4 Jan 2023 18:41:05 GMT, Justin King wrote:
> > Does Asan assume 8-byte-alignment? I'm hesitant to set this alignment in
> > stone since Metaspace could be allocated, at least now, with smaller
> > alignments. We don't do this now, but I'd like to keep the option open. But
> > see my p
On Wed, 4 Jan 2023 13:55:33 GMT, Justin King wrote:
>> src/hotspot/share/sanitizers/address.h line 56:
>>
>>> 54: #else
>>> 55: // NOOP implementation which preserves the arguments, ensuring they
>>> still compile, but ensures they
>>> 56: // are stripped due to being unreachable.
>>
>> Why is
This is an enhancement of the test case in
[JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests against
an archive created by the "boot JDK", which is usually set as the previous
official JDK release when building the JDK repo.
If it's able to connect to an artifactory that h
On Sat, 17 Dec 2022 06:39:48 GMT, Justin King wrote:
>> Allow building OpenJDK with UBSan. Currently the build fails when optimizing
>> the image due to lots of undefined behavior (it invokes the built JVM).
>> Follow up PRs will either replace the undefined behavior with well defined
>> behav
On Wed, 4 Jan 2023 17:05:54 GMT, Thomas Stuefe wrote:
>> Justin King has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is a
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is a
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote:
> Please review this change to provide and use mechanisms for dealing with uses
> of the standard assert macro (from or ) in 3rd party code
> that we use in HotSpot.
>
> We provide a pair of utility header files, to be included before and aft
On Wed, 4 Jan 2023 17:05:54 GMT, Thomas Stuefe wrote:
> Does Asan assume 8-byte-alignment? I'm hesitant to set this alignment in
> stone since Metaspace could be allocated, at least now, with smaller
> alignments. We don't do this now, but I'd like to keep the option open. But
> see my proposa
On Wed, 4 Jan 2023 13:55:15 GMT, Justin King wrote:
>> This change instruments Metaspace for ASan. Metaspace allocates memory using
>> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
>> applications [manually poisoning/unpoisoning
>> memory](https://github.com/google/sani
On Wed, 4 Jan 2023 09:15:18 GMT, Aleksey Shipilev wrote:
>> This should help to speed up tests significantly. Currently, if we run "make
>> test" with a subset of tests, JTReg would still read the entirety of test
>> root to report on tests that were not run. Even with current suite of tests
>
On Wed, 4 Jan 2023 14:25:12 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 20 -> JDK 21
This pull request has now been integrated.
Changeset: df1caf90
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/df1caf90818558b897a6b8ab80757f2a03398c55
Stats: 299 lines i
Forwardport JDK 20 -> JDK 21
-
Commit messages:
- Merge remote-tracking branch 'jdk20/master' into Merge_jdk20
- 8299476: PPC64 Zero build fails after JDK-8286302
- 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException:
assertTrue: expected true, was false"
- 829
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is a
On Wed, 4 Jan 2023 06:21:26 GMT, David Holmes wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude more zapping when ASan is in use
>>
>> Signed-off-by: Justin King
>
> src/hotspot/share/sanitizers/address.
On Wed, 4 Jan 2023 06:00:36 GMT, David Holmes wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude more zapping when ASan is in use
>>
>> Signed-off-by: Justin King
>
> src/hotspot/share/runtime/os.cpp line
Please review this patch that fixes and re-enables a few warnings in libawt
compilation.
Verified that debug and release builds finish successfully on Win, Mac and
Linux. Also verified that client libs tests still pass.
-
Commit messages:
- Copyright
- snprintf
- cl analyze
- F
> Eclipse is a popular and very well-known IDE in the world of Java
> development, utilized widely in many contexts, by beginners and experienced
> teams alike. Although a relatively lightweight IDE, it features surprisingly
> powerful indexing and code analysis capabilities, as well as useful t
On Wed, 4 Jan 2023 09:15:18 GMT, Aleksey Shipilev wrote:
>> This should help to speed up tests significantly. Currently, if we run "make
>> test" with a subset of tests, JTReg would still read the entirety of test
>> root to report on tests that were not run. Even with current suite of tests
>
On Wed, 4 Jan 2023 09:10:01 GMT, Aleksey Shipilev wrote:
> > I see that in the additional testing section you note, running tests with
> > RETRY_COUNT. Is that intentional? Does retry count play a role in the
> > report generation?
>
> The logic for REPEAT/RETRY_COUNT merges the jtreg reports
On Tue, 3 Jan 2023 06:36:38 GMT, David Holmes wrote:
> Not pretty, but effective.
>
> Do we need some text added to the hotspot style guide to describe this usage?
> Should we bracket all includes of system headers with these, or only those
> known to cause a problem?
Most of the uses are cur
On Wed, 4 Jan 2023 01:40:36 GMT, Jaikiran Pai wrote:
> Please update the copyright years on the files before integrating.
Updated.
> I see that in the additional testing section you note, running tests with
> RETRY_COUNT. Is that intentional? Does retry count play a role in the report
> gener
> This should help to speed up tests significantly. Currently, if we run "make
> test" with a subset of tests, JTReg would still read the entirety of test
> root to report on tests that were not run. Even with current suite of tests
> it gets expensive. If you add more tests to suite -- for exam
27 matches
Mail list logo
