On Mon, 23 Jan 2023 19:34:42 GMT, Archie L. Cobbs wrote:
> [The CSR](https://bugs.openjdk.org/browse/JDK-825) also needs a review
> from a compiler-dev engineer as well if anyone is interested... thanks.
some comments on the CSR:
- I think the value for field `Compatibility Risk` could be
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote:
> This patch adds the `-headerpad_max_install_names` linker argument to the
> build of the `jpackageapplauncher` binary (osx only)
>
> Adding this argument allows the user to use the `install_name_tool` to add
> search paths for the dynamic linker
For a long time, we have been stuck with very old versions of the autoconf
build-aux (config.guess and config.sub) files. Now we have legal approval for
updating these files to versions 2022-09-17.
I have gone through all the modifications we are currently applying through the
wrappers and remo
On Mon, 23 Jan 2023 14:03:53 GMT, Magnus Ihse Bursie wrote:
>> Mikael Vidstedt has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update doc/building.html
>
> make/autoconf/lib-tests.m4 line 63:
>
>> 61: # Verify that the version i
On Tue, 17 Jan 2023 22:18:59 GMT, Erik Joelsson wrote:
> Here is my attempt at solving Coleen's logging issue. This patch changes the
> log level for the "build info" log messages for all native test libs and
> executables to `LogInfo`. It also adds a new meta log message for each call
> to Se
> Please review this PR which updates the required version of googletest to
> v1.13.0.
>
> It’s been (quite) a while since we upgraded the version of googletest used to
> run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1)
> is from 2018 and there is build issue with Xc
> Here is my attempt at solving Coleen's logging issue. This patch changes the
> log level for the "build info" log messages for all native test libs and
> executables to `LogInfo`. It also adds a new meta log message for each call
> to SetupTestFilesCompilation, which is kept on LogWarn level,
> Please review this PR which updates the required version of googletest to
> v1.13.0.
>
> It’s been (quite) a while since we upgraded the version of googletest used to
> run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1)
> is from 2018 and there is build issue with Xc
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote:
> This patch adds the `-headerpad_max_install_names` linker argument to the
> build of the `jpackageapplauncher` binary (osx only)
>
> Adding this argument allows the user to use the `install_name_tool` to add
> search paths for the dynamic linker
> Update some custom launchers to set the default ASan options, without it the
> tests fail due to incompatibility with LSan. Additionally adds `-fno-common`
> for ASan build, as suggested by the docs.
Justin King has updated the pull request incrementally with two additional
commits since the
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote:
> Update some custom launchers to set the default ASan options, without it the
> tests fail due to incompatibility with LSan. Additionally adds `-fno-common`
> for ASan build, as suggested by the docs.
> I think this should be added to _all_
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Tue, 17 Jan 2023 22:18:59 GMT, Erik Joelsson wrote:
> Here is my attempt at solving Coleen's logging issue. This patch changes the
> log level for the "build info" log messages for all native test libs and
> executables to `LogInfo`. It also adds a new meta log message for each call
> to Se
On Thu, 12 Jan 2023 15:06:43 GMT, Julian Waters wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 38 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into eclipse
>> - Progress
>> - Merge re
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote:
> This patch adds the `-headerpad_max_install_names` linker argument to the
> build of the `jpackageapplauncher` binary (osx only)
>
> Adding this argument allows the user to use the `install_name_tool` to add
> search paths for the dynamic linker
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote:
> Update some custom launchers to set the default ASan options, without it the
> tests fail due to incompatibility with LSan. Additionally adds `-fno-common`
> for ASan build, as suggested by the docs.
I think this should be added to *all* t
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote:
>> Please review this PR which updates the required version of googletest to
>> v1.13.0.
>>
>> It’s been (quite) a while since we upgraded the version of googletest used
>> to run the hotspot unit tests (test/hotspot/gtest). The current
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote:
>> Please review this PR which updates the required version of googletest to
>> v1.13.0.
>>
>> It’s been (quite) a while since we upgraded the version of googletest used
>> to run the hotspot unit tests (test/hotspot/gtest). The current
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote:
> Fails like this:
>
>
> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils
> --with-binutils-src=binutils-2.39
> $ make clean build-hsdis
>
> === Output from failing command(s) repeated here ===
> * For target support_hs
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote:
>> Please review this PR which updates the required version of googletest to
>> v1.13.0.
>>
>> It’s been (quite) a while since we upgraded the version of googletest used
>> to run the hotspot unit tests (test/hotspot/gtest). The current
On Mon, 23 Jan 2023 14:00:14 GMT, Magnus Ihse Bursie wrote:
> Given that the capstone hsdis version can be made to match the binutil
> version in functionality, I think it would be a much saner path forward to
> focus on that implementation, and just bundle it with the JVM.
I wish Capstone was
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote:
> Fails like this:
>
>
> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils
> --with-binutils-src=binutils-2.39
> $ make clean build-hsdis
>
> === Output from failing command(s) repeated here ===
> * For target support_hs
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote:
> Fails like this:
>
>
> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils
> --with-binutils-src=binutils-2.39
> $ make clean build-hsdis
>
> === Output from failing command(s) repeated here ===
> * For target support_hs
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote:
> Fails like this:
>
>
> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils
> --with-binutils-src=binutils-2.39
> $ make clean build-hsdis
>
> === Output from failing command(s) repeated here ===
> * For target support_hs
28 matches
Mail list logo
