Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Thu, 2 Feb 2023 06:01:04 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > src/hotspot/share/runtime/arguments.cpp line 3979: > >> 3977: /

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Integrated: 8301393: Include cdb in the Windows devkit

2023-02-01 Thread Erik Joelsson
On Tue, 31 Jan 2023 21:44:34 GMT, Erik Joelsson wrote: > This patch modifies the windows devkit, optionally adding the debugger tools > from the Windows SDK. These tools include `cdb` which the failure_handler > uses to extract information when tests time out. This pull request has now been in

Re: RFR: 8301393: Include cdb in the Windows devkit [v2]

2023-02-01 Thread Mikael Vidstedt
On Wed, 1 Feb 2023 18:39:14 GMT, Erik Joelsson wrote: >> This patch modifies the windows devkit, optionally adding the debugger tools >> from the Windows SDK. These tools include `cdb` which the failure_handler >> uses to extract information when tests time out. > > Erik Joelsson has updated th

Re: RFR: 8301393: Include cdb in the Windows devkit [v2]

2023-02-01 Thread Erik Joelsson
> This patch modifies the windows devkit, optionally adding the debugger tools > from the Windows SDK. These tools include `cdb` which the failure_handler > uses to extract information when tests time out. Erik Joelsson has updated the pull request incrementally with one additional commit since

Re: RFR: 8301393: Include cdb in the Windows devkit

2023-02-01 Thread Mikael Vidstedt
On Tue, 31 Jan 2023 21:44:34 GMT, Erik Joelsson wrote: > This patch modifies the windows devkit, optionally adding the debugger tools > from the Windows SDK. These tools include `cdb` which the failure_handler > uses to extract information when tests time out. Update copyright year --

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot

2023-02-01 Thread Justin King
On Thu, 26 Jan 2023 17:33:28 GMT, Justin King wrote: > Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is especially useful when combined with ASan, as LSan can