Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Maurizio Cimadamore
On Fri, 3 Feb 2023 14:31:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Maurizio Cimadamore
On Fri, 3 Feb 2023 17:46:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Classfile API moved under jdk.internal.classfile package > > src/java.base/share/classes/jdk/internal/classfile/C

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-03 Thread Justin King
On Fri, 3 Feb 2023 06:16:06 GMT, Thomas Stuefe wrote: > Thanks for the explanation. Do I understand correctly: You register address > ranges with LSAN, and at certain points (program exit?) the memory is > examined for pointers that point still to unreleased memory? Does LSAN > instrument mall

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-03 Thread David Holmes
On Fri, 3 Feb 2023 04:26:40 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix grammatical error >> >>Signed-off-by: Justin King >> - Update based on review and remove restriction on c