On Wed, 8 Feb 2023 13:37:04 GMT, Magnus Ihse Bursie wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to JDK
>>
>> Signed-off-by: Justin King
>
> I apologize, the fault lies entirely with me. Just
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a
On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1):
> err
On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1):
> err
On Wed, 8 Feb 2023 15:39:17 GMT, Justin King wrote:
> > I read through your explanation, and through the [design
> > docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument),
> > but my question remains unanswered. See below.
> > > > Metaspace objects hold po
Hi Kumar,
yes, I would agree. Option [3] is my preferred. It brings the code closer to
upstream.
Thanks for tackling this.
Cheers
Christoph
From: build-dev On Behalf Of Kumar Srinivasan
Sent: Dienstag, 7. Februar 2023 20:20
To: build-...@openjdk.java.net; jdk-updates-...@openjdk.java.net
Subj
On Thu, 2 Feb 2023 22:44:40 GMT, Erik Joelsson wrote:
> This patch removes some now obsolete jib profiles configurations.
This pull request has now been integrated.
Changeset: 8a9e383d
Author:Erik Joelsson
URL:
https://git.openjdk.org/jdk/commit/8a9e383dba58ed047ca46007b5af186aade05
On Wed, 8 Feb 2023 06:58:52 GMT, Thomas Stuefe wrote:
> I read through your explanation, and through the [design
> docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument),
> but my question remains unanswered. See below.
>
> > > Metaspace objects hold point
On Wed, 8 Feb 2023 06:45:28 GMT, Thomas Stuefe wrote:
> The informal rule is that ongoing discussions should be closed and that
> nobody strongly objects to a change. Two reviewers are easy to come by. The
> point of this rule is that you have a reasonable chance to block changes you
> strongl
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
@lmesnik If you want, I can take over the issue and solve it correctly. Let me
know.
-
PR: https://git.op
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
It looks like you are correct Magnus, I didn't think about that. I will see
what I can do about solving this properly.
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
Possible solutions include:
* Stripping any potential newline from the end of the input, and keep
unconditionally addin
On Tue, 7 Feb 2023 20:56:01 GMT, Leonid Mesnik wrote:
> The newline is added to be compatible with old make 3.81 which is still used
> on MacOSX.
> Fixed actually by dnsimon.
I don't think this fix is correct. Look again at the documentation of make 4+
`$(file)` command:
"When writing files,
On Wed, 8 Feb 2023 12:19:35 GMT, Adam Sotona wrote:
>>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>>> `ClassTypeSig` and `TypeVarSig`.
>>
>> I really don't follow here. ThrowableSig is a piece of a method signature,
>> which starts with "^" and is followed by either
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote:
>> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been
>> used to identify multiple leaks so far. It can run most of the test suite
>> except those that also fail with ASan, which is being looked at separately.
>> It is
On Wed, 8 Feb 2023 11:07:08 GMT, Maurizio Cimadamore
wrote:
>> `TypeParam` is not a signature, because it simply is not a signature.
>> Per spec:
>>
>> TypeParameter:
>> Identifier ClassBound {InterfaceBound}
>
>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>> `ClassT
On Wed, 8 Feb 2023 07:31:15 GMT, Adam Sotona wrote:
> Any reference to an official specification of CharacterRangeInfo is
> appreciated. Thanks.
There's this - which points back to javac code :-)
https://github.com/jacoco/jacoco/wiki/CharacterRangeTable
-
PR: https://git.openjdk.
On Wed, 8 Feb 2023 11:05:34 GMT, Adam Sotona wrote:
> `ofSymbols` is an alternative to `of` when conflicting method parameters. In
> such case `of` refers to CP entries and `ofSymbols` refer to independent
> symbols describing the objects, like for example `ClassDesc`,
> `MethodTypeDesc`, `Pac
On Wed, 8 Feb 2023 07:24:05 GMT, Adam Sotona wrote:
>> **Specification:**
>>
>> MethodSignature:
>> [TypeParameters] ( {JavaTypeSignature} ) Result {ThrowsSignature}
>>
>> Result:
>> JavaTypeSignature
>> VoidDescriptor
>>
>> ThrowsSignature:
>> ^ ClassTypeSignature
>> ^ TypeVariableSignature
On Tue, 7 Feb 2023 16:07:00 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 16:09:56 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:59:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Tue, 7 Feb 2023 15:26:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:18:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Fri, 3 Feb 2023 18:33:46 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/F
On Tue, 7 Feb 2023 11:53:46 GMT, Maurizio Cimadamore
wrote:
>> `BootstrapMethodEntry` is not a constant pool entry, but
>> `BootstrapMethodsAttribute` entry.
>> It might be rather moved under `attribute` package and renamed to
>> `BootstrapMethodInfo` to follow the same pattern as other attrib
28 matches
Mail list logo
