Re: RFR: 8302124: HotSpot Style Guide should permit noreturn attribute

2023-02-09 Thread Thomas Stuefe
On Fri, 10 Feb 2023 05:26:38 GMT, Kim Barrett wrote: > Please review this change to permit the use of noreturn attributes in HotSpot > code. > > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2761.pdf > https://en.cppreference.com/w/cpp/language/attributes/noreturn > > This will permi

RFR: 8302124: HotSpot Style Guide should permit noreturn attribute

2023-02-09 Thread Kim Barrett
Please review this change to permit the use of noreturn attributes in HotSpot code. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2761.pdf https://en.cppreference.com/w/cpp/language/attributes/noreturn This will permit such changes as marking failed assertions and the like as noreturn,

Re: RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v4]

2023-02-09 Thread Magnus Ihse Bursie
On Thu, 9 Feb 2023 10:21:11 GMT, Matthias Baesken wrote: >> Enhance os::pd_print_cpu_info on macOS and Windows by information about CPU >> frequency and caches. >> On Windows , this info can be obtained by the Processor Power Information >> API or "powerbase" (CallNtPowerInformation , see >> h

Re: RFR: 8294982: Implementation of Classfile API [v16]

2023-02-09 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-09 Thread Adam Sotona
On Tue, 7 Feb 2023 11:48:52 GMT, Maurizio Cimadamore wrote: >> Yes, performance is the main reason. >> I'll note to do a fresh differential performance benchmarks with a HashMap. > > thanks I tried HashMap with String keys and it cause performance regressions, however with Utf8Entry initialize

RFR: 8302155: [AIX] NUM_LCPU is not required variable

2023-02-09 Thread Amit Kumar
We don't need NUM_LCPU, it's just a small code change which removes this variable. I've tested it on AIX and cores are detected successfully with changes. @backwaterred please take look at it. Suggestions are welcomed :) - Commit messages: - could be removed Changes: https://gi

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-09 Thread Maurizio Cimadamore
On Thu, 9 Feb 2023 08:44:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: JDK-8302000: jdk11u build has a very subtle race condition causing builds to break.

2023-02-09 Thread Kumar Srinivasan
Hi Christoph, Thanks for the response, I decided to take #2 internally for expediency. I will start work on #3 shortly. Thanks Kumar From: Langer, Christoph Date: Wednesday, February 8, 2023 at 2:00 PM To: Kumar Srinivasan , build-...@openjdk.java.net , jdk-updates-...@openjdk.java.net Subj

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-09 Thread Maurizio Cimadamore
On Thu, 9 Feb 2023 12:57:19 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/internal/classfile/constantpool/ClassEntr

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-09 Thread Maurizio Cimadamore
On Thu, 9 Feb 2023 08:44:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-09 Thread Maurizio Cimadamore
On Wed, 8 Feb 2023 13:44:13 GMT, Adam Sotona wrote: >> OK, I see your point now, I'll fix it. >> Thanks > > During the fix I found the definition that `ThrowableSig` (as a super-set of > `ClassTypeSig` and `TypeVarSig`) IS `Signature` - that fact is critical for > processing. > For example when

Re: RFR: 8294982: Implementation of Classfile API [v13]

2023-02-09 Thread Adam Sotona
On Wed, 8 Feb 2023 11:16:14 GMT, Maurizio Cimadamore wrote: >> `ofSymbols` is an alternative to `of` when conflicting method parameters. >> In such case `of` refers to CP entries and `ofSymbols` refer to independent >> symbols describing the objects, like for example `ClassDesc`, >> `MethodTyp

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-09 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >