[jdk20] Integrated: 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023

2023-02-10 Thread Jesper Wilhelmsson
On Fri, 10 Feb 2023 18:12:19 GMT, Jesper Wilhelmsson wrote: > EA removed This pull request has now been integrated. Changeset: 82749901 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk20/commit/82749901b1497f524e53e47c45708c8e4a63c8b9 Stats: 1 line in 1 file changed:

Re: [jdk20] RFR: 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023

2023-02-10 Thread Erik Joelsson
On Fri, 10 Feb 2023 18:12:19 GMT, Jesper Wilhelmsson wrote: > EA removed Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/123

Re: [jdk20] RFR: 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023

2023-02-10 Thread Iris Clark
On Fri, 10 Feb 2023 18:12:19 GMT, Jesper Wilhelmsson wrote: > EA removed Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/123

[jdk20] RFR: 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023

2023-02-10 Thread Jesper Wilhelmsson
EA removed - Commit messages: - 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023 Changes: https://git.openjdk.org/jdk20/pull/123/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=123&range=00 Issue: https://bugs.ope

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-10 Thread Maurizio Cimadamore
On Fri, 10 Feb 2023 11:12:25 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/constantpool/AnnotationConstantValueEntry.java >> line 33: >> >>> 31: * which includes the four kinds of primitive constants, and UTF8 >>> constants. >>> 32: */ >>> 33: public sealed in

Re: RFR: 8302155: [AIX] NUM_LCPU is not required variable

2023-02-10 Thread Tyler Steele
On Thu, 9 Feb 2023 15:21:42 GMT, Amit Kumar wrote: > We don't need NUM_LCPU, it's just a small code change which removes this > variable. I've tested it on AIX and cores are detected successfully with > changes. > @backwaterred please take look at it. > Suggestions are welcomed :) I wanted

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-10 Thread Adam Sotona
On Thu, 9 Feb 2023 15:01:03 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/internal/classfile/instruction/MonitorIns

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-10 Thread Adam Sotona
On Thu, 9 Feb 2023 14:11:36 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/internal/classfile/constantpool/Utf8Entry

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-10 Thread Adam Sotona
On Thu, 9 Feb 2023 13:03:46 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/internal/classfile/constantpool/Annotatio

Re: RFR: 8294982: Implementation of Classfile API [v13]

2023-02-10 Thread Adam Sotona
On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - javadoc fixes >> - obsolete identifiers and unused imports cleanup >> - TypeAnnotation.TypePathComponent cl

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-10 Thread Adam Sotona
On Mon, 6 Feb 2023 14:13:36 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/BufWriter.java line 40: >> >>> 38: * to the end of the buffer, as well as to create constant pool entries. >>> 39: */ >>> 40: public sealed interface BufWriter >> >> What is the relations

Re: RFR: 8294982: Implementation of Classfile API [v13]

2023-02-10 Thread Adam Sotona
On Wed, 8 Feb 2023 11:19:32 GMT, Maurizio Cimadamore wrote: >> Any reference to an official specification of CharacterRangeInfo is >> appreciated. >> Thanks. > >> Any reference to an official specification of CharacterRangeInfo is >> appreciated. Thanks. > > There's this - which points back t

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-10 Thread Adam Sotona
On Thu, 9 Feb 2023 12:45:27 GMT, Maurizio Cimadamore wrote: >> During the fix I found the definition that `ThrowableSig` (as a super-set of >> `ClassTypeSig` and `TypeVarSig`) IS `Signature` - that fact is critical for >> processing. >> For example when `MethodSignature` is serialized >> `Thr

Re: RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v4]

2023-02-10 Thread Matthias Baesken
On Thu, 9 Feb 2023 10:21:11 GMT, Matthias Baesken wrote: >> Enhance os::pd_print_cpu_info on macOS and Windows by information about CPU >> frequency and caches. >> On Windows , this info can be obtained by the Processor Power Information >> API or "powerbase" (CallNtPowerInformation , see >> h

Re: RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v3]

2023-02-10 Thread Matthias Baesken
On Wed, 8 Feb 2023 20:46:57 GMT, David Holmes wrote: > I have no idea what possible use the "idle state" information would be in any > case. We don't have that per-processor info on non-Windows. Hi David, there is some info about the idle states at https://learn.microsoft.com/en-us/windows-h