Windows compiled pandoc seems to not work properly

2023-02-21 Thread Julian Waters
Hi all, While generating docs on Windows, it appears to me that pandoc compiled natively for the Windows OS itself never seems to work properly, and when used completely mangles not only the entire html file of which the corresponding markdown file was edited, but every single other html file in t

Re: RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Justin King
On Wed, 22 Feb 2023 00:29:27 GMT, David Holmes wrote: > If ASAN support needs `-debug` wouldn't it make sense to restrict its use to > debug builds? MSVC named it poorly, IMO. It just means generate PDB basically. It doesn't *need* it, just complains that stack traces are better with it.

Re: RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread David Holmes
On Tue, 21 Feb 2023 16:40:07 GMT, Justin King wrote: > Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots > of warnings. If ASAN support needs `-debug` wouldn't it make sense to restrict its use to debug builds? - PR: https://git.openjdk.org/jdk/pull/1269

Re: RFR: 8303016: Invalid escapes in grep patterns

2023-02-21 Thread Mikael Vidstedt
On Tue, 21 Feb 2023 17:49:21 GMT, Mikael Vidstedt wrote: > In a few grep patterns characters are escaped when they shouldn't be. Some > grep versions seem to ignore this, but Cygwin grep generates a warning: Thank you! - PR: https://git.openjdk.org/jdk/pull/12695

Integrated: 8303016: Invalid escapes in grep patterns

2023-02-21 Thread Mikael Vidstedt
On Tue, 21 Feb 2023 17:49:21 GMT, Mikael Vidstedt wrote: > In a few grep patterns characters are escaped when they shouldn't be. Some > grep versions seem to ignore this, but Cygwin grep generates a warning: This pull request has now been integrated. Changeset: f319c92b Author:Mikael Vidst

Integrated: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Justin King
On Tue, 21 Feb 2023 16:40:07 GMT, Justin King wrote: > Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots > of warnings. This pull request has now been integrated. Changeset: ce6de371 Author:Justin King URL: https://git.openjdk.org/jdk/commit/ce6de37172cadc

Re: RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Justin King
On Tue, 21 Feb 2023 16:40:07 GMT, Justin King wrote: > Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots > of warnings. Linux GHA tests look unrelated. This is MSVC-only change. - PR: https://git.openjdk.org/jdk/pull/12693

Integrated: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Mikael Vidstedt
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote: > On windows/cygwin, the PANDOC_VERSION variable includes the carriage return > ('\r') which makes the version check fail: > > checking for pandoc version... 2.19.2 > , not the recommended version 2.19.2n 2.19.2 This pull request has now

Re: RFR: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Mikael Vidstedt
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote: > On windows/cygwin, the PANDOC_VERSION variable includes the carriage return > ('\r') which makes the version check fail: > > checking for pandoc version... 2.19.2 > , not the recommended version 2.19.2n 2.19.2 Thank you all! -

Re: RFR: 8303016: Invalid escapes in grep patterns

2023-02-21 Thread Erik Joelsson
On Tue, 21 Feb 2023 17:49:21 GMT, Mikael Vidstedt wrote: > In a few grep patterns characters are escaped when they shouldn't be. Some > grep versions seem to ignore this, but Cygwin grep generates a warning: Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk

Re: RFR: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Erik Joelsson
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote: > On windows/cygwin, the PANDOC_VERSION variable includes the carriage return > ('\r') which makes the version check fail: > > checking for pandoc version... 2.19.2 > , not the recommended version 2.19.2n 2.19.2 Marked as reviewed by eri

Re: RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Erik Joelsson
On Tue, 21 Feb 2023 16:40:07 GMT, Justin King wrote: > Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots > of warnings. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12693

RFR: 8301119: Support for GB18030-2022

2023-02-21 Thread Naoto Sato
Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since this is not a compatible upgrade to the existing mapping, a new system property `jdk.charset.GB18030` is introduced. If it is set to "2000", the mapping falls back to the existing mapping based on the 2000 standard, othe

Re: RFR: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Lance Andersen
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote: > On windows/cygwin, the PANDOC_VERSION variable includes the carriage return > ('\r') which makes the version check fail: > > checking for pandoc version... 2.19.2 > , not the recommended version 2.19.2n 2.19.2 Marked as reviewed by lan

Re: RFR: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Iris Clark
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote: > On windows/cygwin, the PANDOC_VERSION variable includes the carriage return > ('\r') which makes the version check fail: > > checking for pandoc version... 2.19.2 > , not the recommended version 2.19.2n 2.19.2 Marked as reviewed by iri

RFR: 8303020: Remove carriage return in pandoc version string

2023-02-21 Thread Mikael Vidstedt
On windows/cygwin, the PANDOC_VERSION variable includes the carriage return ('\r') which makes the version check fail: checking for pandoc version... 2.19.2 , not the recommended version 2.19.2n 2.19.2 - Commit messages: - Fix pandoc version check on Windows Changes: https://git.o

RFR: 8303016: Invalid escapes in grep patterns

2023-02-21 Thread Mikael Vidstedt
In a few grep patterns characters are escaped when they shouldn't be. Some grep versions seem to ignore this, but Cygwin grep generates a warning: - Commit messages: - Update copyright years - Remove unnecessary escape in grep patterns Changes: https://git.openjdk.org/jdk/pull/126

Re: RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Justin King
On Tue, 21 Feb 2023 16:40:07 GMT, Justin King wrote: > Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots > of warnings. @magicus Trivial change for ASan under MSVC. Was giving it a run through tier1 today and noticed MSVC complaining heavily in build logs about `-DEBU

RFR: JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

2023-02-21 Thread Justin King
Add `/DEBUG` to `LDFLAGS` for MSVC with ASan. Without it MSVC produces lots of warnings. - Commit messages: - Add -debug to LDFLAGS under MSVC with ASan Changes: https://git.openjdk.org/jdk/pull/12693/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12693&range=00 Issue: h

Integrated: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows

2023-02-21 Thread Matthias Baesken
On Fri, 3 Feb 2023 08:25:09 GMT, Matthias Baesken wrote: > Enhance os::pd_print_cpu_info on macOS and Windows by information about CPU > frequency and caches. > On Windows , this info can be obtained by the Processor Power Information API > or "powerbase" (CallNtPowerInformation , see > https:

Re: RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v6]

2023-02-21 Thread Matthias Baesken
On Fri, 17 Feb 2023 08:17:52 GMT, Matthias Baesken wrote: >> Enhance os::pd_print_cpu_info on macOS and Windows by information about CPU >> frequency and caches. >> On Windows , this info can be obtained by the Processor Power Information >> API or "powerbase" (CallNtPowerInformation , see >>