On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 an
While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
thought I'd get out for the review the next phase of the FDLIBM port: removing
the FDLIBM C sources from the repo.
A repo with the changes for JDK-8302027 and this PR successful build on the
default set of platform and
On Wed, 1 Mar 2023 23:13:55 GMT, Steven R. Loomis wrote:
> my openjdk name should be `srl` … i'm still there
> https://openjdk.org/census#srl
Hello Steven, please follow the instructions here to have your github account
linked to the OpenJDK id
https://wiki.openjdk.org/display/SKARA/Skara#Sk
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
approve
--
Steven R. Loomis
Code Hive Tx, LLC
https://codehivetx.us
> On Mar 1, 2023, at 7:03 PM, Naoto Sato wrote:
>
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aq
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
> locales with `common` locales
> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
> to have the same coverage level of locales, CLDRConverter tool needs to comb
> through the locale files b
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Mon, 6 Feb 2023 13:50:07 GMT, Adam Sotona wrote:
>> Actually, we also have a ClassfileVersion class, so that could be a better
>> place for version numbers?
>
> There were several iterations of "where to store numeric constants".
> It is hard to find them when spread across many classes and d
On Wed, 8 Feb 2023 11:00:14 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/attribute/StackMapTableAttribute.java
>> line 68:
>>
>>> 66: * A simple stack value.
>>> 67: */
>>> 68: public enum SimpleVerificationTypeInfo implements
>>> VerificationType
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 23:19:01 GMT, Naoto Sato wrote:
>> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1212:
>>
>>> 1210: a ->
>>> Locale.forLanguageTag(a[0].trim().replaceAll("_", "-")),
>>> 1211: a -> a[1].trim(),
>>> 1212:
On Wed, 1 Mar 2023 23:02:33 GMT, Steven R. Loomis wrote:
>> make/data/cldr/common/properties/coverageLevels.txt line 2:
>>
>>> 1: #coverageLevels.txt
>>> 2: #Copyright © 2022 Unicode, Inc.
>>
>> older version?
>
> is this from the alpha2 drop? or v42's?
Yes, this is the file fr
On Wed, 1 Mar 2023 23:18:59 GMT, Naoto Sato wrote:
>> is this from the alpha2 drop? or v42's?
>
> Yes, this is the file from the released CLDR v42. We have not integrated v43
> yet.
this is great groundwork.
-
PR: https://git.openjdk.org/jdk/pull/12812
On Wed, 1 Mar 2023 23:06:10 GMT, Steven R. Loomis wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales,
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote:
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
> locales with `common` locales
> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
> to have the same coverage level of locales, CLDRConve
On Wed, 1 Mar 2023 23:02:06 GMT, Steven R. Loomis wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales,
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote:
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
> locales with `common` locales
> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
> to have the same coverage level of locales, CLDRConve
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 21:58:00 GMT, Justin Lu wrote:
> This PR changes the English name for the region `TR`, from `Turkey` to
> `Türkiye`. Although this change is included in the upcoming CLDR v43, it
> should be applied as a spot change so that it can be back-ported properly (As
> it is a common
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
This PR changes the English name for the region `TR`, from `Turkey` to
`Türkiye`. Although this change is included in the upcoming CLDR v43, it should
be applied as a spot change so that it can be back-ported properly (As it is a
common English region name).
This change targets both the CLDR
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 20:28:14 GMT, Mandy Chung wrote:
> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
> version
> number plus the pre-release identifier for example "21-ea".The build
> number
> and additional build information are useful in identifying the inform
On Wed, 1 Mar 2023 21:24:34 GMT, Mandy Chung wrote:
> > I can't actually find that in the current release file, but that shouldn't
> > prevent us from adding the full version string.
>
> `JAVA_VERSION` is added by jlink and not in ReleaseFile.gmk.
Ah, that explains it, if I look in images/jdk/
On Wed, 1 Mar 2023 21:30:21 GMT, Mandy Chung wrote:
>> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
>> version
>> number plus the pre-release identifier for example "21-ea".The build
>> number
>> and additional build information are useful in identifying the i
On Wed, 1 Mar 2023 21:20:18 GMT, Erik Joelsson wrote:
> I can't actually find that in the current release file, but that shouldn't
> prevent us from adding the full version string.
`JAVA_VERSION` is added by jlink and not in ReleaseFile.gmk.
-
PR: https://git.openjdk.org/jdk/pull/
> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
> version
> number plus the pre-release identifier for example "21-ea".The build
> number
> and additional build information are useful in identifying the information
> about a JDK image but not available. This pr
On Wed, 1 Mar 2023 20:28:14 GMT, Mandy Chung wrote:
> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
> version
> number plus the pre-release identifier for example "21-ea".
I can't actually find that in the current release file, but that shouldn't
prevent us from addi
`$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
version
number plus the pre-release identifier for example "21-ea".The build number
and additional build information are useful in identifying the information
about a JDK image but not available. This proposes to add
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
locales with `common` locales
(https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order to
have the same coverage level of locales, CLDRConverter tool needs to comb
through the locale files based on th
On Wed, 1 Mar 2023 18:56:49 GMT, Jan Lahoda wrote:
>> The OpenJDK build is using a Plugin called Depend to avoid building Java
>> code unnecessarily. It has two parts, one is checking module APIs (and
>> forces rebuild of dependent modules if a dependency changes), and second
>> takes modified
On Wed, 1 Mar 2023 11:09:17 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjusting DependTest, as suggested on the review
>
> make/jdk/src/classes/build/tools/depend/Depend.java line 885:
>
>>
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert flag change in ResolverConfi
> The OpenJDK build is using a Plugin called Depend to avoid building Java code
> unnecessarily. It has two parts, one is checking module APIs (and forces
> rebuild of dependent modules if a dependency changes), and second takes
> modified files in a module, and attempts to detect whether it is
On Wed, 1 Mar 2023 18:44:34 GMT, Daniel Jeliński wrote:
>> Probably not. I took a closer look at the docs for GetAdaptersAddresses, and
>> spotted this section that I missed before:
>>
>>> If the GAA_FLAG_INCLUDE_ALL_INTERFACES is set, then all NDIS adapters will
>>> be retrieved even those ad
> Improves performance and correctness, as discussed on the net-dev mailing
> list.
Rich DiCroce has updated the pull request incrementally with one additional
commit since the last revision:
Revert flag change in ResolverConfigurationImpl
-
Changes:
- all: https://git.openjdk
On Wed, 1 Mar 2023 18:31:41 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/ResolverConfigurationImpl.c line 190:
>>
>>> 188: flags |= GAA_FLAG_SKIP_MULTICAST;
>>> 189: flags |= GAA_FLAG_SKIP_FRIENDLY_NAME;
>>> 190: flags |= GAA_FLAG_INCLUDE_ALL_INTERFACES;
>>
>> Is
On Wed, 1 Mar 2023 18:21:14 GMT, Daniel Jeliński wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes as per review comments
>
> src/java.base/windows/native/libnet/ResolverConfigurationImpl.c line 190:
>
>> 18
On Wed, 1 Mar 2023 14:37:53 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes as per review comments
Net
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Thu, 23 Feb 2023 11:50:54 GMT, Daniel Jeliński wrote:
>> Rich DiCroce has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Forgot to add file
>> - Resolve review comments
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 2
> Improves performance and correctness, as discussed on the net-dev mailing
> list.
Rich DiCroce has updated the pull request incrementally with one additional
commit since the last revision:
Changes as per review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/125
On Wed, 1 Mar 2023 13:06:35 GMT, Daniel Jeliński wrote:
> Please review this PR that upgrades winsock lib from version 1 (wsock32) to
> version 2 (ws2_32) and removes unnecessary libs from the build.
>
> With the winsock upgrade we should be able to avoid loading wsock32.dll at
> runtime. Wins
On Wed, 1 Mar 2023 10:12:41 GMT, Jan Lahoda wrote:
> The OpenJDK build is using a Plugin called Depend to avoid building Java code
> unnecessarily. It has two parts, one is checking module APIs (and forces
> rebuild of dependent modules if a dependency changes), and second takes
> modified fil
Please review this PR that upgrades winsock lib from version 1 (wsock32) to
version 2 (ws2_32) and removes unnecessary libs from the build.
With the winsock upgrade we should be able to avoid loading wsock32.dll at
runtime. Winsock is only needed for `htonl` function, and wsock32.dll forwards
t
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Wed, 1 Mar 2023 10:12:41 GMT, Jan Lahoda wrote:
> The OpenJDK build is using a Plugin called Depend to avoid building Java code
> unnecessarily. It has two parts, one is checking module APIs (and forces
> rebuild of dependent modules if a dependency changes), and second takes
> modified fil
The OpenJDK build is using a Plugin called Depend to avoid building Java code
unnecessarily. It has two parts, one is checking module APIs (and forces
rebuild of dependent modules if a dependency changes), and second takes
modified files in a module, and attempts to detect whether it is enough t
On Thu, 16 Feb 2023 14:19:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/ChainedFi
On Thu, 16 Feb 2023 14:58:21 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Transform
On Thu, 16 Feb 2023 11:34:28 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/pac
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
60 matches
Mail list logo
